Add sale_payment_method_automatic_workflow #34

guewen · 2015-02-13T09:07:04Z

Previously, the module sale_automatic_workflow had a dependency on
sale_payment_method. The dependency was there to automatically reconcile
the payments made by sale_payment_method.

Depends on

migration of sale_payment_method #35

coveralls · 2015-02-13T13:37:49Z

Coverage decreased (-39.05%) to 49.32% when pulling 5711ce1 on guewen:8.0-sale_payment_method_automatic_reconcile into 41af5c7 on OCA:8.0.

coveralls · 2015-02-13T13:41:47Z

Coverage decreased (-39.05%) to 49.32% when pulling 5711ce1 on guewen:8.0-sale_payment_method_automatic_reconcile into 41af5c7 on OCA:8.0.

coveralls · 2015-02-13T13:41:47Z

Coverage decreased (-39.05%) to 49.32% when pulling 5711ce1 on guewen:8.0-sale_payment_method_automatic_reconcile into 41af5c7 on OCA:8.0.

coveralls · 2015-02-13T14:19:00Z

Coverage decreased (-39.05%) to 49.32% when pulling bd1d8fc on guewen:8.0-sale_payment_method_automatic_reconcile into 41af5c7 on OCA:8.0.

gurneyalex · 2015-03-12T07:38:18Z

sale_payment_method/README.rst

+=============
+
+The payment methods can be configured in **Sales > Configuration >
+Sales > Payment Methods**.


not sure if the '**' work well with line breaks...

Yeah, it works, because lines with same indentation are joined when parsing. You can check it pressing 'View' on top of here 😉

gurneyalex · 2015-03-12T08:13:19Z

code review, no test, nothing really bad found, just one place where I would like to see a comment (the currency bit), and the author field in metadata needing update.

once done -> 👍

coveralls · 2015-03-23T09:27:08Z

Coverage decreased (-38.79%) to 49.58% when pulling 307bdba on guewen:8.0-sale_payment_method_automatic_reconcile into 13a941d on OCA:8.0.

tremlin · 2015-03-26T15:43:30Z

I reviewed and tested the code (as a part of magentoerpconnect) and I recommend this module for merging 👍

matthieuchoplin · 2015-04-23T14:32:39Z

I have tried to install the module connector_ecommerce from guewen:8.0-sale_payment_method_automatic_reconcile but I am getting this error:

2015-04-23 14:24:57,510 20507 INFO test_failure openerp.modules.loading: loading sale_exceptions/wizard/sale_exception_confirm_view.xml
2015-04-23 14:24:57,541 20507 INFO test_failure openerp.modules.loading: loading sale_exceptions/security/ir.model.access.csv
2015-04-23 14:24:57,562 20507 INFO test_failure openerp.modules.loading: loading sale_exceptions/settings/sale.exception.csv
2015-04-23 14:24:58,712 20507 INFO test_failure openerp.modules.module: module sale_payment_method: creating or updating database tables
2015-04-23 14:24:58,796 20507 ERROR test_failure openerp.http: Exception during JSON request handling.
Traceback (most recent call last):
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/http.py", line 530, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/http.py", line 567, in dispatch
    result = self._call_function(**self.params)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/http.py", line 303, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/service/model.py", line 113, in wrapper
    return f(dbname, *args, **kwargs)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/http.py", line 300, in checked_call
    return self.endpoint(*a, **kw)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/http.py", line 796, in __call__
    return self.method(*args, **kw)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/http.py", line 396, in response_wrap
    response = f(*args, **kw)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/addons/web/controllers/main.py", line 940, in call_button
    action = self._call_kw(model, method, args, {})
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/addons/web/controllers/main.py", line 928, in _call_kw
    return getattr(request.registry.get(model), method)(request.cr, request.uid, *args, **kwargs)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/api.py", line 241, in wrapper
    return old_api(self, *args, **kwargs)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/addons/base/module/module.py", line 450, in button_immediate_install
    return self._button_immediate_function(cr, uid, ids, self.button_install, context=context)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/api.py", line 241, in wrapper
    return old_api(self, *args, **kwargs)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/addons/base/module/module.py", line 498, in _button_immediate_function
    registry = openerp.modules.registry.RegistryManager.new(cr.dbname, update_module=True)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/modules/registry.py", line 368, in new
    openerp.modules.load_modules(registry._db, force_demo, status, update_module)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/modules/loading.py", line 355, in load_modules
    loaded_modules, update_module)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/modules/loading.py", line 255, in load_marked_modules
    loaded, processed = load_module_graph(cr, graph, progressdict, report=report, skip_modules=loaded_modules, perform_checks=perform_checks)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/modules/loading.py", line 157, in load_module_graph
    init_module_models(cr, package.name, models)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/modules/module.py", line 286, in init_module_models
    result = obj._auto_init(cr, {'module': module_name})
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/api.py", line 241, in wrapper
    return old_api(self, *args, **kwargs)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/models.py", line 2620, in _auto_init
    self._set_default_value_on_column(cr, k, context=context)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/api.py", line 241, in wrapper
    return old_api(self, *args, **kwargs)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/models.py", line 2387, in _set_default_value_on_column
    default = default(self, cr, SUPERUSER_ID, context)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/api.py", line 241, in wrapper
    return old_api(self, *args, **kwargs)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/api.py", line 336, in old_api
    result = method(recs, *args, **kwargs)
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/fields.py", line 417, in <lambda>
    lambda recs: self.convert_to_write(value(recs))
  File "/home/matt/work/odoo/odoo-custom/community-apps/odoo/openerp/fields.py", line 1564, in convert_to_write
    return value.id
AttributeError: 'int' object has no attribute 'id'

Maybe this is why the runbot failed.. I cannot see the logs from the runbot.

Previously, the module sale_automatic_workflow had a dependency on sale_payment_method. The dependency was there to automatically reconcile the payments made by sale_payment_method. In Odoo 8.0, the dependency has been removed, so this new module adds the missing bits between the modules.

…_automatic_workflow Because it goes further than only reconciliation

So it installs when both sale_payment_method and sale_automatic_workflow are installed. This module acts as the glue between them

guewen · 2015-04-23T14:37:26Z

Rebased on 8.0. Waiting for build status.

@matthieuchoplin is it on a fresh database or do you have data in there? The error appears to be in sale_payment_method which is already merged and has a green build.

matthieuchoplin · 2015-04-23T14:54:00Z

I tried again and I managed to install it on fresh database, thanks!
I see an other errors when triggering the tests at the installation but I am not sure it is related to your branch:

2015-04-23 14:48:44,895 21160 INFO connector_ecommerce openerp.modules.module: openerp.addons.connector_ecommerce.tests.test_onchange running tests.
2015-04-23 14:48:44,896 21160 INFO connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: test_play_onchange (openerp.addons.connector_ecommerce.tests.test_onchange.TestOnchange)
2015-04-23 14:48:44,896 21160 INFO connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: ` Play the onchange ConnectorUnit on a sale order
2015-04-23 14:48:44,929 21160 WARNING connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: Deprecated: class Environment must be replaced by ConnectorEnvironment at line 50
2015-04-23 14:48:45,586 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: FAIL
2015-04-23 14:48:45,586 21160 INFO connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: ======================================================================
2015-04-23 14:48:45,586 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: FAIL: test_play_onchange (openerp.addons.connector_ecommerce.tests.test_onchange.TestOnchange)
2015-04-23 14:48:45,586 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: ` Play the onchange ConnectorUnit on a sale order
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: Traceback (most recent call last):
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: `   File "/home/matt/work/odoo/odoo-custom/magentoconnector/connector-ecommerce/connector_ecommerce/tests/test_onchange.py", line 107, in test_play_onchange
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: `     self.assertEqual(line['tax_id'], [tax.id])
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: ` AssertionError: Lists differ: [(6, 0, [4])] != [4]
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: ` 
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: ` First differing element 0:
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: ` (6, 0, [4])
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: ` 4
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: ` 
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: ` - [(6, 0, [4])]
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: ` + [4]
2015-04-23 14:48:45,587 21160 INFO connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: Ran 1 test in 0.692s
2015-04-23 14:48:45,587 21160 ERROR connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange: FAILED
2015-04-23 14:48:45,587 21160 INFO connector_ecommerce openerp.addons.connector_ecommerce.tests.test_onchange:  (failures=1)
2015-04-23 14:48:45,588 21160 ERROR connector_ecommerce openerp.modules.module: Module connector_ecommerce: 1 failures, 0 errors
2015-04-23 14:48:45,588 21160 INFO connector_ecommerce openerp.modules.module: openerp.addons.connector_ecommerce.tests.test_picking_event running tests.

guewen · 2015-04-24T06:34:36Z

I see an other errors when triggering the tests at the installation but I am not sure it is related to your branch:

Thanks, I fixed that on OCA/connector-ecommerce#18

…reconcile Add sale_payment_method_automatic_workflow

guewen added the work in progress label Feb 13, 2015

guewen force-pushed the 8.0-sale_payment_method_automatic_reconcile branch 2 times, most recently from bf0868a to 079cf21 Compare February 13, 2015 13:27

guewen changed the title ~~[WIP] Add sale_payment_method_automatic_reconcile~~ [WIP] Add sale_payment_method_automatic_workflow Feb 13, 2015

guewen force-pushed the 8.0-sale_payment_method_automatic_reconcile branch from 079cf21 to 5711ce1 Compare February 13, 2015 13:31

guewen mentioned this pull request Feb 13, 2015

migration of sale_payment_method #35

Merged

guewen force-pushed the 8.0-sale_payment_method_automatic_reconcile branch from 5711ce1 to bd1d8fc Compare February 13, 2015 14:02

guewen referenced this pull request in pedrobaeza/connector-ecommerce Feb 19, 2015

[MIG] connector_ecommerce: Initial migration

5e620ca

guewen force-pushed the 8.0-sale_payment_method_automatic_reconcile branch 2 times, most recently from 4b2fc3f to 28da673 Compare March 5, 2015 21:21

guewen removed the work in progress label Mar 11, 2015

guewen changed the title ~~[WIP] Add sale_payment_method_automatic_workflow~~ Add sale_payment_method_automatic_workflow Mar 11, 2015

gurneyalex reviewed Mar 12, 2015
View reviewed changes

guewen force-pushed the 8.0-sale_payment_method_automatic_reconcile branch 2 times, most recently from 9d28325 to 4893010 Compare March 12, 2015 10:29

guewen mentioned this pull request Mar 20, 2015

Migration of connector_ecommerce OCA/connector-ecommerce#18

Merged

3 tasks

guewen force-pushed the 8.0-sale_payment_method_automatic_reconcile branch from 4893010 to 307bdba Compare March 23, 2015 09:09

guewen added the needs review label Apr 9, 2015

guewen and others added 10 commits April 23, 2015 16:35

Migrate to the new API

e76d949

Add readme

f37674a

Rename sale_payment_method_automatic_reconcile to sale_payment_method…

e563d03

…_automatic_workflow Because it goes further than only reconciliation

Set the module as auto_install

603c36a

So it installs when both sale_payment_method and sale_automatic_workflow are installed. This module acts as the glue between them

Adapt description and name

3d8c014

Add the link between the payment method and the automatic workflow

13f4aa7

Fix coding errors

5edc469

Add translations

7e5f632

Correct author list, add OCA

9934fef

guewen force-pushed the 8.0-sale_payment_method_automatic_reconcile branch from 307bdba to 9934fef Compare April 23, 2015 14:36

yvaucher added a commit that referenced this pull request May 8, 2015

Merge pull request #34 from guewen/8.0-sale_payment_method_automatic_…

5e2168a

…reconcile Add sale_payment_method_automatic_workflow

yvaucher merged commit 5e2168a into OCA:8.0 May 8, 2015

yvaucher removed the needs review label May 8, 2015

tungocbui mentioned this pull request Feb 2, 2016

[8.0] Could not find the module sale_payment_method_automatic_workflow in the repo "e-commerce" (branch 8.0) OCA/connector-ecommerce#31

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sale_payment_method_automatic_workflow #34

Add sale_payment_method_automatic_workflow #34

guewen commented Feb 13, 2015

coveralls commented Feb 13, 2015

coveralls commented Feb 13, 2015

coveralls commented Feb 13, 2015

coveralls commented Feb 13, 2015

gurneyalex Mar 12, 2015

pedrobaeza Mar 12, 2015

gurneyalex Mar 12, 2015

gurneyalex commented Mar 12, 2015

coveralls commented Mar 23, 2015

tremlin commented Mar 26, 2015

matthieuchoplin commented Apr 23, 2015

guewen commented Apr 23, 2015

matthieuchoplin commented Apr 23, 2015

guewen commented Apr 24, 2015

Add sale_payment_method_automatic_workflow #34

Add sale_payment_method_automatic_workflow #34

Conversation

guewen commented Feb 13, 2015

coveralls commented Feb 13, 2015

coveralls commented Feb 13, 2015

coveralls commented Feb 13, 2015

coveralls commented Feb 13, 2015

gurneyalex Mar 12, 2015

Choose a reason for hiding this comment

pedrobaeza Mar 12, 2015

Choose a reason for hiding this comment

gurneyalex Mar 12, 2015

Choose a reason for hiding this comment

gurneyalex commented Mar 12, 2015

coveralls commented Mar 23, 2015

tremlin commented Mar 26, 2015

matthieuchoplin commented Apr 23, 2015

guewen commented Apr 23, 2015

matthieuchoplin commented Apr 23, 2015

guewen commented Apr 24, 2015