-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sale_payment_method_automatic_workflow #34
Add sale_payment_method_automatic_workflow #34
Conversation
bf0868a
to
079cf21
Compare
079cf21
to
5711ce1
Compare
1 similar comment
5711ce1
to
bd1d8fc
Compare
4b2fc3f
to
28da673
Compare
============= | ||
|
||
The payment methods can be configured in **Sales > Configuration > | ||
Sales > Payment Methods**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if the '**' work well with line breaks...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it works, because lines with same indentation are joined when parsing. You can check it pressing 'View' on top of here 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
code review, no test, nothing really bad found, just one place where I would like to see a comment (the currency bit), and the author field in metadata needing update. once done -> 👍 |
9d28325
to
4893010
Compare
4893010
to
307bdba
Compare
I reviewed and tested the code (as a part of |
I have tried to install the module connector_ecommerce from guewen:8.0-sale_payment_method_automatic_reconcile but I am getting this error:
Maybe this is why the runbot failed.. I cannot see the logs from the runbot. |
Previously, the module sale_automatic_workflow had a dependency on sale_payment_method. The dependency was there to automatically reconcile the payments made by sale_payment_method. In Odoo 8.0, the dependency has been removed, so this new module adds the missing bits between the modules.
…_automatic_workflow Because it goes further than only reconciliation
So it installs when both sale_payment_method and sale_automatic_workflow are installed. This module acts as the glue between them
307bdba
to
9934fef
Compare
Rebased on 8.0. Waiting for build status. @matthieuchoplin is it on a fresh database or do you have data in there? The error appears to be in |
I tried again and I managed to install it on fresh database, thanks!
|
Thanks, I fixed that on OCA/connector-ecommerce#18 |
…reconcile Add sale_payment_method_automatic_workflow
Previously, the module sale_automatic_workflow had a dependency on
sale_payment_method. The dependency was there to automatically reconcile
the payments made by sale_payment_method.
Depends on