migration of sale_payment_method #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
guewen
force-pushed
the
8.0-sale_payment_method-migr
branch
from
92d2204
to
96c4260
Compare
1 similar comment
guewen
force-pushed
the
8.0-sale_payment_method-migr
branch
from
96c4260
to
0f7996b
Compare
| journal_id = fields.Many2one( | ||
| comodel_name='account.journal', | ||
| string='Journal', | ||
| help="If a journal a selected, when a payment is recorded " |
Name is required, use named arguments.
The page automation_information is now created in sale_automatic_workflow the field will be moved in this tab when the other module is installed (with a link module)
Keep the original method with a deprecation warning to help people eventually inheriting this method to not lose their minds when migrating their code.
guewen
force-pushed
the
8.0-sale_payment_method-migr
branch
from
de680f4
to
dfcb129
Compare
guewen
changed the title
|
code looks ok. Having automated tests would be nice, but this will get exercised by the magento connector tests presumably. 👍 |
3 tasks
3 tasks
The computed field was used to hide the button 'View Automatic Payment' when the sales order has at least one payment. It is now using only a condition on payment_ids, thanks to @hbrunn for the correct definition: [('payment_ids', '=', [[6, False, []]])]
|
@guewen, please rename the method mentioned above and I'll merge this to continue with the migration plan. |
That's done already: guewen@dfcb129 |
|
I didn't see the deprecation trick. I merge then. |
pedrobaeza
added a commit
that referenced
this pull request
Apr 7, 2015
migration of sale_payment_method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #33
Continues migration of
sale_payment_method.The things that were common to
sale_payment_methodandsale_automatic_workfloware now in #34