[13.0] [MIG] website_sale_checkout_country_vat: Migration to v13.0 #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CarlosRoca13 check travis. |
CarlosRoca13
force-pushed
the
13.0-MIG-website_sale_checkout_country_vat
branch
from
bba5970
to
45996ae
Compare
…e in website checkout form.
Replace settings with sane defaults. Update VAT flag when address country is updated.
If you leave country field empty before pressing the confirm button at checkout, you were getting a 500 error because `country_id` was `""` (str), which cannot be searched in an int field. Now we set a default `False` value, which will return an empty recordset without that problem.
Add is-invalid class to the input tag when an error is received
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks. Fixed by inheriting from the correct view. Also benefits from OCA/website#720 by using readonly mode if that module is updated. @Tecnativa TT17694 [1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
CarlosRoca13
force-pushed
the
13.0-MIG-website_sale_checkout_country_vat
branch
from
45996ae
to
542946c
Compare
joao-p-marques
approved these changes
Mar 10, 2021
pedrobaeza
approved these changes
Mar 10, 2021
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@CarlosRoca13 please remember to comment on the thread about the previous problems being solved, as if not, reviewers don't get advertised of the new condition. |
|
This PR has the |
|
Congratulations, your PR was merged at f22e68a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT27482
please @sergio-teruel @ernestotejeda review this