Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] website_snippet_country_dropdown: readonly mode #720

Merged
merged 1 commit into from
May 18, 2020
Merged

[IMP] website_snippet_country_dropdown: readonly mode #720

merged 1 commit into from
May 18, 2020

Conversation

yajo
Copy link
Member

@yajo yajo commented May 13, 2020

  • Remove some garbage code.
  • Add readonly mode.
  • Add demo data.
  • Improve tour.

@Tecnativa TT17694

@yajo yajo self-assigned this May 13, 2020
@yajo yajo added this to the 12.0 milestone May 13, 2020
yajo pushed a commit to Tecnativa/e-commerce that referenced this pull request May 13, 2020
[FIX] website_sale_checkout_country_vat: inherit the correct view
f44cd5e 
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks.

Fixed by inheriting from the correct view.

Also benefits from OCA/website#720 by using readonly mode if that module is updated.

@Tecnativa TT17694

[1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
@yajo yajo marked this pull request as ready for review May 13, 2020 10:03
@yajo yajo mentioned this pull request May 13, 2020
Merged
@pedrobaeza pedrobaeza requested a review from Tardo May 14, 2020 14:00
Tardo
Tardo suggested changes May 14, 2020
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good! I think that you can remove all related with "this.$country_code"

@yajo
Copy link
Member Author

yajo commented May 15, 2020

I think that you can remove all related with "this.$country_code"

I think it's still useful. As it is right now, 3 fields are submitted in the form: full text, country code alone, vat alone. It seems the easiest way to support any use case downstream. Besides, that could potentially break backwards compatibility quite badly. Maybe we could consider that when migrating, but I don't really see a big benefit TBH. 🤔

@Tardo
Copy link
Member

Tardo commented May 18, 2020

@yajo I can't found where 'js_country_code' is defined...

[IMP] website_snippet_country_dropdown: readonly mode
656fda7 
- Remove some garbage code.
- Add readonly mode.
- Add demo data.
- Improve tour.

@Tecnativa TT17694
@yajo yajo force-pushed the 12.0-website_snippet_country_dropdown-add_readonly_mode branch from 0833fd0 to 656fda7 Compare May 18, 2020 08:28
@yajo
Copy link
Member Author

yajo commented May 18, 2020

Ooh yes, understood. Removed now. Thanks!

Tardo
Tardo approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-720-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 37fb14a into OCA:12.0 May 18, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2c802f3. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 12.0-website_snippet_country_dropdown-add_readonly_mode branch May 20, 2020 09:56
CarlosRoca13 pushed a commit to Tecnativa/e-commerce that referenced this pull request Feb 23, 2021
@CarlosRoca13
[FIX] website_sale_checkout_country_vat: inherit the correct view
8d1fc37 
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks.

Fixed by inheriting from the correct view.

Also benefits from OCA/website#720 by using readonly mode if that module is updated.

@Tecnativa TT17694

[1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
CarlosRoca13 pushed a commit to Tecnativa/e-commerce that referenced this pull request Feb 23, 2021
@CarlosRoca13
[FIX] website_sale_checkout_country_vat: inherit the correct view
88244d3 
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks.

Fixed by inheriting from the correct view.

Also benefits from OCA/website#720 by using readonly mode if that module is updated.

@Tecnativa TT17694

[1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
CarlosRoca13 pushed a commit to Tecnativa/e-commerce that referenced this pull request Feb 23, 2021
@CarlosRoca13
[FIX] website_sale_checkout_country_vat: inherit the correct view
9472ad9 
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks.

Fixed by inheriting from the correct view.

Also benefits from OCA/website#720 by using readonly mode if that module is updated.

@Tecnativa TT17694

[1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
CarlosRoca13 pushed a commit to Tecnativa/e-commerce that referenced this pull request Mar 8, 2021
@CarlosRoca13
[FIX] website_sale_checkout_country_vat: inherit the correct view
62d8c79 
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks.

Fixed by inheriting from the correct view.

Also benefits from OCA/website#720 by using readonly mode if that module is updated.

@Tecnativa TT17694

[1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
ernestotejeda pushed a commit to Tecnativa/e-commerce that referenced this pull request Oct 21, 2021
@ernestotejeda
[FIX] website_sale_checkout_country_vat: inherit the correct view
a447cb7 
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks.

Fixed by inheriting from the correct view.

Also benefits from OCA/website#720 by using readonly mode if that module is updated.

@Tecnativa TT17694

[1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
ernestotejeda pushed a commit to Tecnativa/e-commerce that referenced this pull request Nov 10, 2021
[FIX] website_sale_checkout_country_vat: inherit the correct view
948a7bf 
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks.

Fixed by inheriting from the correct view.

Also benefits from OCA/website#720 by using readonly mode if that module is updated.

@Tecnativa TT17694

[1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
ernestotejeda pushed a commit to Tecnativa/e-commerce that referenced this pull request Nov 10, 2021
[FIX] website_sale_checkout_country_vat: inherit the correct view
b5699d8 
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks.

Fixed by inheriting from the correct view.

Also benefits from OCA/website#720 by using readonly mode if that module is updated.

@Tecnativa TT17694

[1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
CarlosRoca13 pushed a commit to Tecnativa/e-commerce that referenced this pull request May 25, 2022
@CarlosRoca13
[FIX] website_sale_checkout_country_vat: inherit the correct view
57e8436 
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks.

Fixed by inheriting from the correct view.

Also benefits from OCA/website#720 by using readonly mode if that module is updated.

@Tecnativa TT17694

[1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
pilarvargas-tecnativa pushed a commit to Tecnativa/e-commerce that referenced this pull request Jan 24, 2023
@CarlosRoca13
[FIX] website_sale_checkout_country_vat: inherit the correct view
b8a2f47 
This module happened to be working accidentally because [it was inheriting from a view that had another inheriting view which defined the necessary elements][1]; but that view can be disabled and then this module breaks.

Fixed by inheriting from the correct view.

Also benefits from OCA/website#720 by using readonly mode if that module is updated.

@Tecnativa TT17694

[1]: https://github.com/odoo/odoo/blob/6e99a89574d11811c03fe3cdc61922352a9610ea/addons/website_sale/views/templates.xml#L1296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tardo Tardo Tardo approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees

@yajo yajo

Labels
approved enhancement merged 🎉 ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yajo @Tardo @pedrobaeza @OCA-git-bot