Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] account_invoice_import_ubl #103

Merged
merged 24 commits into from
Jun 10, 2020

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Apr 3, 2019

@pedrobaeza pedrobaeza added this to the 12.0 milestone Apr 3, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 3, 2019
18 tasks
@astirpe astirpe force-pushed the 12_mig_account_invoice_import_ubl branch from ff6f124 to 067fce9 Compare April 4, 2019 14:22
@mgielissen
Copy link

Any progess?

@astirpe astirpe force-pushed the 12_mig_account_invoice_import_ubl branch from 067fce9 to 60adb1f Compare January 3, 2020 11:30
alexis-via and others added 24 commits January 22, 2020 13:36
Update README and fix typo

Adapt code to new UNECE modules from OCA/community-data-files

Add support for UBL refunds

If you have an UBL refund that I could use to test, please contact me !

Add support for import of e-fff invoices (Belgian standard)

Add an e-fff invoice to the test suite (kindly provided by Luc de Meyer from Noviat)

Convert tests from YAML to unittest

Add note about e-fff invoices in README.
…edicated module account_invoice_import_invoice2data

Update README.rst and headers to latest OCA conventions.

Adapt code to plug the module 'ovh_supplier_invoice'

Better key names in the parsed_inv dict
parsed_inv doesn't need to be JSON serializable anymore (small drawback: the invoice is parsed a second time on the second step... but the second step is rarely used)

FIX PEP8 and account_invoice_import_invoice2data unittests

Update REAME and some interface strings about UBL being an ISO standard
Small code changes
…voice dict, cleaner organisation)

Code refactoring: move code in base_business_document_import, factorise code for tax matching (it was duplicated in UBL and ZUGFeRD)
Now support PDF with embedded UBL XML file
Enable unittests on account_invoice_import_ubl
More absolute xpath in account_invoice_import_ubl instead of relative xpath

WARNING: these are big changes, I may have broken a few details
Adapt module account_invoice_import_ubl to use the new base_ubl module
Small fixes
Better generation of address block in UBL (make it coherent with the datamodel of Odoo)
Add generation of several UBL blocks: language, delivery, payment terms, customer party, spplier party
Add parsing of zip in UBL party (will be used in the future for delivery partner match)
Rename key 'quantity' to 'qty' in all parsing dicts['lines']
Add common methods compare_lines() and post_create_or_update()
Make sure price_unit is always untaxed in UBL XML files
Standardize tests/files as the subdir for test import files

Add and update README.rst
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
Prepare v10 branch

Rename __openerp__.py to __manifest__.py and set installable to False

Port account_invoice_import_factur-x and account_invoice_import_ubl to v10.0

base_business_document_import: Add support for the creation of res.bank

Port purchase_order_import* to v10.0

Add ubl invoice generation option in accounting config page
To avoid headaches with invalid files, now check XSD of XML invoices before parsing it upon import
Move Factur-X/zugferd xsd to base_zugferd
Add support for Tax Due Date on invoice import
…81 instead of document type = 380 with negative amounts

Improve the code of refund import to support both negative invoices and positive refunds
Update text displayed in the invoice import wizard and make list of
supported formats modular (like in bank statement import)
…iness document is imported in the right company
@astirpe astirpe force-pushed the 12_mig_account_invoice_import_ubl branch from 60adb1f to d0b7fd6 Compare January 22, 2020 12:36
@mgielissen
Copy link

With the latest version I can import UBL XML files.

Copy link
Member

@jgrandguillaume jgrandguillaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@desdelinux desdelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional review is ok

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-103-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 84a5d92 into OCA:12.0 Jun 10, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e166428. Thanks a lot for contributing to OCA. ❤️

@astirpe astirpe deleted the 12_mig_account_invoice_import_ubl branch June 12, 2020 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants