Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0][MIG] account_invoice_import_invoice2data and dependencies: Migration to 9.0 #11

Closed
wants to merge 3 commits into from
Closed

[9.0][MIG] account_invoice_import_invoice2data and dependencies: Migration to 9.0 #11

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39ba10d
[ADD] migration of account_invoice_import_invoice2data and dependencies
hbrunn Dec 29, 2016
454c116
[DEL] we don't need the patched lib here
hbrunn May 10, 2017
ebc3d9f
[FIX] use standard pdftotext which parses the invoice correctly
hbrunn May 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ addons:
# Search your packages here:
# https://github.com/travis-ci/apt-package-whitelist/blob/master/ubuntu-precise
- wkhtmltopdf # only add if needed and check the before_install section below
- poppler-utils # for invoice2data
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexis-via I was doubting my sanity because for the life of me, I couldn't get the tests work. Then I got the suspicion that pdftotext parses the test invoice incorrectly, and that;s the case, see https://travis-ci.org/OCA/edi/jobs/230782037 - check the install phase, there I first print the output of standard pdftotext on travis, then the version you install. As you see, the total line is botched in the second version. I guess you needed the private version because back then travis had an ancient version only? Any objections to do it the way I propose? And I guess that's also the reason why this still runs on the sudo infrastructure, any objections to change this to the current OCA standard?


# set up an X server to run wkhtmltopdf.
before_install:
Expand All @@ -50,9 +51,6 @@ install:
- export PATH=${HOME}/maintainer-quality-tools/travis:${PATH}
- travis_install_nightly
- pip install invoice2data
- wget -P /tmp http://public.akretion.com/pdftotext-3.04
- sudo mv /tmp/pdftotext-3.04 /usr/local/bin/pdftotext
- sudo chmod 755 /usr/local/bin/pdftotext
- pip install PyPDF2 # needed for account_invoice*zugferd
- pip install phonenumbers

Expand Down