[MIG] 11.0: base_business_document_import #42

njeudy · 2018-01-28T13:47:31Z

No description provided.

…to it.

…voice dict, cleaner organisation) Code refactoring: move code in base_business_document_import, factorise code for tax matching (it was duplicated in UBL and ZUGFeRD) Now support PDF with embedded UBL XML file Enable unittests on account_invoice_import_ubl More absolute xpath in account_invoice_import_ubl instead of relative xpath WARNING: these are big changes, I may have broken a few details

Adapt module account_invoice_import_ubl to use the new base_ubl module Small fixes

Better generation of address block in UBL (make it coherent with the datamodel of Odoo) Add generation of several UBL blocks: language, delivery, payment terms, customer party, spplier party Add parsing of zip in UBL party (will be used in the future for delivery partner match)

Use country code and state code to match partners UBL: Add delivery terms and line item UBL XML block generation UBL: add parsing of delivery block

Add unitests in base_business_document_import Small code enhancements/simplifications

Code cleanup/minor changes

Rename key 'quantity' to 'qty' in all parsing dicts['lines'] Add common methods compare_lines() and post_create_or_update() Make sure price_unit is always untaxed in UBL XML files

'text/xml'

PEP8 fix

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method

Rename __openerp__.py to __manifest__.py and set installable to False

Add match for accounts and journals

Improve match for journals and accounts

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Note: it requires this fix on odoo 10: odoo/odoo#15649

… module Fix spelling mistake and other remarks on README by Tarteo

…o v10.0 base_business_document_import: Add support for the creation of res.bank

Add support for insertion of title in error messages

Add method to create SO in sale.order.import accessible via JSON-RPC

njeudy · 2018-01-28T18:56:14Z

@alexis-via @hbrunn I don't know what to do for this lint error .. it seems to be ok like this ?

base_business_document_import/models/business_document_import.py:870: [C8107(translation-required), BusinessDocumentImport.post_create_or_update] String parameter on "message_post" requires translation. Use _(('%s %s') % ((msg, parsed_dict['note'])))
count_errors 0

moylop260 · 2018-01-29T00:33:55Z

@njeudy The lint `C8107(translation-required)' is a beta one (don't affect the travis build result) and have a issue related OCA/pylint-odoo#187

The real lint red is because flake8 lints:

base_business_document_import/models/business_document_import.py:262:16: F821 undefined name 'e'
base_business_document_import/models/business_document_import.py:844:24: F821 undefined name 'e'
base_business_document_import/models/business_document_import.py:846:16: F821 undefined name 'e'
base_business_document_import/tests/test_business_document_import.py:137:16: F821 undefined name 'e'

coveralls · 2018-01-29T12:00:38Z

Coverage remained the same at 53.604% when pulling 162d69dbdc4b66045600cb97872d401a51b7fceb on njeudy:11-mig-base_business_document_import into b13c8e9 on OCA:11.0.

coveralls · 2018-01-29T12:00:38Z

Coverage remained the same at 53.604% when pulling 0810ed0 on njeudy:11-mig-base_business_document_import into b13c8e9 on OCA:11.0.

astirpe · 2018-01-31T13:54:32Z

base_business_document_import/models/business_document_import.py

+            netloc = urlp.netloc
+            if not urlp.scheme and not netloc:
+                netloc = urlp.path
+            if netloc and netloc.split('.') >= 2:


I think it should be:

if netloc and len(netloc.split('.')) >= 2:

otherwise I get this error:

Error: Odoo Server Error Traceback (most recent call last): File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/odoo/http.py", line 646, in _handle_exception return super(JsonRequest, self)._handle_exception(exception) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/odoo/http.py", line 307, in _handle_exception raise pycompat.reraise(type(exception), exception, sys.exc_info()[2]) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/odoo/tools/pycompat.py", line 87, in reraise raise value File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/odoo/http.py", line 683, in dispatch result = self._call_function(**self.params) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/odoo/http.py", line 339, in _call_function return checked_call(self.db, *args, **kwargs) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/odoo/service/model.py", line 97, in wrapper return f(dbname, *args, **kwargs) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/odoo/http.py", line 332, in checked_call result = self.endpoint(*a, **kw) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/odoo/http.py", line 927, in __call__ return self.method(*args, **kw) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/odoo/http.py", line 512, in response_wrap response = f(*args, **kw) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/addons/web/controllers/main.py", line 934, in call_button action = self._call_kw(model, method, args, {}) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/addons/web/controllers/main.py", line 922, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/odoo/api.py", line 689, in call_kw return call_kw_multi(method, model, args, kwargs) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/odoo-11.0/odoo/api.py", line 680, in call_kw_multi result = method(recs, *args, **kwargs) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/oca/account_invoice_import/wizard/account_invoice_import.py", line 401, in import_invoice parsed_inv['partner'], parsed_inv['chatter_msg']) File "/home/onestein/Pycharm/Gitlab/odoo-11.0/src/oca/base_business_document_import/models/business_document_import.py", line 134, in _match_partner if netloc and netloc.split('.') >= 2: TypeError: unorderable types: list() >= int()

astirpe · 2018-02-01T09:50:19Z

base_business_document_import/models/business_document_import.py

+        logger.info('Trying to find an embedded XML file inside PDF')
+        res = {}
+        try:
+            fd = StringIO(pdf_file)


I think you need BytesIO here. I get an error otherwise, could you also check?

@astirpe can you past error ? import test file are working ...

Sorry, I remember now...
There is a try that prevents you to see any error.
So just place your debugger breakpoint on that line and notice that it always fails: it always enters the except block, which simply says pass. That's why you don't see any error.

BytesIO seems fixing that behavior.

Ok thanks. it's done

astirpe · 2018-02-01T10:11:09Z

base_business_document_import/models/business_document_import.py

+            else:
+                msg = _('<b>Notes in imported document:</b>')
+            record.message_post(
+                '%s %s' % (msg, parsed_dict['note']))


Please check this pylint:

base_business_document_import/models/business_document_import.py:870: [C8107(translation-required), BusinessDocumentImport.post_create_or_update] String parameter on "message_post" requires translation. Use _(('%s %s') % ((msg, parsed_dict['note'])))

msg is already translated:

msg = _('Notes in imported document:') so, it's ok for me ?

this is a case for # pylint: ignore=$errorname I think

Yes, it's translated. Just making the pylint silent would be fine, as @hbrunn says. Is not a blocking issue anyway.

@hbrunn where i should add #pylint line ?

Line 870 should be:

record.message_post( # pylint: disable=translation-required

astirpe · 2018-02-17T09:58:46Z

oca_dependencies.txt

@@ -0,0 +1,3 @@
+base_vat_sanitized https://github.com/OCA/partner-contact.git
+account_tax_unece https://github.com/onesteinbv/community-data-files 11_mig_account_tax_unece
+product_uom_unece https://github.com/OCA/community-data-files


All the modules in the dependencies are merged. You can rewrite the oca_dependencies.txt using the definitive list of repositories.

Ok done, thanks @astirpe

astirpe

Thank you!
Only two minor comments, not blocking of course.
For me this module is ok to be merged.

astirpe · 2018-02-21T13:09:53Z

base_business_document_import/models/business_document_import.py

+            'name': 'Akretion France',
+            'ref': 'C1242',
+            'phone': '01.41.98.12.42',
+            'fax': '01.41.98.12.43',


The "Fax" field was removed, please remove this line as well.

astirpe · 2018-02-21T13:10:25Z

base_business_document_import/models/business_document_import.py

+            'phone': '01.41.98.12.42',
+            'fax': '01.41.98.12.43',
+            }
+        The keys 'phone' and 'fax' are used by the module


Please removed the 'fax' also here.

you re right !!! done !

njeudy · 2018-02-21T14:00:45Z

@moylop260 @hbrunn ready to merge this one ?

astirpe · 2018-04-12T08:44:29Z

FYI #54

Signed-off-by pedrobaeza

alexis-via and others added 30 commits January 27, 2018 22:30

Add module base_business_document_import and start to move some code …

f8f9303

…to it.

Add module base_ubl (common methods to generate and parse UBL files)

b3df3fb

Adapt module account_invoice_import_ubl to use the new base_ubl module Small fixes

Add matching of delivery partner

7084edc

Use country code and state code to match partners UBL: Add delivery terms and line item UBL XML block generation UBL: add parsing of delivery block

Add module base_phone_business_document_import

8a7798d

Add unitests in base_business_document_import Small code enhancements/simplifications

Add unitest on partner matching and update code of partner matching

e228813

Add a unittest on _match_uom

72df446

Code cleanup/minor changes

Add module base_business_document_import_stock

cb6050a

Rename key 'quantity' to 'qty' in all parsing dicts['lines'] Add common methods compare_lines() and post_create_or_update() Make sure price_unit is always untaxed in UBL XML files

Fix code + PEP8

7d7a894

[IMP] handle the case where the xml file is generated with mime type

8f998be

'text/xml'

Add support for extraction + matching on website

77c915f

PEP8 fix

8.0 Add support for partner bank matching on invoice update (OCA#6)

9f3acfd

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

8.0 Use try/except when importing external libs (OCA#8)

8d064ed

[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method

[MIG] Make modules uninstallable

822caad

OCA Transbot updated translations from Transifex

3234e36

[ADD] migration of account_invoice_import_invoice2data and dependencies

7e87c48

Fix wrong class name

30e8a91

[FIX] product.product#ean13 was renamed to barcode

3525430

[FIX] tests

935cdba

Prepare v10 branch

530943e

Rename __openerp__.py to __manifest__.py and set installable to False

Port base_business_document_import to v10

eacf309

Add match for accounts and journals

Add match on analytic accounts

1b1fefb

Improve match for journals and accounts

Port base_business_document_import* to v10

d1e7035

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

First working version of account_invoice_import

2f9587f

Note: it requires this fix on odoo 10: odoo/odoo#15649

Continue port of modules for v10.0, in particular sale_order_import_*…

0e48514

… module Fix spelling mistake and other remarks on README by Tarteo

Port account_invoice_import_factur-x and account_invoice_import_ubl t…

eb62676

…o v10.0 base_business_document_import: Add support for the creation of res.bank

Smarter account code matching + add unittests

df0c711

Add support for insertion of title in error messages

FIX xmlid in tests

463f43b

FIX crash when pivot format had a 'note' key (and no attachment)

b6c95e7

Add method to create SO in sale.order.import accessible via JSON-RPC

njeudy force-pushed the 11-mig-base_business_document_import branch 3 times, most recently from 9e7703f to 162d69d Compare January 29, 2018 11:53

njeudy mentioned this pull request Jan 29, 2018

[11.0][MIG] : mig account_invoice_import #41

Merged

5 tasks

njeudy changed the title ~~WIP: 11 mig base business document import~~ [MIG] 11.0: base_business_document_import Jan 29, 2018

astirpe requested changes Jan 31, 2018

View reviewed changes

njeudy force-pushed the 11-mig-base_business_document_import branch 2 times, most recently from 885a709 to fbeec83 Compare January 31, 2018 17:16

astirpe requested changes Feb 1, 2018

View reviewed changes

astirpe reviewed Feb 1, 2018

View reviewed changes

astirpe reviewed Feb 17, 2018

View reviewed changes

njeudy force-pushed the 11-mig-base_business_document_import branch 5 times, most recently from 53bd9e9 to 36eb65c Compare February 21, 2018 13:10

astirpe approved these changes Feb 21, 2018

View reviewed changes

Nicolas JEUDY and others added 2 commits February 21, 2018 14:25

[MIG] base_business_document_import migrate to 11.0

a0bc212

[DEP] external dependencies setup

0810ed0

njeudy force-pushed the 11-mig-base_business_document_import branch from 36eb65c to 0810ed0 Compare February 21, 2018 13:25

hbrunn approved these changes Feb 21, 2018

View reviewed changes

hbrunn merged commit 785fe57 into OCA:11.0 Feb 21, 2018

pedrobaeza mentioned this pull request Jun 22, 2018

Migration to version 11.0 #29

Closed

27 tasks

etobella pushed a commit that referenced this pull request Mar 31, 2022

Merge PR #42 into 13.0

33c44ff

Signed-off-by pedrobaeza

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] 11.0: base_business_document_import #42

[MIG] 11.0: base_business_document_import #42

njeudy commented Jan 28, 2018

njeudy commented Jan 28, 2018

moylop260 commented Jan 29, 2018

coveralls commented Jan 29, 2018

coveralls commented Jan 29, 2018 •

edited

Loading

astirpe Jan 31, 2018

astirpe Feb 1, 2018

njeudy Feb 1, 2018

astirpe Feb 1, 2018

njeudy Feb 21, 2018

astirpe Feb 1, 2018

njeudy Feb 1, 2018

hbrunn Feb 1, 2018

astirpe Feb 1, 2018

njeudy Feb 2, 2018

astirpe Feb 17, 2018

njeudy Feb 21, 2018

astirpe Feb 17, 2018

njeudy Feb 21, 2018

astirpe left a comment

astirpe Feb 21, 2018

astirpe Feb 21, 2018

njeudy Feb 21, 2018

njeudy commented Feb 21, 2018

astirpe commented Apr 12, 2018

[MIG] 11.0: base_business_document_import #42

[MIG] 11.0: base_business_document_import #42

Conversation

njeudy commented Jan 28, 2018

njeudy commented Jan 28, 2018

moylop260 commented Jan 29, 2018

coveralls commented Jan 29, 2018

coveralls commented Jan 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

astirpe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

njeudy commented Feb 21, 2018

astirpe commented Apr 12, 2018

coveralls commented Jan 29, 2018 •

edited

Loading