[11.0][MIG] : mig account_invoice_import #41

njeudy · 2018-01-28T13:46:57Z

PR needed:

base_vat_sanitized [11.0][MIG] base_vat_sanitized partner-contact#552
account_tax_unece [11.0][MIG] account_tax_unece community-data-files#34
product_uom_unece [11.0][MIG] product_uom_unece: port to V11 community-data-files#35
base_business_document_import [MIG] 11.0: base_business_document_import #42
onchange_helper https://github.com/OCA/server-tools.git

coveralls · 2018-01-29T13:37:40Z

Coverage remained the same at 41.483% when pulling 3c1afd4e57d034d1288cca189344edc0be412f8a on njeudy:11-mig-account_invoice_import into b13c8e9 on OCA:11.0.

coveralls · 2018-01-29T13:37:40Z

Coverage decreased (-9.3%) to 55.517% when pulling 957392f on njeudy:11-mig-account_invoice_import into 6994600 on OCA:11.0.

astirpe · 2018-01-30T15:22:15Z

account_invoice_import/views/partner.xml

+    <field name="model">res.partner</field>
+    <field name="inherit_id" ref="account.view_partner_property_form"/>
+    <field name="arch" type="xml">
+        <field name="currency_id" position="after">


Here I would prefer:

<xpath expr="//group[@name='acc_purchase']" position="inside">

astirpe · 2018-01-30T15:22:54Z

account_invoice_import/views/res_config_settings.xml

+    <field name="arch" type="xml">
+        <xpath expr="//h2[contains(text(),'Taxes')]" position="before">
+          <h2 attrs="{'invisible': [('has_chart_of_accounts','=',False)]}">Invoice Import</h2>
+                        <div class="row mt16 o_settings_container" attrs="{'invisible': [('has_chart_of_accounts','=',False)]}">


Could you indent a bit less?

astirpe · 2018-01-30T15:24:51Z

account_invoice_import/README.rst

@@ -0,0 +1,91 @@
+.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg


Could you use the latest template? The .png image is preferable.

account_invoice_import/models/account_invoice.py

account_invoice_import/models/account_invoice_import_config.py

astirpe · 2018-01-31T13:34:03Z

account_invoice_import/scripts/mass_invoice_import.py

+        f.seek(0)
+        invoice = f.read()
+        f.close()
+        inv_b64 = invoice.encode('base64')


Use base64.b64encode(invoice)

astirpe · 2018-01-31T13:35:34Z

account_invoice_import/wizard/account_invoice_import.py

+        self.ensure_one()
+        assert self.invoice_file, 'No invoice file'
+        logger.info('Starting to import invoice %s', self.invoice_filename)
+        file_data = self.invoice_file.decode('base64')


Use base64.b64decode(self.invoice_file)

astirpe · 2018-02-01T10:03:29Z

@njeudy you may want to approve this easy one OCA/community-data-files#34, to speed up the pending PRs that are required.

njeudy · 2018-02-21T16:05:53Z

@alexis-via @astirpe coverage decrease with this PR, can you help me to improve test coverage ?

Need I add real pdf invoice to import and try différent config on it ?

astirpe · 2018-04-09T10:39:04Z

account_invoice_import/models/account_invoice.py

+            new_res = []
+            for (inv_id, name) in res:
+                inv = self.browse(inv_id)
+                display_currency = inv.currency_id


Add line

pre = post = u''

to avoid this error:

Error: Odoo Server Error Traceback (most recent call last): File "/opt/odoo/odoo-11.0/odoo/http.py", line 647, in _handle_exception return super(JsonRequest, self)._handle_exception(exception) File "/opt/odoo/odoo-11.0/odoo/http.py", line 307, in _handle_exception raise pycompat.reraise(type(exception), exception, sys.exc_info()[2]) File "/opt/odoo/odoo-11.0/odoo/tools/pycompat.py", line 87, in reraise raise value File "/opt/odoo/odoo-11.0/odoo/http.py", line 689, in dispatch result = self._call_function(**self.params) File "/opt/odoo/odoo-11.0/odoo/http.py", line 339, in _call_function return checked_call(self.db, *args, **kwargs) File "/opt/odoo/odoo-11.0/odoo/service/model.py", line 97, in wrapper return f(dbname, *args, **kwargs) File "/opt/odoo/odoo-11.0/odoo/http.py", line 332, in checked_call result = self.endpoint(*a, **kw) File "/opt/odoo/odoo-11.0/odoo/http.py", line 933, in __call__ return self.method(*args, **kw) File "/opt/odoo/odoo-11.0/odoo/http.py", line 512, in response_wrap response = f(*args, **kw) File "/opt/odoo/odoo-server/addons/web/controllers/main.py", line 930, in call_kw return self._call_kw(model, method, args, kwargs) File "/opt/odoo/odoo-server/addons/web/controllers/main.py", line 922, in _call_kw return call_kw(request.env[model], method, args, kwargs) File "/opt/odoo/odoo-11.0/odoo/api.py", line 689, in call_kw return call_kw_multi(method, model, args, kwargs) File "/opt/odoo/odoo-11.0/odoo/api.py", line 680, in call_kw_multi result = method(recs, *args, **kwargs) File "/opt/odoo/custom/addons/account_invoice_import/models/account_invoice.py", line 26, in name_get inv.amount_untaxed, pre=pre, post=post) UnboundLocalError: local variable 'post' referenced before assignment

In Python 3 every string is unicode, so no need for the u

ok will do this. @astirpe any idea to improve coverage ?

Thanks!
I cannot check the coverage, as one test is failing...

I create a merge request for failing test because it is not on this module

here it is : #53

The line you added pre = post = '' is in the wrong place. It should be placed inside the for loop.

Thanks. Now the other line, the one outside the loop (pre = post = ''), can be removed.

I mean line 13

njeudy · 2018-04-11T14:07:02Z

@pedrobaeza is it possible in oca dependency to import other branch of same repo to have travis green ?

pedrobaeza · 2018-04-11T14:46:51Z

Uhm, I don't think so... Try to put on oca_dependencies.txt the name of the organization and the branch to see it if works. Any way, better to work on merging the other PR, so we don't need this hack.

njeudy · 2018-04-11T18:57:40Z

Ok will remove hack and work on merging PR thanks

astirpe · 2018-04-12T07:38:34Z

Scenario:

the vendor A has "Invoice Import Configuration" set to "Multi Line, Auto-selected Product"
create an new Vendor Bill and set vendor A; do not add any line yet, leave it empty; save the draft vendor bill
try to import the vendor bill lines by clicking on "Import Invoice File"

I get this Server Error - Warning:

The total amount is different from the untaxed amount, but no tax has been configured !

The error above is raised because the vendor bill does not contain any tax line yet, as it was created empty.
But I would expect that the tax line is automatically imported as well.

As a workaround, I did this:

create an new Vendor Bill and set vendor A; do not add any product line but add one tax line; save the draft vendor bill
try to import the vendor bill lines by clicking on "Import Invoice File"

The product line and the tax line are correctly imported.

My request is: is it possible to automatically import the tax lines without that workaround? The calculation of the tax line can be based on the just imported product lines and the fiscal position of the vendor (as usual).

njeudy · 2018-04-12T18:08:42Z

@astirpe i will check this .. can you reproduce this on V10 ? (V10 is the standard up to date branch for this module I think .. )

astirpe · 2018-04-13T07:00:27Z

@njeudy I guess is the same in V10, since this part of code is the same. In this case we could open a separate issue if you prefer.

astirpe · 2018-04-13T07:04:44Z

account_invoice_import/wizard/account_invoice_import.py

+                parsed_inv['amount_untaxed']
+            invoice.tax_line_ids[0].amount = tax_amount
+            cur_symbol = invoice.currency_id.symbol
+            invoice.message_post(


Could you make the message translatable, as it was done in V10? (the fix of PR #51 should be ported to V11)

One of the zugferd-specific code has been standardised in UNECE, so moved to the account_tax_unece module

Fix update invoice via import wizard

… better support out customer invoice import Fix test suite of account_invoice_import (Agrolait is only a customer in v10)

* Update to work with latest version of invoice2data * Add requirements.txt file

…not deduct VAT (OCA#64) * Move code to a new dedicated method * FIX update of existing draft invoice Improve error message of partner matching Move hook of partner matching to put it after VAT matching, which is the most reliable * Add support for importing an invoice with VAT in a company that cannot deduc VAT Display nice error when account is missing on product * Improve compliancy with Factur-X standard (using schematron)

… has visible discounts Code improvements in sale_order_import Add unit tests in sale_order_import Use display_name instead of name_get()[0][1]

Update other modules accordingly

Code update and cleanup

Update the account_invoice_download_weboob following the changes in account_invoice_download Add README.rst for the 2 modules

Add weboob module management Improve log handling (explicit error when wrong pwd) account_invoice_import: by default, set tax to default tax of account when invoice_line_method = 1line_no_product

Update text displayed in the invoice import wizard and make list of supported formats modular (like in bank statement import)

… in multi-company environnement Fix my previous commit on sequence field on invoice import config (caused a crash when creating a new record) Usability improvements on download config

…iness document is imported in the right company

astirpe · 2018-10-12T13:04:43Z

@pedrobaeza squashed, the commits are reduced from 115 to 83. Would you give it a check?

astirpe · 2018-10-17T12:50:21Z

@pedrobaeza I'm tempted to merge this one. Is it ok?

pedrobaeza · 2018-10-17T12:51:20Z

OK, we can reduce a bit more the history on 12.0. Thanks all for the efforts!

njeudy mentioned this pull request Jan 28, 2018

WIP: [MIG] migrate to V11 akretion/odoo-mooncard-connector#2

Closed

pedrobaeza added this to the 11.0 milestone Jan 29, 2018

pedrobaeza mentioned this pull request Jan 29, 2018

Migration to version 11.0 #29

Closed

27 tasks

njeudy force-pushed the 11-mig-account_invoice_import branch from 92d9533 to 3c1afd4 Compare January 29, 2018 13:30

njeudy force-pushed the 11-mig-account_invoice_import branch from 3c1afd4 to 1721baf Compare January 29, 2018 14:09

njeudy changed the title ~~WIP: 11 mig account invoice import~~ [MIG] 11.0: mig account_invoice_import Jan 29, 2018

astirpe requested changes Jan 31, 2018

View reviewed changes

njeudy force-pushed the 11-mig-account_invoice_import branch 2 times, most recently from 2e49e72 to 87a5dd7 Compare January 31, 2018 13:20

astirpe requested changes Jan 31, 2018

View reviewed changes

njeudy force-pushed the 11-mig-account_invoice_import branch 2 times, most recently from fe7ea04 to 9c87252 Compare January 31, 2018 14:00

astirpe mentioned this pull request Feb 14, 2018

[11.0][MIG] account_invoice_import_ubl #49

Merged

2 tasks

njeudy force-pushed the 11-mig-account_invoice_import branch 2 times, most recently from f0fa9ff to bad58b3 Compare February 21, 2018 14:26

astirpe requested changes Apr 9, 2018

View reviewed changes

njeudy force-pushed the 11-mig-account_invoice_import branch 2 times, most recently from e0dacbf to 94bf720 Compare April 11, 2018 12:44

astirpe reviewed Apr 13, 2018

View reviewed changes

njeudy force-pushed the 11-mig-account_invoice_import branch from 94bf720 to e20c44c Compare April 13, 2018 09:26

alexis-via and others added 25 commits October 12, 2018 15:00

Finalise the use of the FacturX lib

7bc77d2

One of the zugferd-specific code has been standardised in UNECE, so moved to the account_tax_unece module

account_invoice_import: workaround a framework bug

79a5ec4

Fix update invoice via import wizard

account_invoice_import: Add partner_type to _match_partner method for…

7f768f5

… better support out customer invoice import Fix test suite of account_invoice_import (Agrolait is only a customer in v10)

OCA Transbot updated translations from Transifex

6468875

[10.0] Update to work with latest version of invoice2data (OCA#51)

4d15143

* Update to work with latest version of invoice2data * Add requirements.txt file

OCA Transbot updated translations from Transifex

275e789

[UPD] Update account_invoice_import.pot

b9f7fa3

Fix import of sale order with price_source='pricelist' when pricelist…

af0e4e7

… has visible discounts Code improvements in sale_order_import Add unit tests in sale_order_import Use display_name instead of name_get()[0][1]

Partner <-> Invoice import config : switch M2O <-> O2M

277a6ef

Add migration script

8d2c209

Add support for multiple invoice import configs in invoice import wizard

0e1d561

Update other modules accordingly

Add O2M field from import config to download config

5afb1f0

Code update and cleanup

Finalize the development account_invoice_download

0768eeb

Update the account_invoice_download_weboob following the changes in account_invoice_download Add README.rst for the 2 modules

Add support for additional module-specific weboob config parameters

8f3c10a

Add weboob module management Improve log handling (explicit error when wrong pwd) account_invoice_import: by default, set tax to default tax of account when invoice_line_method = 1line_no_product

account_invoice_import: add a mail gateway

506d392

Update text displayed in the invoice import wizard and make list of supported formats modular (like in bank statement import)

Add ability to run cron invoice download from admin for all companies…

59f5904

… in multi-company environnement Fix my previous commit on sequence field on invoice import config (caused a crash when creating a new record) Usability improvements on download config

Add multi-company support in the invoice import mail gateway

81d49c9

Check the VAT number of the destination partner, to make sure the bus…

8171ce9

…iness document is imported in the right company

[UPD] Update account_invoice_import.pot

a63a137

[FIX] include some of the fixes proposed in OCA#64

1bb50d1

[11.0][MIG] account_invoice_import

e12cd08

[FIX] clean rebase from V10 that where wrong ...

212764a

[FIX] utf8 comment in python3

f5974a3

Fix base64 encode/decode + remove supplier_invoice_number + code review

957392f

astirpe force-pushed the 11-mig-account_invoice_import branch from d29c854 to 957392f Compare October 12, 2018 13:00

astirpe merged commit 1955b90 into OCA:11.0 Oct 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] : mig account_invoice_import #41

[11.0][MIG] : mig account_invoice_import #41

njeudy commented Jan 28, 2018 •

edited

Loading

coveralls commented Jan 29, 2018

coveralls commented Jan 29, 2018 •

edited

Loading

astirpe Jan 30, 2018

astirpe Jan 30, 2018

astirpe Jan 30, 2018

astirpe Jan 31, 2018

astirpe Jan 31, 2018

astirpe commented Feb 1, 2018

njeudy commented Feb 21, 2018

astirpe Apr 9, 2018

pedrobaeza Apr 9, 2018

njeudy Apr 10, 2018

njeudy Apr 10, 2018

astirpe Apr 10, 2018

njeudy Apr 11, 2018

astirpe Apr 12, 2018

njeudy Jun 1, 2018

astirpe Oct 2, 2018

astirpe Oct 2, 2018

njeudy commented Apr 11, 2018

pedrobaeza commented Apr 11, 2018

njeudy commented Apr 11, 2018

astirpe commented Apr 12, 2018

njeudy commented Apr 12, 2018

astirpe commented Apr 13, 2018

astirpe Apr 13, 2018

njeudy Jun 1, 2018

astirpe commented Oct 12, 2018

astirpe commented Oct 17, 2018

pedrobaeza commented Oct 17, 2018

		@@ -0,0 +1,91 @@
		.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg

[11.0][MIG] : mig account_invoice_import #41

[11.0][MIG] : mig account_invoice_import #41

Conversation

njeudy commented Jan 28, 2018 • edited Loading

coveralls commented Jan 29, 2018

coveralls commented Jan 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

astirpe commented Feb 1, 2018

njeudy commented Feb 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

njeudy commented Apr 11, 2018

pedrobaeza commented Apr 11, 2018

njeudy commented Apr 11, 2018

astirpe commented Apr 12, 2018

njeudy commented Apr 12, 2018

astirpe commented Apr 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

astirpe commented Oct 12, 2018

astirpe commented Oct 17, 2018

pedrobaeza commented Oct 17, 2018

njeudy commented Jan 28, 2018 •

edited

Loading

coveralls commented Jan 29, 2018 •

edited

Loading