Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] account_e-invoice_generate #44

Merged
merged 2 commits into from
Jul 5, 2018
Merged

[11.0][MIG] account_e-invoice_generate #44

merged 2 commits into from
Jul 5, 2018

Conversation

astirpe
Copy link
Member

@astirpe astirpe commented Feb 6, 2018

Porting of account_e-invoice_generate to V11.

@coveralls
Copy link

coveralls commented Feb 6, 2018

Coverage Status

Coverage increased (+0.6%) to 36.49% when pulling f644046 on onesteinbv:11_mig_account_e-invoice_generate into 5d31030 on OCA:11.0.

@astirpe astirpe mentioned this pull request Feb 9, 2018
3 tasks
@pedrobaeza pedrobaeza added this to the 11.0 milestone Jul 4, 2018
@pedrobaeza pedrobaeza requested a review from cubells July 4, 2018 23:22
@@ -0,0 +1,18 @@
# © 2018 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change © by Copyright

@@ -0,0 +1,12 @@
# © 2018 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change © by Copyright

@@ -0,0 +1,11 @@
# © 2018 Akretion - Alexis de Lattre <alexis.delattre@akretion.com>
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change © by Copyright

the two electronic invoice generation modules: *account_invoice_ubl*
and *account_invoice_factur-x*. These 2 modules are able to embed an
XML file in the PDF invoice, but for the moment only one XML file can
be embeded in the PDF. And it can be useful to have both modules installed,
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: embedded

the two electronic invoice generation modules: *account_invoice_ubl*
and *account_invoice_factur-x*. These 2 modules are able to embed an
XML file in the PDF invoice, but for the moment only one XML file can
be embeded in the PDF. And it can be useful to have both modules installed,
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: embedded

alexis-via and others added 2 commits July 5, 2018 11:58
@astirpe
Copy link
Member Author

astirpe commented Jul 5, 2018

@cubells done, thanks!

Copy link
Sponsor Member

@cubells cubells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
LGTM

Code review and test.

@pedrobaeza pedrobaeza merged commit 3bdf0df into OCA:11.0 Jul 5, 2018
@astirpe astirpe deleted the 11_mig_account_e-invoice_generate branch July 5, 2018 16:17
@emagdalenaC2i emagdalenaC2i mentioned this pull request Dec 28, 2018
27 tasks
thienvh332 pushed a commit to thienvh332/edi that referenced this pull request Dec 19, 2023
Signed-off-by simahawk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants