[11.0][MIG] account_invoice_ubl #46

astirpe · 2018-02-09T13:40:23Z

Depends on:

base_ubl: [11.0][MIG] base_ubl: port to V11 #43
base_ubl_payment: [11.0][MIG] base_ubl_payment #45
account_e-invoice_generate: [11.0][MIG] account_e-invoice_generate #44

pedrobaeza · 2018-07-05T15:53:59Z

Please rebase removing last WIP commit.

cubells · 2018-07-05T16:22:08Z

account_invoice_ubl/README.rst

+Account Invoice UBL
+===================
+
+This module adds support for UBL, the `Universal Business Language (UBL) <http://ubl.xml.org/>`_ standard, on invoices. The UBL 2.1 standard became the `ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_ standard in December 2015 (cf the `official announce <http://www.prweb.com/releases/2016/01/prweb13186919.htm>_`).


Too large. Change to

This module adds support for UBL, the `Universal Business Language (UBL) <http://ubl.xml.org/>`_ standard, on invoices. The UBL 2.1 standard became the `ISO/IEC 19845 <http://www.iso.org/iso/catalogue_detail.htm?csnumber=66370>`_ standard in December 2015 (cf the `official announce <http://www.prweb.com/releases/2016/01/prweb13186919.htm>`_).

symbol _ after `

cubells · 2018-07-05T16:23:04Z

account_invoice_ubl/README.rst

+Configuration
+=============
+
+In the menu *Invoicing > Configuration > Settings > Invoicing*, under *Electronic Invoices*, check the value of 2 options:


Too large. Change to

In the menu *Invoicing > Configuration > Settings > Invoicing*, under *Electronic Invoices*, check the value of 2 options:

cubells · 2018-07-05T16:24:19Z

account_invoice_ubl/README.rst

+
+In the menu *Invoicing > Configuration > Settings > Invoicing*, under *Electronic Invoices*, check the value of 2 options:
+
+* *XML Format embedded in PDF invoice* : if you want to have an UBL XML file embedded inside the PDF invoice, set it to *Universal Business Language (UBL)*


Too large. Change to

* *XML Format embedded in PDF invoice* : if you want to have an UBL XML file embedded inside the PDF invoice, set it to *Universal Business Language (UBL)*

cubells · 2018-07-05T16:24:39Z

account_invoice_ubl/README.rst

+In the menu *Invoicing > Configuration > Settings > Invoicing*, under *Electronic Invoices*, check the value of 2 options:
+
+* *XML Format embedded in PDF invoice* : if you want to have an UBL XML file embedded inside the PDF invoice, set it to *Universal Business Language (UBL)*
+* if you work directly with XML invoices and you want to have the PDF invoice in base64 inside the XML file, enable the *Embed PDF in UBL XML Invoice*.


Too large. Change to:

* if you work directly with XML invoices and you want to have the PDF invoice in base64 inside the XML file, enable the *Embed PDF in UBL XML Invoice*.

cubells · 2018-07-05T16:25:20Z

account_invoice_ubl/__manifest__.py

@@ -0,0 +1,23 @@
+# © 2016-2018 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)


Change symbol © to Copyright

cubells · 2018-07-05T16:26:51Z

account_invoice_ubl/views/res_config_settings.xml

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+  © 2017 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)


Change symbol © to Copyright

cubells · 2018-07-05T16:28:10Z

oca_dependencies.txt

@@ -1,2 +1,6 @@
 partner-contact
 community-data-files
+edi https://github.com/onesteinbv/edi 11_mig_base_ubl


All these lines are not necessary if you rebase your pr.

cubells · 2018-07-05T16:34:14Z

account_invoice_ubl/models/account_invoice.py

+            order_ref_id.text = self.name
+
+    @api.multi
+    def _ubl_get_contract_document_reference_dict(self):


I don't understand why this method. One record is ensured in parent method, and this do nothing.

I don't understand either 🤔

@cubells is it ok for you to leave this method as it is and move forward?

cubells · 2018-07-05T16:36:11Z

account_invoice_ubl/models/account_invoice.py

+                    ns, version=version)
+
+    @api.multi
+    def get_delivery_partner(self):


This method either. This is not used anymore in module. And if is an inheritance, class method is name def get_delivery_partner_id() in AccountInvoice class.

I will cherry pick commit 4ac8b4a that removes this method and the other useless code

cubells · 2018-07-05T16:36:57Z

account_invoice_ubl/models/account_invoice.py

+        self._ubl_add_customer_party(
+            self.partner_id, False, 'AccountingCustomerParty', xml_root, ns,
+            version=version)
+        # delivery_partner = self.get_delivery_partner()


These commented lines are correct?

cubells

Check tests. Fail in local database.

Print numbers with the approriate number of digits in the XML

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

Rename __openerp__.py to __manifest__.py and set installable to False

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Rename account_invoice_import_zugferd to account_invoice_import_factur-x Add module to support py3o reporting engine:

Add active buttons on invoice import config

… module Fix spelling mistake and other remarks on README by Tarteo

Add ubl invoice generation option in accounting config page

…xist in v10) in account_invoice_factur-x and account_invoice_ubl

Add script mass_invoice_import.py Code cleanup

* sale_order_ubl + purchase_order_ubl: restore get_pdf() in tests using HttpCase * Restore get_pdf() in tests of account_invoice_factur-x and account_invoice_ubl modules * Update oca_dependencies.txt

… embedding in PDF between account_invoice_factur-x and account_invoice_ubl

astirpe · 2018-07-06T04:48:52Z

Tests are failing because of these two lines in Odoo V11.

When running tests, if the test_report_directory is not set in the configuration, the method render_qweb_pdf() will not return a PDF; instead it returns the HTML by invoking render_qweb_html().

I tried locally: commenting out the two lines above will make the tests passing.

Is there a way to set test_report_directory for this repo, in order to make tests passing?

Enable delivery block in UBL

coveralls · 2018-07-06T13:21:00Z

Coverage increased (+28.7%) to 64.789% when pulling a07ca34 on onesteinbv:11_mig_account_invoice_ubl into 85144d0 on OCA:11.0.

astirpe · 2018-07-06T13:36:28Z

For this branch I'm passing the option --test-report-directory=/tmp to Odoo, in order to make tests running properly.
See a07ca34

astirpe · 2018-08-02T08:41:26Z

Thanks!

astirpe mentioned this pull request Feb 9, 2018

Migration to version 11.0 #29

Closed

27 tasks

pedrobaeza added this to the 11.0 milestone Feb 9, 2018

pedrobaeza requested a review from cubells July 5, 2018 15:54

cubells suggested changes Jul 5, 2018

View reviewed changes

cubells reviewed Jul 5, 2018

View reviewed changes

alexis-via and others added 19 commits July 5, 2018 19:07

Add modules account_invoice_ubl + base_ubl_payment

a97c570

Add partner identification hook in UBL XML party block generation

0cc53fe

Print numbers with the approriate number of digits in the XML

Add support for UBL 2.0 (required for e-fff)

b9a3651

Update README

eb68953

Handle lang in UBL XML file generation

809a770

8.0 Add support for partner bank matching on invoice update (#6)

18179a6

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

OCA Transbot updated translations from Transifex

69e45b7

Prepare v10 branch

b0d638e

Rename __openerp__.py to __manifest__.py and set installable to False

Port base_business_document_import* to v10

a75d72a

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Rename account_invoice_zugferd to account_invoice_factur-x

407bb3a

Rename account_invoice_import_zugferd to account_invoice_import_factur-x Add module to support py3o reporting engine:

FIX crash on self._model

60b0b17

Add active buttons on invoice import config

Continue port of modules for v10.0, in particular sale_order_import_*…

91cf8d2

… module Fix spelling mistake and other remarks on README by Tarteo

Port purchase_order_import* to v10.0

008e668

Add ubl invoice generation option in accounting config page

Stop using precision_get('Account') (this decimal precision doesn't e…

7691e9a

…xist in v10) in account_invoice_factur-x and account_invoice_ubl

Update test suite

2df3f4d

Improve + modularize generation of UBL (up-port from v8 PR)

2e61b93

Add script mass_invoice_import.py Code cleanup

Disable get_pdf() in all tests because it doesn't work in Travis

6f5fdcc

[10.0] restore get_pdf() in tests (#31)

da77df4

* sale_order_ubl + purchase_order_ubl: restore get_pdf() in tests using HttpCase * Restore get_pdf() in tests of account_invoice_factur-x and account_invoice_ubl modules * Update oca_dependencies.txt

Add module account_e-invoice_generate to ensure compatibility for XML…

fc77d68

… embedding in PDF between account_invoice_factur-x and account_invoice_ubl

astirpe and others added 4 commits July 6, 2018 08:51

[11.0][MIG] account_invoice_ubl

ad0e852

OCA Transbot updated translations from Transifex

57f2c89

Add support for PaymentID in UBL

6141eeb

Enable delivery block in UBL

FIX is partner_shipping_id is empty

006aff8

astirpe mentioned this pull request Jul 6, 2018

[11.0][MIG] purchase_order_ubl #48

Merged

1 task

Add option to .travis.yml (for tests)

a07ca34

pedrobaeza approved these changes Aug 2, 2018

View reviewed changes

pedrobaeza merged commit 25b27c6 into OCA:11.0 Aug 2, 2018

astirpe deleted the 11_mig_account_invoice_ubl branch August 2, 2018 08:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] account_invoice_ubl #46

[11.0][MIG] account_invoice_ubl #46

astirpe commented Feb 9, 2018 •

edited by pedrobaeza

Loading

pedrobaeza commented Jul 5, 2018

cubells Jul 5, 2018

cubells Jul 5, 2018

cubells Jul 5, 2018

cubells Jul 5, 2018

cubells Jul 5, 2018

cubells Jul 5, 2018

cubells Jul 5, 2018

cubells Jul 5, 2018

cubells Jul 5, 2018

astirpe Jul 5, 2018

astirpe Jul 11, 2018

cubells Jul 5, 2018

astirpe Jul 5, 2018

cubells Jul 5, 2018

cubells left a comment

astirpe commented Jul 6, 2018

coveralls commented Jul 6, 2018 •

edited

Loading

astirpe commented Jul 6, 2018

astirpe commented Aug 2, 2018


		In the menu Invoicing > Configuration > Settings > Invoicing, under Electronic Invoices, check the value of 2 options:

		* XML Format embedded in PDF invoice : if you want to have an UBL XML file embedded inside the PDF invoice, set it to Universal Business Language (UBL)

		@@ -0,0 +1,23 @@
		# © 2016-2018 Akretion (Alexis de Lattre <alexis.delattre@akretion.com>)

[11.0][MIG] account_invoice_ubl #46

[11.0][MIG] account_invoice_ubl #46

Conversation

astirpe commented Feb 9, 2018 • edited by pedrobaeza Loading

pedrobaeza commented Jul 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cubells left a comment

Choose a reason for hiding this comment

astirpe commented Jul 6, 2018

coveralls commented Jul 6, 2018 • edited Loading

astirpe commented Jul 6, 2018

astirpe commented Aug 2, 2018

astirpe commented Feb 9, 2018 •

edited by pedrobaeza

Loading

coveralls commented Jul 6, 2018 •

edited

Loading