[12.0] Migrate base_business_document_import* #85

alexis-via · 2019-02-20T23:18:29Z

Migrate base_business_document_import from v11 to v12
Migrate base_business_document_import_phone from v10 to v12
Convert README to new format

oca-clabot · 2019-02-20T23:18:31Z

Hey @alexis-via, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Nicolas JEUDY nicolas@panda-chi.io (no github login found)

Appreciation of efforts,
OCA CLAbot

base_business_document_import/models/business_document_import.py

astirpe · 2019-02-21T08:05:59Z

base_business_document_import/tests/test_business_document_import.py

+            'country_id': self.env.ref('base.fr').id,
+            'type': 'invoice',
+        })
+        agrolait = self.env.ref('base.res_partner_2')


I would prefer to have variable agrolait renamed (eg.: res_partner_2).

gurneyalex · 2019-03-04T09:12:05Z

CI is red because of unavailable dependency on base_vat_sanitized

gurneyalex · 2019-03-04T09:17:31Z

I added back the oca_dependencies.txt file. @alexis-via rebasing your PR should get a greener build.

…to it.

…voice dict, cleaner organisation) Code refactoring: move code in base_business_document_import, factorise code for tax matching (it was duplicated in UBL and ZUGFeRD) Now support PDF with embedded UBL XML file Enable unittests on account_invoice_import_ubl More absolute xpath in account_invoice_import_ubl instead of relative xpath WARNING: these are big changes, I may have broken a few details

Adapt module account_invoice_import_ubl to use the new base_ubl module Small fixes

Better generation of address block in UBL (make it coherent with the datamodel of Odoo) Add generation of several UBL blocks: language, delivery, payment terms, customer party, spplier party Add parsing of zip in UBL party (will be used in the future for delivery partner match)

Use country code and state code to match partners UBL: Add delivery terms and line item UBL XML block generation UBL: add parsing of delivery block

Add unitests in base_business_document_import Small code enhancements/simplifications

Code cleanup/minor changes

Rename key 'quantity' to 'qty' in all parsing dicts['lines'] Add common methods compare_lines() and post_create_or_update() Make sure price_unit is always untaxed in UBL XML files

…xml'

PEP8 fix

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method

Rename __openerp__.py to __manifest__.py and set installable to False

Add match for accounts and journals

Improve match for journals and accounts

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

…import_phone for consistency Add connector-telephony in oca_dependencies.txt

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method

Rename __openerp__.py to __manifest__.py and set installable to False

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

When using auto invoice download, the cron is executed by default by admin user, which is above record rules: only handle download config in the company of the user and improve matching by always selecting obj in the same company (or company = False)

… in multi-company environnement Fix my previous commit on sequence field on invoice import config (caused a crash when creating a new record) Usability improvements on download config

Migrate base_business_document_import_phone from v10 to v12 Convert readme to the new format

alexis-via · 2019-03-04T13:13:00Z

Thanks Alexandre. I made a rebased, let's see what Travis will say now...

astirpe

@alexis-via
Please accept the proposed changes. One test of #101 is failing and the proposed changes fix the error.

base_business_document_import/models/business_document_import.py

luistorresm · 2019-05-05T19:00:29Z

base_business_document_import/models/business_document_import.py

+        The key 'phone' is used by the module
+        base_phone_business_document_import
+        """
+        rpo = self.env['res.partner']


Suggested change

rpo = self.env['res.partner']

partner = self.env['res.partner']

For me a partner is an instance of the model 'res.partner' not the class represented by self.env['res.partner']
rpo is better because it's a shorcut. Just my opinion

luistorresm · 2019-05-05T19:02:47Z

base_business_document_import/models/business_document_import.py

+        country = False
+        if partner_dict.get('country_code'):
+            countries = self.env['res.country'].search([
+                ('code', '=', partner_dict['country_code'])])


Why not limit=1, if you only needs one record

luistorresm · 2019-05-05T19:04:10Z

base_business_document_import/models/business_document_import.py

+        if country and partner_dict.get('state_code'):
+            states = self.env['res.country.state'].search([
+                ('code', '=', partner_dict['state_code']),
+                ('country_id', '=', country.id)])


luistorresm · 2019-05-05T19:05:14Z

base_business_document_import/models/business_document_import.py

+            partners = rpo.search(
+                domain + [
+                    ('parent_id', '=', False),
+                    ('sanitized_vat', '=', vat)])


luistorresm · 2019-05-05T19:05:47Z

base_business_document_import/models/business_document_import.py

+                    ('sanitized_vat', '=', vat)])
+            if partners:
+                return partners[0]
+            else:


The else sentence is not necessary here, because the if return if its True

luistorresm · 2019-05-05T19:07:19Z

base_business_document_import/models/business_document_import.py

+                domain + [('email', '=ilike', partner_dict['email'])])
+            if partners:
+                return partners[0]
+            else:


The same here

luistorresm · 2019-05-05T19:07:53Z

base_business_document_import/models/business_document_import.py

+            if not partners and website_domain:
+                partners = rpo.search(
+                    domain +
+                    [('email', '=ilike', '%@' + website_domain)])


luistorresm · 2019-05-05T19:08:05Z

base_business_document_import/models/business_document_import.py

+                return partners[0]
+        if partner_dict.get('ref'):
+            partners = rpo.search(
+                domain + [('ref', '=', partner_dict['ref'])])


luistorresm · 2019-05-05T19:08:13Z

base_business_document_import/models/business_document_import.py

+                return partners[0]
+        if partner_dict.get('name'):
+            partners = rpo.search(
+                domain + [('name', '=ilike', partner_dict['name'])])


luistorresm · 2019-05-05T19:08:38Z

base_business_document_import/models/business_document_import.py

+        The partner argument is a bit special: it is a fallback in case
+        shipping_dict['partner'] = {}
+        """
+        rpo = self.env['res.partner']


Suggested change

rpo = self.env['res.partner']

partner = self.env['res.partner']

pedrobaeza · 2019-06-02T21:50:54Z

@alexis-via are you going to finish this?

alexis-via · 2019-06-04T09:57:00Z

@pedrobaeza yes, sure. Now that intrastat is finished for v12, I can come back to edi. Travis is green. I'll have a look at the last remarks in the coming days.

pedrobaeza · 2019-06-04T10:02:31Z

Thanks

Improve code for shipping addresse matching Improve tests

pedrobaeza · 2019-07-04T07:59:57Z

Travis is red

astirpe · 2019-07-31T07:22:56Z

Travis errors fixed with a2671fa, this branch should be rebased.

pedrobaeza added this to the 12.0 milestone Feb 20, 2019

OCA-git-bot mentioned this pull request Feb 20, 2019

Migration to version 12.0 #69

Closed

18 tasks

astirpe requested changes Feb 21, 2019

View reviewed changes

alexis-via and others added 24 commits March 4, 2019 14:12

Add module base_business_document_import and start to move some code …

afe5bbc

…to it.

Add module base_ubl (common methods to generate and parse UBL files)

6450c60

Adapt module account_invoice_import_ubl to use the new base_ubl module Small fixes

Add matching of delivery partner

cb08e5d

Use country code and state code to match partners UBL: Add delivery terms and line item UBL XML block generation UBL: add parsing of delivery block

Add module base_phone_business_document_import

379552f

Add unitests in base_business_document_import Small code enhancements/simplifications

Add unitest on partner matching and update code of partner matching

9975169

Add a unittest on _match_uom

24e2aaf

Code cleanup/minor changes

Add module base_business_document_import_stock

0aa5d95

Rename key 'quantity' to 'qty' in all parsing dicts['lines'] Add common methods compare_lines() and post_create_or_update() Make sure price_unit is always untaxed in UBL XML files

Fix code + PEP8

e65af9c

handle the case where the xml file is generated with mime type 'text/…

dfe888e

…xml'

Add support for extraction + matching on website

dbdb23b

PEP8 fix

8.0 Add support for partner bank matching on invoice update (#6)

ff36ff5

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

8.0 Use try/except when importing external libs (#8)

e1101a2

[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method

Make modules uninstallable

0a1e3fc

OCA Transbot updated translations from Transifex

fc66fa0

migration of account_invoice_import_invoice2data and dependencies

8329a9d

Fix wrong class name

621f01c

product.product#ean13 was renamed to barcode

c7a148a

tests

efc43e6

Prepare v10 branch

9f3f33f

Rename __openerp__.py to __manifest__.py and set installable to False

Port base_business_document_import to v10

bf356c5

Add match for accounts and journals

Add match on analytic accounts

53e8241

Improve match for journals and accounts

Port base_business_document_import* to v10

682c629

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

oca-transbot and others added 13 commits March 4, 2019 14:12

Update translation files

17560f3

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Rename base_phone_business_document_import to base_business_document_…

49d0b7d

…import_phone for consistency Add connector-telephony in oca_dependencies.txt

import phonenumbers in try/except

7c4f8e4

Add and update README.rst

dc6969e

8.0 Add support for partner bank matching on invoice update (#6)

3290473

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

8.0 Use try/except when importing external libs (#8)

e1df04e

[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method

Prepare v10 branch

5f4c4ac

Rename __openerp__.py to __manifest__.py and set installable to False

Port base_business_document_import* to v10

59381f6

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Update base_business_document_import_phone.pot

a30f397

Add ability to run cron invoice download from admin for all companies…

722eea0

… in multi-company environnement Fix my previous commit on sequence field on invoice import config (caused a crash when creating a new record) Usability improvements on download config

[MIG] base_business_document_import from 11 to 12

8463a22

Migrate base_business_document_import_phone from v10 to v12 Convert readme to the new format

Module product_uom_unece renamed to uom_unece

d8ae007

alexis-via force-pushed the 12-mig-business_doc_import branch from 1c1f4c3 to d8ae007 Compare March 4, 2019 13:12

rubdos mentioned this pull request Mar 9, 2019

[12.0] mig account_invoice_import #93

Closed

1 task

astirpe mentioned this pull request Apr 3, 2019

[12.0][MIG] sale_order_import #101

Merged

2 tasks

astirpe requested changes Apr 4, 2019

View reviewed changes

base_business_document_import/models/business_document_import.py Show resolved Hide resolved

alexis-via commented Apr 4, 2019

View reviewed changes

base_business_document_import/models/business_document_import.py Show resolved Hide resolved

luistorresm reviewed May 5, 2019

View reviewed changes

emagdalenaC2i mentioned this pull request Jun 1, 2019

[MIG] 12.0-mig-base-business-document-import #110

Closed

Add connector-telephony in oca_dependencies.txt

932f900

Use limit=1 where relevant

2e7c752

Improve code for shipping addresse matching Improve tests

astirpe approved these changes Jul 4, 2019

View reviewed changes

alexis-via merged commit ba8dcb3 into OCA:12.0 Dec 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0] Migrate base_business_document_import* #85

[12.0] Migrate base_business_document_import* #85

alexis-via commented Feb 20, 2019

oca-clabot commented Feb 20, 2019

astirpe Feb 21, 2019

gurneyalex commented Mar 4, 2019

gurneyalex commented Mar 4, 2019

alexis-via commented Mar 4, 2019

astirpe left a comment

luistorresm May 5, 2019

bealdav Nov 15, 2019

luistorresm May 5, 2019

luistorresm May 5, 2019

luistorresm May 5, 2019

luistorresm May 5, 2019

luistorresm May 5, 2019

luistorresm May 5, 2019

luistorresm May 5, 2019

luistorresm May 5, 2019

luistorresm May 5, 2019

pedrobaeza commented Jun 2, 2019

alexis-via commented Jun 4, 2019

pedrobaeza commented Jun 4, 2019

pedrobaeza commented Jul 4, 2019

astirpe commented Jul 31, 2019

	rpo = self.env['res.partner']
	partner = self.env['res.partner']

[12.0] Migrate base_business_document_import* #85

[12.0] Migrate base_business_document_import* #85

Conversation

alexis-via commented Feb 20, 2019

oca-clabot commented Feb 20, 2019

Choose a reason for hiding this comment

gurneyalex commented Mar 4, 2019

gurneyalex commented Mar 4, 2019

alexis-via commented Mar 4, 2019

astirpe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Jun 2, 2019

alexis-via commented Jun 4, 2019

pedrobaeza commented Jun 4, 2019

pedrobaeza commented Jul 4, 2019

astirpe commented Jul 31, 2019