[12.0] mig account_invoice_import #93

rubdos · 2019-03-09T21:46:26Z

Depends on:

[12.0] Migrate base_business_document_import* #85 -- I will rebase on that PR (or on 12.0 when it'd be merged)

Currently this is the initial git format-patch --keep-subject --stdout origin/12.0..origin/11.0 -- $MODULE | git am -3 --keep.

…to it.

…voice dict, cleaner organisation) Code refactoring: move code in base_business_document_import, factorise code for tax matching (it was duplicated in UBL and ZUGFeRD) Now support PDF with embedded UBL XML file Enable unittests on account_invoice_import_ubl More absolute xpath in account_invoice_import_ubl instead of relative xpath WARNING: these are big changes, I may have broken a few details

Adapt module account_invoice_import_ubl to use the new base_ubl module Small fixes

Better generation of address block in UBL (make it coherent with the datamodel of Odoo) Add generation of several UBL blocks: language, delivery, payment terms, customer party, spplier party Add parsing of zip in UBL party (will be used in the future for delivery partner match)

Use country code and state code to match partners UBL: Add delivery terms and line item UBL XML block generation UBL: add parsing of delivery block

Add unitests in base_business_document_import Small code enhancements/simplifications

Code cleanup/minor changes

Rename key 'quantity' to 'qty' in all parsing dicts['lines'] Add common methods compare_lines() and post_create_or_update() Make sure price_unit is always untaxed in UBL XML files

…xml'

PEP8 fix

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method

Rename __openerp__.py to __manifest__.py and set installable to False

Add match for accounts and journals

Improve match for journals and accounts

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

Note: it requires this fix on odoo 10: odoo/odoo#15649

… module Fix spelling mistake and other remarks on README by Tarteo

…o v10.0 base_business_document_import: Add support for the creation of res.bank

Add support for insertion of title in error messages

Add method to create SO in sale.order.import accessible via JSON-RPC

Update other modules accordingly

Code update and cleanup

Update the account_invoice_download_weboob following the changes in account_invoice_download Add README.rst for the 2 modules

Add weboob module management Improve log handling (explicit error when wrong pwd) account_invoice_import: by default, set tax to default tax of account when invoice_line_method = 1line_no_product

Update text displayed in the invoice import wizard and make list of supported formats modular (like in bank statement import)

… in multi-company environnement Fix my previous commit on sequence field on invoice import config (caused a crash when creating a new record) Usability improvements on download config

…iness document is imported in the right company

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

oca-clabot · 2019-03-09T21:46:29Z

Hey @rubdos, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

@rubdos (login unknown in OCA database)
Nicolas JEUDY nicolas@panda-chi.io (no github login found)

Appreciation of efforts,
OCA CLAbot

astirpe · 2019-03-14T08:40:24Z

account_invoice_import/__manifest__.py

+        'onchange_helper',
+        # add bank_payment dependency to have commercial_partner_id on invoice
+        # PR in odoo will be create soon
+        'account_payment_partner',


I think this dependency is not needed anymore. Could you check?

astirpe · 2019-03-14T08:41:01Z

account_invoice_import/__manifest__.py

+    'license': 'AGPL-3',
+    'summary': 'Import supplier invoices/refunds as PDF or XML files',
+    'author': 'Akretion,Odoo Community Association (OCA)',
+    'website': 'http://www.akretion.com',


Suggested change

'website': 'http://www.akretion.com',

'website': 'https://github.com/OCA/edi',

astirpe · 2019-03-14T08:42:33Z

account_invoice_import/wizard/account_invoice_import.py

+        # 'lines': [{
+        #       'product': {
+        #           'barcode': '4123456000021',
+        #           'code': 'GZ250',


Suggested change

# 'code': 'GZ250',

# 'default_code': 'GZ250',

astirpe · 2019-03-14T08:43:26Z

account_invoice_import/wizard/account_invoice_import.py

+            assert self.import_config_id
+            import_config = self.import_config_id.convert_to_import_config()
+        invoice = self.create_invoice(parsed_inv, import_config)
+        invoice.message_post(_(


Suggested change

invoice.message_post(_(

invoice.message_post(body=_(

Otherwise I get an error.

astirpe · 2019-03-14T08:43:59Z

account_invoice_import/wizard/account_invoice_import.py

+                parsed_inv['amount_untaxed']
+            invoice.tax_line_ids[0].amount = tax_amount
+            cur_symbol = invoice.currency_id.symbol
+            invoice.message_post(_(


Suggested change

invoice.message_post(_(

invoice.message_post(body=_(

astirpe · 2019-03-14T08:47:47Z

account_invoice_import/views/res_config_settings.xml

+    <field name="model">res.config.settings</field>
+    <field name="inherit_id" ref="account.res_config_settings_view_form"/>
+    <field name="arch" type="xml">
+      <xpath expr="//div[@data-key='account_invoicing']" position="inside">


Suggested change

<xpath expr="//div[@data-key='account_invoicing']" position="inside">

<xpath expr="//div[@data-key='account']" position="inside">

astirpe · 2019-03-14T08:48:18Z

account_invoice_import/tests/test_invoice_import.py

+            'date_start': '2017-08-01',
+            'date_end': '2017-08-31',
+            'partner': {
+                'name': 'ASUSTeK',


Suggested change

'name': 'ASUSTeK',

'name': 'Wood Corner',

astirpe · 2019-03-14T08:48:34Z

account_invoice_import/tests/test_invoice_import.py

+            },
+            'description': 'New hi-tech gadget',
+            'lines': [{
+                'product': {'code': 'AII-TEST-PRODUCT'},


Suggested change

'product': {'code': 'AII-TEST-PRODUCT'},

'product': {'default_code': 'AII-TEST-PRODUCT'},

astirpe · 2019-03-14T08:48:51Z

account_invoice_import/tests/test_invoice_import.py

+            'type': 'out_invoice',
+            'date_invoice': '2017-08-16',
+            'partner': {
+                'name': 'Agrolait',


Suggested change

'name': 'Agrolait',

'name': 'Deco Addict',

astirpe · 2019-03-14T08:49:07Z

account_invoice_import/tests/test_invoice_import.py

+                'name': 'Agrolait',
+            },
+            'lines': [{
+                'product': {'code': 'AII-TEST-PRODUCT'},


Suggested change

'product': {'code': 'AII-TEST-PRODUCT'},

'product': {'default_code': 'AII-TEST-PRODUCT'},

TheCloneMaster · 2019-05-08T02:38:07Z

Hi, is this PR still alive?
How could we help?

astirpe · 2019-05-08T06:39:12Z

@TheCloneMaster this PR depends on #85 that is not yet merged. You may want to review that one first.
@rubdos could you accept the changes I proposed?

mgielissen · 2019-12-31T18:57:39Z

#85 is merged into 12.0

njeudy · 2020-01-02T17:50:12Z

how can we help on it ?

astirpe · 2020-01-03T09:34:06Z

Superseded by #162 due to inactivity

alexis-via and others added 30 commits March 4, 2019 14:12

Add module base_business_document_import and start to move some code …

afe5bbc

…to it.

Add module base_ubl (common methods to generate and parse UBL files)

6450c60

Adapt module account_invoice_import_ubl to use the new base_ubl module Small fixes

Add matching of delivery partner

cb08e5d

Use country code and state code to match partners UBL: Add delivery terms and line item UBL XML block generation UBL: add parsing of delivery block

Add module base_phone_business_document_import

379552f

Add unitests in base_business_document_import Small code enhancements/simplifications

Add unitest on partner matching and update code of partner matching

9975169

Add a unittest on _match_uom

24e2aaf

Code cleanup/minor changes

Add module base_business_document_import_stock

0aa5d95

Rename key 'quantity' to 'qty' in all parsing dicts['lines'] Add common methods compare_lines() and post_create_or_update() Make sure price_unit is always untaxed in UBL XML files

Fix code + PEP8

e65af9c

handle the case where the xml file is generated with mime type 'text/…

dfe888e

…xml'

Add support for extraction + matching on website

dbdb23b

PEP8 fix

8.0 Add support for partner bank matching on invoice update (OCA#6)

ff36ff5

Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)

8.0 Use try/except when importing external libs (OCA#8)

e1101a2

[FIX] LINT Use try/except when importing external libs Remove self.ensure_one() that has nothing to do in an api.model method

Make modules uninstallable

0a1e3fc

OCA Transbot updated translations from Transifex

fc66fa0

migration of account_invoice_import_invoice2data and dependencies

8329a9d

Fix wrong class name

621f01c

product.product#ean13 was renamed to barcode

c7a148a

tests

efc43e6

Prepare v10 branch

9f3f33f

Rename __openerp__.py to __manifest__.py and set installable to False

Port base_business_document_import to v10

bf356c5

Add match for accounts and journals

Add match on analytic accounts

53e8241

Improve match for journals and accounts

Port base_business_document_import* to v10

682c629

Also port all the modules that generate the XML documents: account_invoice_ubl, account_invoice_zugferd, purchase_order_ubl and sale_order_ubl

First working version of account_invoice_import

b834fc0

Note: it requires this fix on odoo 10: odoo/odoo#15649

Continue port of modules for v10.0, in particular sale_order_import_*…

82e29f3

… module Fix spelling mistake and other remarks on README by Tarteo

Port account_invoice_import_factur-x and account_invoice_import_ubl t…

4b05b90

…o v10.0 base_business_document_import: Add support for the creation of res.bank

Smarter account code matching + add unittests

0333061

Add support for insertion of title in error messages

FIX xmlid in tests

5bed8ff

FIX crash when pivot format had a 'note' key (and no attachment)

7636ef6

Add method to create SO in sale.order.import accessible via JSON-RPC

alexis-via and others added 16 commits March 9, 2019 22:41

Add support for multiple invoice import configs in invoice import wizard

fb8ca0d

Update other modules accordingly

Add O2M field from import config to download config

1c5570c

Code update and cleanup

Finalize the development account_invoice_download

75f1c0e

Update the account_invoice_download_weboob following the changes in account_invoice_download Add README.rst for the 2 modules

Add support for additional module-specific weboob config parameters

72102a1

Add weboob module management Improve log handling (explicit error when wrong pwd) account_invoice_import: by default, set tax to default tax of account when invoice_line_method = 1line_no_product

account_invoice_import: add a mail gateway

885701a

Update text displayed in the invoice import wizard and make list of supported formats modular (like in bank statement import)

Add ability to run cron invoice download from admin for all companies…

a26c969

… in multi-company environnement Fix my previous commit on sequence field on invoice import config (caused a crash when creating a new record) Usability improvements on download config

Add multi-company support in the invoice import mail gateway

24c322d

Check the VAT number of the destination partner, to make sure the bus…

4c3309a

…iness document is imported in the right company

[UPD] Update account_invoice_import.pot

fb619e4

[FIX] include some of the fixes proposed in OCA#64

c05e0d0

[11.0][MIG] account_invoice_import

633a503

[FIX] clean rebase from V10 that where wrong ...

15aa4bd

[FIX] utf8 comment in python3

c74b29e

Fix base64 encode/decode + remove supplier_invoice_number + code review

a1d2ddd

[UPD] Update account_invoice_import.pot

f41a4e8

Update translation files

879dcb0

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

bump to 12.0.1.0.0

f4590ff

rubdos changed the title ~~[12.0] mig account_invoice_import_ubl~~ [12.0] mig account_invoice_import Mar 9, 2019

astirpe requested changes Mar 14, 2019

View reviewed changes

astirpe mentioned this pull request Apr 3, 2019

[12.0][MIG] account_invoice_import_ubl #103

Merged

1 task

emagdalenaC2i mentioned this pull request Jun 1, 2019

Migration to version 12.0 #69

Closed

18 tasks

pedrobaeza added this to the 12.0 milestone Jun 4, 2019

astirpe mentioned this pull request Jan 3, 2020

[12.0][MIG] account_invoice_import #162

Merged

1 task

astirpe closed this Jan 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[12.0] mig account_invoice_import #93

[12.0] mig account_invoice_import #93

rubdos commented Mar 9, 2019

oca-clabot commented Mar 9, 2019

astirpe Mar 14, 2019

astirpe Mar 14, 2019

astirpe Mar 14, 2019

astirpe Mar 14, 2019

astirpe Mar 14, 2019

astirpe Mar 14, 2019

astirpe Mar 14, 2019

astirpe Mar 14, 2019

astirpe Mar 14, 2019

astirpe Mar 14, 2019

TheCloneMaster commented May 8, 2019

astirpe commented May 8, 2019

mgielissen commented Dec 31, 2019

njeudy commented Jan 2, 2020

astirpe commented Jan 3, 2020

	'website': 'http://www.akretion.com',
	'website': 'https://github.com/OCA/edi',

	<xpath expr="//div[@data-key='account_invoicing']" position="inside">
	<xpath expr="//div[@data-key='account']" position="inside">

	'product': {'code': 'AII-TEST-PRODUCT'},
	'product': {'default_code': 'AII-TEST-PRODUCT'},

[12.0] mig account_invoice_import #93

[12.0] mig account_invoice_import #93

Conversation

rubdos commented Mar 9, 2019

oca-clabot commented Mar 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TheCloneMaster commented May 8, 2019

astirpe commented May 8, 2019

mgielissen commented Dec 31, 2019

njeudy commented Jan 2, 2020

astirpe commented Jan 3, 2020