[MIG] website_event_snippet_calendar: Migration to 13.0 #191

ajaniszewska-dev · 2020-09-28T13:39:05Z

current status:

elements marked in red doesn't work:

pedrobaeza · 2020-09-28T13:47:49Z

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

pedrobaeza · 2020-09-28T16:13:41Z

Still without commit history and with red Travis. What doubts do you have?

ajaniszewska-dev · 2020-09-29T06:59:39Z

Still without commit history and with red Travis. What doubts do you have?

will fix it today.

…list (OCA#101) Allows the user to display a calendar combined with a list of events. Includes controllers for such information to be bundled into any page through an `<iframe>`.

Before this patch, the user was getting the Public User's TZ on the calendar view. After merged, only the event's timzeone will be used to display dates. It is, however, affected by odoo/odoo#27179, which means that there is a possible mismatch between the date used to search and the one used to display, most likely to be hit when events have very different timzeones. Added to Known Issues.

Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-12.0/event-12.0-website_event_snippet_calendar Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-website_event_snippet_calendar/

These controllers were ignoring the `website_lang` cookie because they were not enabled for website. Thus, event results were downloaded in default language instead of the current one. @Tecnativa TT20711

Pretty obvious things missing from BS4 migration. @Tecnativa TT17632

pedrobaeza · 2020-09-29T09:17:12Z

Great, thanks. Let's see the Travis result.

ajaniszewska-dev · 2020-09-29T09:27:33Z

Great, thanks. Let's see the Travis result.

@pedrobaeza failing, but that's fine, will fix it, test and switch PR to 'Ready for review' when work will be done, for now let's keep it in draft so it is ok to fail.
feel free to comment, any suggestions are welcome.

pedrobaeza · 2020-09-29T09:29:50Z

OK, I can't say about the content itself, only the procedure.

yajo · 2020-10-09T12:57:00Z

website_event_snippet_calendar/static/src/js/animation.js

-    var DATETIME_FORMAT = time.strftime_to_moment_format("%Y-%m-%d %H:%M:%S");
+    var DATETIME_FORMAT = time.strftime_to_moment_format("%Y-%M-%D %H:%m:%s");


I doubt very much this change is good.

yajo · 2020-10-09T12:57:23Z

website_event_snippet_calendar/static/src/js/animation.js

-                    element.date_begin = date_begin_located.format(this.date_format);
+                    Element.date_begin = date_begin_located.format(this.date_format);


This should be a bug also.

yajo · 2020-10-09T13:02:10Z

website_event_snippet_calendar/templates/snippets.xml

+    <template id="snippet_options" inherit_id="website.snippet_options">
+        <xpath expr=".">
+            <!-- Allow to add or remove events from the list -->
+            <div
+                data-js="website_event_snippet_calendar_list"
+                data-selector=".s_event_calendar_list:has(.js_amount)"
+            >
+                <li data-only="click" data-increase="1">
+                    <a tabindex="-1"><i class="fa fa-plus" /> Add one event</a>
+                </li>
+                <li data-only="click" data-increase="-1">
+                    <a tabindex="-1"><i class="fa fa-minus" /> Remove one event</a>
+                </li>
+            </div>
+        </xpath>
+    </template>
+</odoo>


You need to fix this template and adapt it to the new format in v13 to make it work. It's broken as you said.

any hint where the problem lies with this template?

Well.. you'll have to take a look at how website snippets are added in upstream website for v13 and try to imitate that method here.

grindtildeath · 2020-10-23T10:30:41Z

@ajaniszewska-dev Seems you still have to fix pre-commit here

pedrobaeza · 2021-05-11T15:57:48Z

Superseded by #213

ajaniszewska-dev mentioned this pull request Sep 28, 2020

Migration to version 13.0 #168

Closed

29 tasks

ajaniszewska-dev force-pushed the 13.0-mig-website_event_snippet_calendar branch from 65709f2 to 1653b00 Compare September 28, 2020 14:17

yajo and others added 12 commits September 29, 2020 10:59

[ADD] website_event_snippet_calendar: Snippet for event calendar and …

6754b99

…list (OCA#101) Allows the user to display a calendar combined with a list of events. Includes controllers for such information to be bundled into any page through an `<iframe>`.

[UPD] Update website_event_snippet_calendar.pot

a8a76cc

[MIG] website_event_snippet_calendar: Migration to 12.0

4b1e59f

Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>

[UPD] README.rst

3d6ade6

[UPD] Update website_event_snippet_calendar.pot

d9a66cf

Update translation files

73e8794

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-12.0/event-12.0-website_event_snippet_calendar Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-website_event_snippet_calendar/

[FIX] website_event_snippet_calendar: Respect user lang

71c727f

These controllers were ignoring the `website_lang` cookie because they were not enabled for website. Thus, event results were downloaded in default language instead of the current one. @Tecnativa TT20711

website_event_snippet_calendar 12.0.1.0.1

708021f

[FIX] website_event_snippet_calendar: BS4 styles

e90bf50

Pretty obvious things missing from BS4 migration. @Tecnativa TT17632

website_event_snippet_calendar 12.0.1.1.0

8d4772a

[IMP] website_event_snippet_calendar: black, isort, prettier

0e41147

ajaniszewska-dev force-pushed the 13.0-mig-website_event_snippet_calendar branch 2 times, most recently from 15d47bf to c39ddf8 Compare September 29, 2020 09:16

pedrobaeza added this to the 13.0 milestone Sep 29, 2020

pedrobaeza requested a review from yajo September 29, 2020 09:17

ajaniszewska-dev force-pushed the 13.0-mig-website_event_snippet_calendar branch 4 times, most recently from f6260ee to 7518e3a Compare October 2, 2020 14:35

ajaniszewska-dev marked this pull request as ready for review October 6, 2020 13:21

ajaniszewska-dev force-pushed the 13.0-mig-website_event_snippet_calendar branch from 7518e3a to ace063f Compare October 7, 2020 14:50

ajaniszewska-dev force-pushed the 13.0-mig-website_event_snippet_calendar branch from ace063f to cb38087 Compare October 8, 2020 09:43

yajo requested changes Oct 9, 2020

View reviewed changes

ajaniszewska-dev force-pushed the 13.0-mig-website_event_snippet_calendar branch 2 times, most recently from 0d4d8b8 to 4063493 Compare October 16, 2020 06:59

ajaniszewska-dev force-pushed the 13.0-mig-website_event_snippet_calendar branch from 4063493 to fd05d59 Compare October 22, 2020 13:48

grindtildeath approved these changes Oct 23, 2020

View reviewed changes

ajaniszewska-dev force-pushed the 13.0-mig-website_event_snippet_calendar branch from fd05d59 to 5f06028 Compare October 23, 2020 11:16

[MIG] website_event_snippet_calendar: Migration to 13.0

578c134

ajaniszewska-dev force-pushed the 13.0-mig-website_event_snippet_calendar branch from 5f06028 to 578c134 Compare October 23, 2020 15:30

damdam-s mentioned this pull request May 11, 2021

[13.0][mig] website_event_snippet_calendar #213

Closed

pedrobaeza closed this May 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] website_event_snippet_calendar: Migration to 13.0 #191

[MIG] website_event_snippet_calendar: Migration to 13.0 #191

ajaniszewska-dev commented Sep 28, 2020 •

edited

Loading

pedrobaeza commented Sep 28, 2020

pedrobaeza commented Sep 28, 2020

ajaniszewska-dev commented Sep 29, 2020

pedrobaeza commented Sep 29, 2020

ajaniszewska-dev commented Sep 29, 2020

pedrobaeza commented Sep 29, 2020

yajo Oct 9, 2020

yajo Oct 9, 2020

yajo Oct 9, 2020

ajaniszewska-dev Oct 9, 2020

yajo Nov 27, 2020

grindtildeath commented Oct 23, 2020

pedrobaeza commented May 11, 2021

		var DATETIME_FORMAT = time.strftime_to_moment_format("%Y-%m-%d %H:%M:%S");
		var DATETIME_FORMAT = time.strftime_to_moment_format("%Y-%M-%D %H:%m:%s");

		element.date_begin = date_begin_located.format(this.date_format);
		Element.date_begin = date_begin_located.format(this.date_format);

[MIG] website_event_snippet_calendar: Migration to 13.0 #191

[MIG] website_event_snippet_calendar: Migration to 13.0 #191

Conversation

ajaniszewska-dev commented Sep 28, 2020 • edited Loading

pedrobaeza commented Sep 28, 2020

pedrobaeza commented Sep 28, 2020

ajaniszewska-dev commented Sep 29, 2020

pedrobaeza commented Sep 29, 2020

ajaniszewska-dev commented Sep 29, 2020

pedrobaeza commented Sep 29, 2020

yajo Oct 9, 2020

Choose a reason for hiding this comment

yajo Oct 9, 2020

Choose a reason for hiding this comment

yajo Oct 9, 2020

Choose a reason for hiding this comment

ajaniszewska-dev Oct 9, 2020

Choose a reason for hiding this comment

yajo Nov 27, 2020

Choose a reason for hiding this comment

grindtildeath commented Oct 23, 2020

pedrobaeza commented May 11, 2021

ajaniszewska-dev commented Sep 28, 2020 •

edited

Loading