[13.0][mig] website_event_snippet_calendar #213

damdam-s · 2021-05-11T15:51:26Z

superseedes #191

damdam-s · 2021-05-11T15:52:22Z

@yajo snippet fixed and working

damdam-s · 2021-05-11T15:53:07Z

added some improvements for the calendar (calendar view and event list) to take care of the filters applied (eg: event category)

yajo

Tested on runbot and it doesn't work:

Peek.12-05-2021.07-50.mp4

Traceback in debug assets mode:

Error:


Traceback:
Error: $(...)[0] is undefined
load_events@http://3482153-213-1b3e23.runbot1-3.odoo-community.org/website_event_snippet_calendar/static/src/js/animation.js:128:25
start@http://3482153-213-1b3e23.runbot1-3.odoo-community.org/website_event_snippet_calendar/static/src/js/animation.js:60:18
OdooClass.extend/</prototype[name]</<@http://3482153-213-1b3e23.runbot1-3.odoo-community.org/web/static/src/js/core/class.js:90:38
attachTo/<@http://3482153-213-1b3e23.runbot1-3.odoo-community.org/web/static/src/js/core/widget.js:207:25

Besides, you have to fix that security hole explained below.

website_event_snippet_calendar/controllers/main.py

MeetKD

Minor change

website_event_snippet_calendar/controllers/main.py

damdam-s · 2021-05-17T09:32:01Z

@yajo @MeetKD fixed

website_event_snippet_calendar/controllers/main.py

damdam-s · 2021-05-17T12:45:01Z

@MeetKD @yajo finally green travis & runbot

MeetKD

Looks good.

yajo

Code looks good, but unfortunately, it still does not work:

Peek.20-05-2021.09-09.mp4

damdam-s · 2021-05-20T08:29:07Z

@yajo can you please give me the url of the runbot you are using? I managed to make it work on runbot.

Ah BTW, the widget must be placed on the event page ... (that's my usecase at least).
Checking why it doesn't work on other pages

yajo · 2021-05-20T08:32:32Z

can you please give me the url of the runbot you are using?

It's the one you get to when clicking here:

damdam-s · 2021-06-01T09:26:23Z

@yajo seems ok now

…list (OCA#101) Allows the user to display a calendar combined with a list of events. Includes controllers for such information to be bundled into any page through an `<iframe>`.

Before this patch, the user was getting the Public User's TZ on the calendar view. After merged, only the event's timzeone will be used to display dates. It is, however, affected by odoo/odoo#27179, which means that there is a possible mismatch between the date used to search and the one used to display, most likely to be hit when events have very different timzeones. Added to Known Issues.

Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>

Pretty obvious things missing from BS4 migration. @Tecnativa TT17632

ValentinVinagre · 2021-06-11T16:19:41Z

Hey @damdam-s looks good. Do you think could it be posible to add a filter by event type?

yajo · 2021-06-15T07:13:19Z

event_registration_cancel_reason/models/event_registration.py

-<<<<<<< HEAD
-    name = fields.Char(string="Reason", required=True, translate=True)
-=======
    name = fields.Char("Reason", required=True, translate=True)
->>>>>>> [IMP] : black, isort, prettier


Please fix the conflicts instead of committing this.

yajo · 2021-06-15T07:14:51Z

website_event_snippet_calendar/controllers/main.py

@@ -54,12 +55,23 @@ def events_for_day(self, day=None, limit=None):
        :param limit int:
            How many results to return.
        """
+
+        searches = parse_qsl(searches[1:])


This is error-prone. If you do None[1:] you'll get an error.

BTW I think it would be better if the JS client calls this argument directly with an array of results. Passing in a query string as a JSON argument doesn't seem very ergonomic.

yajo · 2021-06-15T07:15:53Z

website_event_snippet_calendar/controllers/main.py

+        for search in searches:
+            if search[0] == "type":
+                try:
+                    value = int(search[1])
+                except ValueError:
+                    value = 0
+                if value:
+                    domain.append(("event_type_id", "=", int(search[1])))


If all you're using searches for is for filtering by type, it would be better if the parameter were called type directly and got an int or List[int].

github-actions · 2022-02-06T12:14:13Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

github-actions · 2022-07-17T12:19:24Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

rafaelbn · 2022-12-17T10:31:29Z

/ocabot migraton website_event_snippet_calendar

OCA-git-bot · 2022-12-17T10:31:32Z

Hi @rafaelbn. Your command failed:

Invalid command: migraton.

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

rafaelbn · 2022-12-17T10:31:54Z

/ocabot migration website_event_snippet_calendar

OCA-git-bot · 2022-12-17T10:32:02Z

There's no issue in this repo with the title 'Migration to version 13.0' and the milestone 13.0, so not possible to add the comment.

rafaelbn · 2022-12-17T10:36:07Z

Hello @damdam-s , are you going to attend the review is pending?

Hello @Camille0907 are you going to review this PR?

rafaelbn · 2022-12-17T10:38:10Z

/ocabot migration website_event_snippet_calendar

github-actions · 2023-04-23T12:17:08Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

pedrobaeza mentioned this pull request May 11, 2021

[MIG] website_event_snippet_calendar: Migration to 13.0 #191

Closed

yajo requested changes May 12, 2021

View reviewed changes

website_event_snippet_calendar/controllers/main.py Outdated Show resolved Hide resolved

rousseldenis added migration needs review labels May 12, 2021

rousseldenis added this to the 13.0 milestone May 12, 2021

rousseldenis mentioned this pull request May 12, 2021

Migration to version 13.0 #168

Closed

29 tasks

MeetKD reviewed May 14, 2021

View reviewed changes

website_event_snippet_calendar/controllers/main.py Outdated Show resolved Hide resolved

damdam-s force-pushed the 13.0-mig-website_event_snippet_calendar branch from c5ed2e8 to e670dfa Compare May 17, 2021 09:35

MeetKD suggested changes May 17, 2021

View reviewed changes

website_event_snippet_calendar/controllers/main.py Outdated Show resolved Hide resolved

damdam-s force-pushed the 13.0-mig-website_event_snippet_calendar branch 2 times, most recently from 99a11f4 to b1dc256 Compare May 17, 2021 12:08

MeetKD approved these changes May 17, 2021

View reviewed changes

ajaniszewska-dev approved these changes May 17, 2021

View reviewed changes

yajo requested changes May 20, 2021

View reviewed changes

damdam-s force-pushed the 13.0-mig-website_event_snippet_calendar branch from 315279e to 84cb798 Compare June 1, 2021 09:30

damdam-s force-pushed the 13.0-mig-website_event_snippet_calendar branch from 84cb798 to e5c58cf Compare June 10, 2021 06:52

victoralmau and others added 7 commits June 10, 2021 08:54

[IMP] : black, isort, prettier

b350350

[ADD] website_event_snippet_calendar: Snippet for event calendar and …

9715298

…list (OCA#101) Allows the user to display a calendar combined with a list of events. Includes controllers for such information to be bundled into any page through an `<iframe>`.

[UPD] Update website_event_snippet_calendar.pot

7b84752

[MIG] website_event_snippet_calendar: Migration to 12.0

a9e3a80

Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>

[UPD] README.rst

2cc1243

[UPD] Update website_event_snippet_calendar.pot

64476fc

OCA-git-bot and others added 4 commits June 10, 2021 08:54

website_event_snippet_calendar 12.0.1.0.1

887b08e

[FIX] website_event_snippet_calendar: BS4 styles

ecb2257

Pretty obvious things missing from BS4 migration. @Tecnativa TT17632

website_event_snippet_calendar 12.0.1.1.0

8196f0c

[IMP] website_event_snippet_calendar: black, isort, prettier

567a37e

damdam-s force-pushed the 13.0-mig-website_event_snippet_calendar branch from e5c58cf to 104764e Compare June 10, 2021 06:54

[MIG] website_event_snippet_calendar: Migration to 13.0

db4f817

damdam-s force-pushed the 13.0-mig-website_event_snippet_calendar branch from 104764e to db4f817 Compare June 10, 2021 06:58

yajo requested changes Jun 15, 2021

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 6, 2022

github-actions bot closed this Mar 13, 2022

rafaelbn reopened this Mar 13, 2022

rafaelbn removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 13, 2022

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 17, 2022

github-actions bot closed this Aug 21, 2022

Camille0907 mentioned this pull request Dec 16, 2022

Migration to version 15.0 #237

Open

16 tasks

rafaelbn reopened this Dec 17, 2022

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 18, 2022

Camille0907 mentioned this pull request Dec 20, 2022

[15.0] [MIG] website_event_snippet_calendar: Migration to 15.0 #288

Merged

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 23, 2023

github-actions bot closed this May 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[13.0][mig] website_event_snippet_calendar #213

[13.0][mig] website_event_snippet_calendar #213

damdam-s commented May 11, 2021

damdam-s commented May 11, 2021

damdam-s commented May 11, 2021

yajo left a comment

MeetKD left a comment

damdam-s commented May 17, 2021

damdam-s commented May 17, 2021

MeetKD left a comment

yajo left a comment

damdam-s commented May 20, 2021

yajo commented May 20, 2021

damdam-s commented Jun 1, 2021

ValentinVinagre commented Jun 11, 2021

yajo Jun 15, 2021

yajo Jun 15, 2021

yajo Jun 15, 2021

github-actions bot commented Feb 6, 2022

github-actions bot commented Jul 17, 2022

rafaelbn commented Dec 17, 2022

OCA-git-bot commented Dec 17, 2022

rafaelbn commented Dec 17, 2022

OCA-git-bot commented Dec 17, 2022

rafaelbn commented Dec 17, 2022

rafaelbn commented Dec 17, 2022

github-actions bot commented Apr 23, 2023

[13.0][mig] website_event_snippet_calendar #213

[13.0][mig] website_event_snippet_calendar #213

Conversation

damdam-s commented May 11, 2021

damdam-s commented May 11, 2021

damdam-s commented May 11, 2021

yajo left a comment

Choose a reason for hiding this comment

MeetKD left a comment

Choose a reason for hiding this comment

damdam-s commented May 17, 2021

damdam-s commented May 17, 2021

MeetKD left a comment

Choose a reason for hiding this comment

yajo left a comment

Choose a reason for hiding this comment

damdam-s commented May 20, 2021

yajo commented May 20, 2021

damdam-s commented Jun 1, 2021

ValentinVinagre commented Jun 11, 2021

yajo Jun 15, 2021

Choose a reason for hiding this comment

yajo Jun 15, 2021

Choose a reason for hiding this comment

yajo Jun 15, 2021

Choose a reason for hiding this comment

github-actions bot commented Feb 6, 2022

github-actions bot commented Jul 17, 2022

rafaelbn commented Dec 17, 2022

OCA-git-bot commented Dec 17, 2022

rafaelbn commented Dec 17, 2022

OCA-git-bot commented Dec 17, 2022

rafaelbn commented Dec 17, 2022

rafaelbn commented Dec 17, 2022

github-actions bot commented Apr 23, 2023