Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] event_contact #209

Merged
merged 12 commits into from
May 19, 2021
Merged

[13.0][MIG] event_contact #209

merged 12 commits into from
May 19, 2021

Conversation

dalonsod
Copy link
Contributor

@dalonsod dalonsod commented Apr 5, 2021

Standard migration, only onchange method moved to computed for contact_ids event field.

mikevhe18 and others added 12 commits April 4, 2021 12:19
@mikevhe18 @dalonsod
Changing name module into singular
83691f5
@mikevhe18 @dalonsod
adjust according to comment
b518317
@yajo @dalonsod
[IMP][event_contact] Add contact_ids to event.type.
70a89c5 
Also it will load the contacts from the event type if the event has none and the type has some.
@pedrobaeza @dalonsod
[IMP] event_contact: Spanish translation
a60d3aa
@yajo @dalonsod
[MIG][event_contact] Migration to v10
c985a9c 
Document new behavior for event type contacts, and fix its test.
@oca-travis @dalonsod
[UPD] Update event_contact.pot
6d0d17e
@Tardo @dalonsod
[MIG] event_contact: Migration to 12.0
8c2215d
@OCA-git-bot @dalonsod
[UPD] README.rst
95e46d0
@oca-travis @dalonsod
[UPD] Update event_contact.pot
64a818d
@oca-transbot @dalonsod
Update translation files
4200b0a 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: event-12.0/event-12.0-event_contact
Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-event_contact/
@dalonsod
[IMP] event_contact: black, isort, prettier
e00ac14
@dalonsod
[MIG] event_contact: Migration to 13.0
2f7b824
@dalonsod
Copy link
Contributor Author

dalonsod commented Apr 5, 2021

@Tardo @yajo could you review? Thanks!

@yajo yajo added this to the 13.0 milestone May 11, 2021
@yajo yajo mentioned this pull request May 11, 2021
Closed
29 tasks
MeetKD
MeetKD approved these changes May 15, 2021
View reviewed changes
Copy link

@MeetKD MeetKD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor Non blocking change.

event_contact/models/event_event.py
# Copyright 2017 Jairo Llopis <jairo.llopis@tecnativa.com>
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

from openerp import api, fields, models
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Openerp - > odoo

@yajo
Copy link
Member

yajo commented May 19, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-209-by-Yajo-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit adb7811 into OCA:13.0 May 19, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8a4cdbc. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo yajo approved these changes

@MeetKD MeetKD MeetKD approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
9 participants
@dalonsod @yajo @OCA-git-bot @MeetKD @mikevhe18 @pedrobaeza @oca-travis @Tardo @oca-transbot