Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0] [MIG] website_event_snippet_calendar: Migration to 15.0 #288

Merged
merged 12 commits into from
Jun 26, 2023
Merged

[15.0] [MIG] website_event_snippet_calendar: Migration to 15.0 #288

merged 12 commits into from
Jun 26, 2023

Conversation

Camille0907
Copy link

@Camille0907 Camille0907 commented Dec 20, 2022 •
edited
Loading

Migration of website_event_snippet_calendar module from v13 (from this pr) to v15

I tried to take into accounts the last comments from the v13 pr, more recent than the latest fore-push on the branch :

I also made some improvements:

  • The filter is taken into account for enabling the right days on the calendar
  • The option in the website has been a little bit changed:
    • The buttons to change the number of events have been renamed
    • The number of events can't go under 1 (0 was authorized, but not managed, before)
  • There is now a message if the list is empty, to explain that no event is available

yajo and others added 10 commits December 16, 2022 11:00
@yajo @Camille0907
[ADD] website_event_snippet_calendar: Snippet for event calendar and …
9dd6222 
…list (OCA#101)

Allows the user to display a calendar combined with a list of events.

Includes controllers for such information to be bundled into any page through an `<iframe>`.
@yajo @Camille0907
[FIX] website_event_snippet_calendar: Display event timezone
7687b72 
Before this patch, the user was getting the Public User's TZ on the
calendar view.

After merged, only the event's timzeone will be used to display dates.

It is, however, affected by odoo/odoo#27179,
which means that there is a possible mismatch between the date used
to search and the one used to display, most likely to be hit when
events have very different timzeones. Added to Known Issues.
@Tardo @yajo @Camille0907
[MIG] website_event_snippet_calendar: Migration to 12.0
328ad10 
Co-Authored-By: Jairo Llopis <Yajo@users.noreply.github.com>
@yajo @Camille0907
[FIX] website_event_snippet_calendar: Respect user lang
087cccc 
These controllers were ignoring the `website_lang` cookie because they were not enabled for website. Thus, event results were downloaded in default language instead of the current one.

@Tecnativa TT20711
@OCA-git-bot @Camille0907
website_event_snippet_calendar 12.0.1.0.1
5e8efc9
@Camille0907
[FIX] website_event_snippet_calendar: BS4 styles
57db908 
Pretty obvious things missing from BS4 migration.

@Tecnativa TT17632
@OCA-git-bot @Camille0907
website_event_snippet_calendar 12.0.1.1.0
036d19f
@ajaniszewska-dev @Camille0907
[IMP] website_event_snippet_calendar: black, isort, prettier
0bac222
@ajaniszewska-dev @Camille0907
[MIG] website_event_snippet_calendar: Migration to 13.0
3206a00
@Camille0907
[IMP] website_event_snippet_calendar: black, isort, prettier
2812444
@Camille0907 Camille0907 changed the title 15.0 mig website event snippet calendar [15.0] [MIG] website_event_snippet_calendar: Migration to 15.0 Dec 20, 2022
@Camille0907 Camille0907 force-pushed the 15.0-mig-website_event_snippet_calendar branch from 605b6d6 to 6c32a81 Compare December 20, 2022 16:32
@Camille0907 Camille0907 mentioned this pull request Dec 20, 2022
Open
16 tasks
@Camille0907 Camille0907 force-pushed the 15.0-mig-website_event_snippet_calendar branch from 6c32a81 to 90317cd Compare January 11, 2023 09:01
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Camille0907
Copy link
Author

Added one commit to split the function that allows to get events to display, to ease the overriding of the domain
I don't know if we want it in the migration commit or not

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 25, 2023
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-288-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2d91cd9 into OCA:15.0 Jun 26, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3ebfcd1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankinmax yankinmax yankinmax approved these changes

@chienandalu chienandalu chienandalu approved these changes

@damdam-s damdam-s damdam-s approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Camille0907 @OCA-git-bot @pedrobaeza @chienandalu @damdam-s @yankinmax @yajo @Tardo @ajaniszewska-dev