[15.0][MIG] partner_event: Migration to version 15.0 #293

stefan-tecnativa · 2023-01-12T10:56:26Z

cc @Tecnativa TT41018

@chienandalu @victoralmau please review

chienandalu

Check pre-commit please

chienandalu

Functional test ok.

Fix your migration commit message as is reversed with its content
Let's update that old icon

partner_event/tests/test_event_registration.py

OCA-git-bot · 2023-01-23T12:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza

Please squash together these translation commits:

and also include the SVG in partner_event/static/description folder

partner_event/__manifest__.py

stefan-tecnativa · 2023-01-25T07:59:32Z

Please squash together these translation commits:

and also include the SVG in partner_event/static/description folder

Would it be appropriate to do this with all translation commits as well?

pedrobaeza · 2023-01-25T08:20:34Z

Would it be appropriate to do this with all translation commits as well?

No, because you will lose the attribution to the corresponding translator. That's why I only say to merge together the translations from the same translator.

pedrobaeza · 2023-01-25T08:23:22Z

On the new push you have made, I'm not seeing any of the Italian translation commits. Have you removed them or squash with another? I'm now also seeing 2 Swedish translation commits coming from the same person that can be squashed together.

stefan-tecnativa · 2023-01-25T08:23:51Z

Would it be appropriate to do this with all translation commits as well?

No, because you will lose the attribution to the corresponding translator. That's why I only say to merge together the translations from the same translator.

Okay, understood. Thanks.

These fields were stored. That usually is good, but if you add partners to an event from the wizard, it means each `res.partner` record gets its `registration_count` field updated. When you update any record, fields `write_uid` and `write_date` are updated too. Now imagine you want to add 4000 partners to an event. That would take time. If in the mean time any other user updates the `res.partner` record (along with their `write_UID` and `WRITE_DATE` fields), you would get this error: ``` openerp.sql_db: bad query: UPDATE "res_partner" SET "registration_count"=3,"write_uid"=5,"write_date"=(now() at time zone 'UTC') WHERE id IN (25578) Traceback (most recent call last): File "/opt/odoo/common/openerp/v8/openerp/sql_db.py", line 234, in execute res = self._obj.execute(query, params) TransactionRollbackError: could not serialize access due to concurrent update CONTEXT: SQL statement "SELECT 1 FROM ONLY "public"."res_users" x WHERE "id" OPERATOR(pg_catalog.=) $1 FOR KEY SHARE OF x" ``` By removing the `store=True` parameter, you simply avoid those concurrent updates and do not block other users. But this changes the database structure, so remember to update your database!

…CA#48)

If adding 1000 partners, we save now 999 queries. (cherry picked from commit 89853ef)

Currently translated at 100.0% (24 of 24 strings) Translation: event-12.0/event-12.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-partner_event/es/

Currently translated at 72.0% (18 of 25 strings) Translation: event-14.0/event-14.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-14-0/event-14-0-partner_event/it/

stefan-tecnativa · 2023-01-25T12:31:48Z

On the new push you have made, I'm not seeing any of the Italian translation commits. Have you removed them or squash with another? I'm now also seeing 2 Swedish translation commits coming from the same person that can be squashed together.

Change done.

pedrobaeza

/ocabot merge nobump
/ocabot migration partner_event

OCA-git-bot · 2023-01-25T12:50:50Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-293-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-01-25T12:50:53Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2023-01-25T12:56:54Z

Congratulations, your PR was merged at f177cd1. Thanks a lot for contributing to OCA. ❤️

chienandalu suggested changes Jan 12, 2023

View reviewed changes

stefan-tecnativa force-pushed the 15.0-mig-partner_event branch from 7d378e9 to ac0cfbe Compare January 13, 2023 08:58

chienandalu suggested changes Jan 13, 2023

View reviewed changes

stefan-tecnativa force-pushed the 15.0-mig-partner_event branch from ac0cfbe to ddeaf0b Compare January 23, 2023 08:29

chienandalu reviewed Jan 23, 2023

View reviewed changes

partner_event/tests/test_event_registration.py Outdated Show resolved Hide resolved

stefan-tecnativa force-pushed the 15.0-mig-partner_event branch from ddeaf0b to 19d99b2 Compare January 23, 2023 09:57

chienandalu approved these changes Jan 23, 2023

View reviewed changes

victoralmau approved these changes Jan 23, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Jan 23, 2023

pedrobaeza requested changes Jan 23, 2023

View reviewed changes

partner_event/__manifest__.py Outdated Show resolved Hide resolved

OCA-git-bot removed approved ready to merge labels Jan 23, 2023

stefan-tecnativa force-pushed the 15.0-mig-partner_event branch from 19d99b2 to 9461b1e Compare January 25, 2023 07:55

antespi and others added 11 commits January 25, 2023 13:25

[ADD] partner event addon

3bcffca

Slovene translations added

dba65f2

Auto create partners in event registrations

6900768

Propagate partner changes and show errors when registering partners (O…

710a614

…CA#48)

[MIG] partner_event: Migration to 9.0

bab3443

[MIG] partner_event: Migration to 10.0

32b3827

[10.0][IMP] partner_event: Set attendee partner

a2b511e

[IMP] partner_event: Do single browse

00227a5

If adding 1000 partners, we save now 999 queries. (cherry picked from commit 89853ef)

[IMP] partner_event: forbid partner deletion (OCA#94)

c908656

[MIG] partner_event: Migration to 11.0

0356df9

chienandalu and others added 15 commits January 25, 2023 13:25

[IMP] partner_event: catch onchange with attendee_partner (#1)

c844edb

[MIG]partner_event:Migrated the module from v11 to v12

8ac742b

[IMP] partner_event: README by fragments

a82cee1

Translated using Weblate (Spanish)

c777b1d

Currently translated at 100.0% (24 of 24 strings) Translation: event-12.0/event-12.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-partner_event/es/

[FIX] partner_event: Proper development status

859daa9

[IMP] partner_event: add data to old registrations

a9953c1

[IMP] partner_event: black, isort, prettier

7de849f

[MIG] partner_event: Migration to 13.0

22e9708

[MIG] partner_event : Migration to 14.0

b0fd027

Added translation using Weblate (Swedish)

b72e7e8

[FIX] partner_event: ondelete cascade for wizard

88a4436

Added translation using Weblate (Italian)

aac4b74

Translated using Weblate (Italian)

dd7dc99

Currently translated at 72.0% (18 of 25 strings) Translation: event-14.0/event-14.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-14-0/event-14-0-partner_event/it/

[IMP] partner_event: black, isort, prettier

0527655

[MIG] partner_event: Migration to 15.0

87cd1b9

stefan-tecnativa force-pushed the 15.0-mig-partner_event branch from 9461b1e to 87cd1b9 Compare January 25, 2023 12:30

pedrobaeza approved these changes Jan 25, 2023

View reviewed changes

OCA-git-bot added the approved label Jan 25, 2023

OCA-git-bot added the bot is merging ⏳ label Jan 25, 2023

OCA-git-bot added this to the 15.0 milestone Jan 25, 2023

OCA-git-bot added the ready to merge label Jan 25, 2023

OCA-git-bot mentioned this pull request Jan 25, 2023

Migration to version 15.0 #237

Open

16 tasks

OCA-git-bot merged commit 1e59d78 into OCA:15.0 Jan 25, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] partner_event: Migration to version 15.0 #293

[15.0][MIG] partner_event: Migration to version 15.0 #293

stefan-tecnativa commented Jan 12, 2023

chienandalu left a comment

chienandalu left a comment

OCA-git-bot commented Jan 23, 2023

pedrobaeza left a comment

stefan-tecnativa commented Jan 25, 2023

pedrobaeza commented Jan 25, 2023

pedrobaeza commented Jan 25, 2023

stefan-tecnativa commented Jan 25, 2023

stefan-tecnativa commented Jan 25, 2023

pedrobaeza left a comment

OCA-git-bot commented Jan 25, 2023

OCA-git-bot commented Jan 25, 2023

OCA-git-bot commented Jan 25, 2023

[15.0][MIG] partner_event: Migration to version 15.0 #293

[15.0][MIG] partner_event: Migration to version 15.0 #293

Conversation

stefan-tecnativa commented Jan 12, 2023

chienandalu left a comment

Choose a reason for hiding this comment

chienandalu left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 23, 2023

pedrobaeza left a comment

Choose a reason for hiding this comment

stefan-tecnativa commented Jan 25, 2023

pedrobaeza commented Jan 25, 2023

pedrobaeza commented Jan 25, 2023

stefan-tecnativa commented Jan 25, 2023

stefan-tecnativa commented Jan 25, 2023

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 25, 2023

OCA-git-bot commented Jan 25, 2023

OCA-git-bot commented Jan 25, 2023