Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] event_email_reminder: Migration to 15.0 #295

Merged
merged 10 commits into from
Feb 4, 2023

Conversation

victoralmau
Copy link
Member

Migration to 15.0

Please @CarlosRoca13 and @pedrobaeza can you review it?

@Tecnativa TT41010

sergio-teruel and others added 9 commits January 23, 2023 17:57
[ADD][8.0] event_email_reminder: Send reminder events by email
* [IMP] event_email_reminder: Allow negative intervals

This way, we can schedule an email after an event has finished.

* fixup! [IMP] event_email_reminder: Allow negative intervals
- Standard migration.
- Use native datetime types.
- Split README.
- Faster tests using `SavepointCase`.

[UPD] README.rst

[UPD] Update event_email_reminder.pot
TT27582

[UPD] Update event_email_reminder.pot

[UPD] README.rst
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chienandalu
Copy link
Member

An icon upgrade would be nice :)

@pedrobaeza
Copy link
Member

/ocabot migration event_email_reminder

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 28, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 28, 2023
16 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-295-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 2, 2023
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-295-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-295-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5f92ca3 into OCA:15.0 Feb 4, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5311f82. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants