[15.0][MIG] website_event_filter_city: Migration to 15.0 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can use selectors above the event list in the website, instead of the left column that there is right now. Store user customizations in separate template. Acknowledge that you cannot hide only the date filter. Remove search button; search on selection change. Fix bug where date did not match what was being filtered. [FIX][8.0][website_event_filter_selector] Do not die without types or countries This basically fixes OCA#44 and a similar bug detected that would happen when no countries were found. It just adds a `t-if` to avoid possible failures, [borrowing the idea from core `website_event` module](https://github.com/odoo/odoo/blob/8.0/addons/website_event/views/website_event.xml#L167). [8.0][IMP][website_event_filter_selector] Add city filter for events. Since this includes new logic, it adds also a template for left-column filters. With this patch, you can now filter events depending on their cities, not only on their countries. This also includes some modifications that will make filters occupy always a full bootstrap row, no matter if there are 1, 2, 3 or 4 filters, to avoid ugly layouts.
[IMP] website_event_filter_selector: Spanish translation [IMP] website_event_filter_selector: German translation [FIX] website_event_filter_selector: Fix date selection [FIX] website_event_filter_selector: Fix city count [FIX] website_event_filter_selector: Don't lose context with new obj
Relicensed to LGPL, new JS API. Add test. Fix errors found with it. Go 100% coverage. Support online events. [FIX][website_event_filter_selector] Fix Travis build Builds failed on 2017-03-31 because the tour was expecting to see USA event starting in this month, but next day was another month. Well, in short, this fix makes the tour work on any day.
Includes update to use new tours api. Patch event counts when a city is searched.
[IMP] Use new README approach [IMP] Removed the use of @Class [FIX] Column classes [UPD] README.rst [UPD] README.rst
- Use own demo data instead of upstream. - Fix some JS code that wasn't working as expected. - Remove dependency on left column; just test own filters widget. [UPD] README.rst [UPD] README.rst
With BS3, all these complex computations were needed to always display all filters at full width. With BS4 it's not needed anymore. @Tecnativa TT17632 website_event_filter_selector 12.0.1.1.0
Use `custom-select` in `<select>` elements instead of just `form-control`. This way BS4 can style the dropdowns more freely and they look more consistent with the rest of the site. I also delete a view that is no longer used. TT17632 website_event_filter_selector 12.0.1.2.0
To reproduce the problem: 1. Create an event on website 2. 2. Do not publish it. 3. Go to website 1. If you were logged in, that event still appeared as unpublished. It shouldn't happen because it belongs to other website, no matter whether it is published or not. @Tecnativa TT29748
Ok, bot, you win.
- Refactor to try to reuse as much from the core as possible. Anyway, as there's no external method to compose the domain we still have to redo some things in order to add our city filter stuff. - Consider the new name search term. - Fix test: it didn't expect online events when filtering by country, but Odoo core allows it explicitly. TT34958
chienandalu
changed the title
chienandalu
force-pushed
the
15.0-mig-website_event_filter_city
branch
from
ecac2f6
to
b708c2b
Compare
CarlosRoca13
approved these changes
Apr 4, 2023
chienandalu
force-pushed
the
15.0-mig-website_event_filter_city
branch
2 times, most recently
from
f745e6f
to
0909dea
Compare
|
Tests fixed |
chienandalu
force-pushed
the
15.0-mig-website_event_filter_city
branch
from
0909dea
to
004c70c
Compare
|
/ocabot migration website_event_filter_city |
|
On my way to merge this fine PR! |
OCA-git-bot
added a commit
that referenced
this pull request
Apr 4, 2023
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-309-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
1 similar comment
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-309-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
The merge failed although for another module's tests |
|
I think it was the "midnight case". /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT41028
please review @pedrobaeza @CarlosRoca13