[8.0][ADD][WIP][event_multi_image] Image gallery for events. #31
Conversation
|
Question: isn't there a product multi-image module? With the feature linking Events to Products there would be no need to have and event-specific multi-image. |
|
The event product could be i.e. "Conference", but each conference has its own gallery. |
|
OK |
| @@ -34,6 +34,9 @@ install: | |||
| - git clone https://github.com/OCA/maintainer-quality-tools.git ${HOME}/maintainer-quality-tools --depth=1 | |||
| - export PATH=${HOME}/maintainer-quality-tools/travis:${PATH} | |||
| - travis_install_nightly | |||
| - pip install python-ldap | |||
| - pip install unidecode | |||
| - pip install validate_email | |||
There was a problem hiding this comment.
Why the new dependencies?
There was a problem hiding this comment.
For product-attribute repo.
There was a problem hiding this comment.
OK. With the new support for requirements.txt on repos this will be unnecessary once the requirements file is added to product-attribute.
There was a problem hiding this comment.
Do you mean that I can remove this now, or that I will can in some near future?
|
Other than the added dependencies, LGTM. |
This module allows to have multiple images in each event.
| @@ -1,4 +1,5 @@ | |||
| # List the OCA project dependencies, one per line | |||
| # Add a repository url and branch if you need a forked version | |||
| server-tools | |||
There was a problem hiding this comment.
Runbot says:
except_orm: ('Error', u"You try to install module 'event_multi_image' that depends on module 'base_multi_image'.\nBut the latter module is not available in your system.")
That module is in server-tools now. Is it not enough to add it here?
There was a problem hiding this comment.
No, this is for Travis, but runbot isn't still able to process this. I'm adding it manually
|
LGTM 👍 |
|
👍 |
[8.0][ADD][WIP][event_multi_image] Image gallery for events.
This module allows to have multiple images in each event.
It depends on:
@rafaelbn