-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0][ADD][website_event_multi_image] Public image gallery in events #33
Conversation
Let's wait on the upstream PR. |
This will fail until OCA/product-attribute#112 and #31 get merged. This module takes functionalities from above ones and displays them in the website part of events. See readme for more details.
Please remove WIP label, upstream modules are merged now. I rebased to see if I get 💚 |
👍 |
I have tried the module in runbot, and I have some comments:
In the website image gallery, they appear cropped and very big: Is there the possibility to have another layout?
|
Tested on runbot 👍 . @pedrobaeza layout idea is nice to have though. But for now i'm good with current layout. Just put it on top of the page, bellow sales table |
Hi @pedrobaeza:
Fixed.
This is by design. Image galleries are mostly designed for big-size high-quality pics. They are autocropped to achieve a consistent layout, and to avoid forcing the user to set a specific image size. This is done by website_multi_image, and you can change behavior with themes if your specific website desires to display icons in the event slideshow.
This comes out of the box in Odoo 9, so it will be much easier there. I prefer to wait for migrating to target that. |
OK, then 👍 |
Travis fails |
cc @antespi |
Please @yajo check travis. Fixing travis we can merge this. Thanks cc @pedrobaeza |
As said, functionally 👍 but check travis before merging |
There is a problem from the |
Thanks @dreispt, it seems a permissions issue. I have to add an ACL that allows public users to read images from published events. Does anybody know how to do such thing? I think it is better than adding |
Maybe @hbrunn can suggest something. |
the ACL seems the way to go. And probably an |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
This will fail until OCA/server-tools#374
and #31 get merged.
This module takes functionalities from above ones and displays them in
the website part of events.
See readme for more details.
@rafaelbn