[15.0][IMP] partner_event: Do registration creation in batch + remove savepoint #340
Conversation
…oint For speeding up the process. Specially the removal of the savepoints makes that Postgres don't go slow as hell. Check https://www.cybertec-postgresql.com/en/subtransactions-and-performance-in-postgresql/ for some rationale. The problem happens even releasing the previous savepoints. As this module is very old, the reason for doing it this way and skip registrations with error is not fully known, but the view mentions about registration duplication, so let's avoid it and handle later other possible exceptions. TT26694
pedrobaeza
force-pushed
the
15.0-imp-partner_event-batch_registration
branch
from
9fe525d
to
8f71814
Compare
|
While removing the Do you see it correct? Should I put a constraint as well? |
|
👍🏻 I think it's correct like this. If the partner is already registered, it make sense to simply skip it |
|
OK, let's go for now improving this part: /ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 0f6cca8. Thanks a lot for contributing to OCA. ❤️ |
For speeding up the process. Specially the removal of the savepoints makes that Postgres don't go slow as hell. Check https://www.cybertec-postgresql.com/en/subtransactions-and-performance-in-postgresql/ for some rationale. The problem happens even releasing the previous savepoints.
As this module is very old, the reason for doing it this way and skip registrations with error is not fully known, but the view mentions about registration duplication, so let's avoid it and handle later other possible exceptions.
@Tecnativa TT26694