[16.0][MIG] partner_event: Migration to version 16.0 #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinafernandez-tecnativa
force-pushed
the
16.0-mig-partner_event
branch
from
5244b81
to
a58b570
Compare
|
/ocabot migration partner_event |
pedrobaeza
requested changes
Oct 4, 2023
chienandalu
reviewed
Oct 5, 2023
carolinafernandez-tecnativa
force-pushed
the
16.0-mig-partner_event
branch
from
a58b570
to
426ad62
Compare
|
WIP cherry-pick |
carolinafernandez-tecnativa
force-pushed
the
16.0-mig-partner_event
branch
from
426ad62
to
66d0874
Compare
These fields were stored. That usually is good, but if you add partners to an event from the wizard, it means each `res.partner` record gets its `registration_count` field updated.
When you update any record, fields `write_uid` and `write_date` are updated too.
Now imagine you want to add 4000 partners to an event. That would take time. If in the mean time any other user updates the `res.partner` record (along with their `write_UID` and `WRITE_DATE` fields), you would get this error:
```
openerp.sql_db: bad query: UPDATE "res_partner" SET "registration_count"=3,"write_uid"=5,"write_date"=(now() at time zone 'UTC') WHERE id IN (25578)
Traceback (most recent call last):
File "/opt/odoo/common/openerp/v8/openerp/sql_db.py", line 234, in execute
res = self._obj.execute(query, params)
TransactionRollbackError: could not serialize access due to concurrent update
CONTEXT: SQL statement "SELECT 1 FROM ONLY "public"."res_users" x WHERE "id" OPERATOR(pg_catalog.=) $1 FOR KEY SHARE OF x"
```
By removing the `store=True` parameter, you simply avoid those concurrent updates and do not block other users.
But this changes the database structure, so remember to update your database!
If adding 1000 partners, we save now 999 queries. (cherry picked from commit 89853ef)
Currently translated at 100.0% (24 of 24 strings) Translation: event-12.0/event-12.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-partner_event/es/
carolinafernandez-tecnativa
force-pushed
the
16.0-mig-partner_event
branch
3 times, most recently
from
41ae0f2
to
9c188de
Compare
|
@pedrobaeza @chienandalu could you please check it now? Thnks! |
|
Administrative commits squashing is missing. |
chienandalu
approved these changes
Oct 6, 2023
…oint For speeding up the process. Specially the removal of the savepoints makes that Postgres don't go slow as hell. Check https://www.cybertec-postgresql.com/en/subtransactions-and-performance-in-postgresql/ for some rationale. The problem happens even releasing the previous savepoints. As this module is very old, the reason for doing it this way and skip registrations with error is not fully known, but the view mentions about registration duplication, so let's avoid it and handle later other possible exceptions. TT26694
When we confirm a sale order, the registrations are precreated without the email info, so we were missing the chance to get the info for the partner attendant. Now we compute it on the write as well. TT45149
carolinafernandez-tecnativa
force-pushed
the
16.0-mig-partner_event
branch
from
9c188de
to
4410baa
Compare
Done! |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 52a3051. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tecnativa
TT45235
@pedrobaeza @chienandalu
P.D: Close PR #322