-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0][website_event_filter_selector] Migrate #67
Merged
pedrobaeza
merged 5 commits into
OCA:9.0
from
Tecnativa:9.0-website_event_filter_selector-mig
Jan 4, 2017
Merged
[9.0][website_event_filter_selector] Migrate #67
pedrobaeza
merged 5 commits into
OCA:9.0
from
Tecnativa:9.0-website_event_filter_selector-mig
Jan 4, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
force-pushed
the
9.0-website_event_filter_selector-mig
branch
from
December 21, 2016 13:43
05ea132
to
99d67ad
Compare
How I wish to see the new tours system in v10, I keep hitting bugs... This time odoo/odoo#14808. After all, all should go ✔️ now. |
rafaelbn
approved these changes
Dec 21, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in runbot
Travis error I'm afraid |
Please squash 8.0 commits by author and relevant topic |
yajo
force-pushed
the
9.0-website_event_filter_selector-mig
branch
from
December 22, 2016 10:35
4ed0d7e
to
f171095
Compare
You can use selectors above the event list in the website, instead of the left column that there is right now. Store user customizations in separate template. Acknowledge that you cannot hide only the date filter. Remove search button; search on selection change. Fix bug where date did not match what was being filtered.
… countries This basically fixes OCA#44 and a similar bug detected that would happen when no countries were found. It just adds a `t-if` to avoid possible failures, [borrowing the idea from core `website_event` module](https://github.com/odoo/odoo/blob/8.0/addons/website_event/views/website_event.xml#L167).
Since this includes new logic, it adds also a template for left-column filters. With this patch, you can now filter events depending on their cities, not only on their countries. This also includes some modifications that will make filters occupy always a full bootstrap row, no matter if there are 1, 2, 3 or 4 filters, to avoid ugly layouts.
[IMP] website_event_filter_selector: Spanish translation [IMP] website_event_filter_selector: German translation [FIX] website_event_filter_selector: Fix date selection [FIX] website_event_filter_selector: Fix city count [FIX] website_event_filter_selector: Don't lose context with new obj
yajo
force-pushed
the
9.0-website_event_filter_selector-mig
branch
2 times, most recently
from
December 22, 2016 13:19
03d8a3f
to
cb25214
Compare
Relicensed to LGPL, new JS API. Add test. Fix errors found with it. Go 100% coverage. Support online events.
yajo
force-pushed
the
9.0-website_event_filter_selector-mig
branch
from
December 23, 2016 12:32
cb25214
to
1e8d662
Compare
Squashed by logical steps. |
pedrobaeza
approved these changes
Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relicensed to LGPL, new JS API.
@Tecnativa