Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0][website_event_filter_selector] Migrate #67

Merged
merged 5 commits into from
Jan 4, 2017

Conversation

yajo
Copy link
Member

@yajo yajo commented Dec 19, 2016

Relicensed to LGPL, new JS API.

@Tecnativa

@pedrobaeza pedrobaeza mentioned this pull request Dec 19, 2016
15 tasks
@yajo yajo force-pushed the 9.0-website_event_filter_selector-mig branch from 05ea132 to 99d67ad Compare December 21, 2016 13:43
@yajo yajo added this to the 9.0 milestone Dec 21, 2016
@yajo
Copy link
Member Author

yajo commented Dec 21, 2016

How I wish to see the new tours system in v10, I keep hitting bugs... This time odoo/odoo#14808.

After all, all should go ✔️ now.

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runbot

@pedrobaeza
Copy link
Member

Travis error I'm afraid

@pedrobaeza
Copy link
Member

Please squash 8.0 commits by author and relevant topic

@yajo yajo force-pushed the 9.0-website_event_filter_selector-mig branch from 4ed0d7e to f171095 Compare December 22, 2016 10:35
yajo and others added 4 commits December 22, 2016 11:37
You can use selectors above the event list in the website, instead of the left column that there is right now.

Store user customizations in separate template.

Acknowledge that you cannot hide only the date filter.

Remove search button; search on selection change.

Fix bug where date did not match what was being filtered.
… countries

This basically fixes OCA#44 and a similar bug detected that would happen when no countries were found.

It just adds a `t-if` to avoid possible failures, [borrowing the idea from core `website_event` module](https://github.com/odoo/odoo/blob/8.0/addons/website_event/views/website_event.xml#L167).
Since this includes new logic, it adds also a template for left-column filters.

With this patch, you can now filter events depending on their cities, not only on their countries.

This also includes some modifications that will make filters occupy always a full bootstrap row, no matter if there are 1, 2, 3 or 4 filters, to avoid ugly layouts.
[IMP] website_event_filter_selector: Spanish translation

[IMP] website_event_filter_selector: German translation

[FIX] website_event_filter_selector: Fix date selection

[FIX] website_event_filter_selector: Fix city count

[FIX] website_event_filter_selector: Don't lose context with new obj
@yajo yajo force-pushed the 9.0-website_event_filter_selector-mig branch 2 times, most recently from 03d8a3f to cb25214 Compare December 22, 2016 13:19
Relicensed to LGPL, new JS API.

Add test. Fix errors found with it.

Go 100% coverage. Support online events.
@yajo yajo force-pushed the 9.0-website_event_filter_selector-mig branch from cb25214 to 1e8d662 Compare December 23, 2016 12:32
@yajo
Copy link
Member Author

yajo commented Dec 27, 2016

Squashed by logical steps.

@pedrobaeza pedrobaeza merged commit 3797fe1 into OCA:9.0 Jan 4, 2017
@yajo yajo deleted the 9.0-website_event_filter_selector-mig branch April 5, 2017 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants