Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [REF] fieldservice_recurring: move rruleset params in methods #1170

Merged

Conversation

renda-dev
Copy link

Small refactor to move the params used in _get_rruleset() in their own methods to increase modularity.

@OCA-git-bot
Copy link
Contributor

Hi @wolfhall, @max3903, @brian10048,
some modules you are maintaining are being modified, check this out!

@max3903 max3903 added this to the 14.0 milestone Apr 3, 2024
@max3903 max3903 self-assigned this Apr 3, 2024
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@max3903
Copy link
Sponsor Member

max3903 commented Apr 3, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1170-by-max3903-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1ae19e8 into OCA:14.0 Apr 3, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0654a3a. Thanks a lot for contributing to OCA. ❤️

@renda-dev renda-dev deleted the 14.0-ref-fieldservice-rruleset-params branch April 4, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants