Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] fieldservice_geoengine: Migration to 17.0 #1190

Open
wants to merge 65 commits into
base: 17.0
Choose a base branch
from

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented May 22, 2024

murtuzasaleh and others added 30 commits May 22, 2024 08:12
minor UI improvements
Currently translated at 77.8% (7 of 9 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_geoengine/es_CL/
Currently translated at 11.1% (1 of 9 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_geoengine/de/
Currently translated at 33.3% (3 of 9 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_geoengine/de/
Currently translated at 55.6% (5 of 9 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_geoengine/pt_BR/
Currently translated at 100.0% (9 of 9 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_geoengine/pt_BR/
Currently translated at 100.0% (9 of 9 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_geoengine/pt_BR/
Currently translated at 100.0% (9 of 9 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_geoengine/es_AR/
Currently translated at 100.0% (9 of 9 strings)

Translation: field-service-12.0/field-service-12.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_geoengine/es_AR/
[IMP] fix travis CI dependency

[IMP] added requirements needed for geospatial

[IMP] added requirements needed for geospatial
oca-ci and others added 18 commits May 22, 2024 08:12
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: field-service-14.0/field-service-14.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_geoengine/
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_geoengine/es_AR/
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_geoengine/it/
this test fails, because the answer of the api has changed
it's not good to fix it that way, but it's quicker.
see discussion on https://github.com/OCA/field-service/pull/1039/files
Currently translated at 100.0% (18 of 18 strings)

Translation: field-service-14.0/field-service-14.0-fieldservice_geoengine
Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_geoengine/es/
@peluko00 peluko00 mentioned this pull request May 22, 2024
46 tasks
@peluko00
Copy link
Contributor Author

peluko00 commented Jun 5, 2024

Hi @sersanchus, i have a problem when enter to map view for a problem with source.

image

The problem is in base_geoengine that we work together but i don't know why is throwing this error. Any idea to solve that?

Thanks in advance

@sersanchus
Copy link

Hi @peluko00,

The error is related to this piece of code not finding any vec layer:

var extent = this.vectorLayersResult .find((res) => res.values_.visible === true) .getSource() .getExtent();

As all openlayers vec layers are visible by default, maybe there aren't any 'geoengine.vector.layer' associated with the geoengine view of your demo. In that case 'getOriginalZoom' has to detect that and use for example an empty extent in taht case:

ol.extent.createEmpty()

@peluko00
Copy link
Contributor Author

peluko00 commented Jun 10, 2024

Hi @peluko00,

The error is related to this piece of code not finding any vec layer:

var extent = this.vectorLayersResult .find((res) => res.values_.visible === true) .getSource() .getExtent();

As all openlayers vec layers are visible by default, maybe there aren't any 'geoengine.vector.layer' associated with the geoengine view of your demo. In that case 'getOriginalZoom' has to detect that and use for example an empty extent in taht case:

ol.extent.createEmpty()

I found the error, is because any of the 'geoengine.vector.layer' hasn't a field called 'active_on_startup' seted to True.
Normally base_geonegine needs one at least.

Many thanks!

@peluko00 peluko00 force-pushed the 17.0-mig-fieldservice_geoengine branch from 23d6b2f to 7016282 Compare June 10, 2024 13:56
Copy link

@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working good, checked in runboat

Copy link

@miquelalzanillas miquelalzanillas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected on runboat.

LGTM!

@max3903
Copy link
Sponsor Member

max3903 commented Jun 17, 2024

/ocabot migration fieldservice_geoengine

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet