[MIG] Migrate hr_employee_phone_extension #112
Conversation
|
Please move the view to views/hr_employee.xml and the hr.py to models/hr_employee.py. |
|
@charbeljc LGTM 👍 Don't forget to add yourself as contributor. |
| @@ -23,7 +23,7 @@ | |||
| from openerp.osv import fields, orm | |||
|
|
|||
|
|
|||
| class hr_employee(orm.Model): | |||
There was a problem hiding this comment.
Can you migrate to new the API? This is a trivial module, so I don't think it is too much to ask.
|
Thanks! 👍 |
|
|
||
|
|
||
|
|
||
| Installation |
There was a problem hiding this comment.
Just remove these sections where there is no useful content to add
|
Some comments/suggestions on the README, but 👍 |
OCA conventions: add README.rst, fix import
|
@dreispt, README.rst cleaned up, PR rebased. |
| * internal_number | ||
| * short_number | ||
|
|
||
| Bugs are tracked on `GitHub Issues <https://github.com/OCA/hr/issues>`_. |
There was a problem hiding this comment.
Why remove Bug tracker title?
|
update |
| @@ -20,4 +20,4 @@ | |||
| # | |||
| ############################################################################## | |||
|
|
|||
| from . import hr | |||
| from .models import hr_employee | |||
There was a problem hiding this comment.
I am not sure, but I think it is better to set :
from . import models
|
a little remark but 👍 |
| ], | ||
| 'demo': [], | ||
| 'test': [], | ||
| 'installable': False, | ||
| 'installable': True, | ||
| 'auto_install': False, | ||
| 'images': [], |
There was a problem hiding this comment.
images key is deprecated
|
👍 |
[MIG] Migrate hr_employee_phone_extension
[BSSFL-214] Setup test admin password
No description provided.