Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] Migrate hr_employee_phone_extension #112

Merged
merged 15 commits into from
Aug 12, 2015
46 changes: 46 additions & 0 deletions hr_employee_phone_extension/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
:alt: License: AGPL-3

Employee Phone Extension
========================

This module adds the following to employees :

* internal_number
* short_number

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/hr/issues>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove Bug tracker title?

In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us smashing it by providing a detailed and welcomed feedback
`here <https://github.com/OCA/hr/issues/new?body=module:%20hr_employee_phone_extension%0Aversion:%208.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you replace {...} by the real value ?


Credits
=======

Contributors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also Credits title?

------------

* Sandy Carter <sandy.carter@savoirfairelinux.com>
* El Hadji Dem <elhadji.dem@savoirfairelinux.com>
* Vincent Renaville <vincent.renaville@camptocamp.com>
* Charbel Jacquin <charbel.jacquin@camptocamp.com>


Maintainer
----------

.. image:: https://odoo-community.org/logo.png
:alt: Odoo Community Association
:target: https://odoo-community.org

This module is maintained by the OCA.

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

To contribute to this module, please visit http://odoo-community.org.
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@
#
##############################################################################

from . import hr
from . import models
Original file line number Diff line number Diff line change
Expand Up @@ -24,30 +24,15 @@
'name': 'Employee Phone Extension',
'version': '1.0',
'category': 'Human Resources',
'description': """
Employee Phone Extension
========================
This module adds the following to employees :
* internal_number
* short_number
Contributors
------------
* Sandy Carter (sandy.carter@savoirfairelinux.com)
* El Hadji Dem (elhadji.dem@savoirfairelinux.com)
""",
'author': "Savoir-faire Linux,Odoo Community Association (OCA)",
'website': 'http://www.savoirfairelinux.com',
'license': 'AGPL-3',
'depends': ['hr', ],
'data': [
'hr_view.xml',
'views/hr_employee_view.xml',
],
'demo': [],
'test': [],
'installable': False,
'installable': True,
'auto_install': False,
'images': [],
}
3 changes: 3 additions & 0 deletions hr_employee_phone_extension/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#! -*- coding: utf-8 -*-

from . import hr_employee
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,13 @@
#
##############################################################################

from openerp.osv import fields, orm
from openerp import models, fields


class hr_employee(orm.Model):
class HrEmployee(models.Model):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you migrate to new the API? This is a trivial module, so I don't think it is too much to ask.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @StefanRijnhart, done.

_inherit = 'hr.employee'

_columns = {
'internal_number': fields.char('Internal Number', size=20,
help='Internal phone number.'),
'short_number': fields.char('Short Number', size=20,
help='Short phone number.'),
}
internal_number = fields.Char('Internal Number', size=20,
help='Internal phone number.')
short_number = fields.Char('Short Number', size=20,
help='Short phone number.')