hr_worked_days_from_timesheet migrate and re-factored to Odoo 8.0 #189
Conversation
|
Hello, I don't understand the travis fail, in the my test repository, pass all test. Greetings |
| wd_model = self.env['hr.payslip.worked_days'] | ||
| for ts_sheet in timesheet_sheets: | ||
| # Get formated date from the timesheet sheet | ||
| date_from_formated = datetime.strptime( |
There was a problem hiding this comment.
You could use fields.Datetime.from_string and fields.Date.to_string functions available in new api.
|
Hello, Changes done. Greetings |
| 'website': 'https://www.savoirfairelinux.com/', | ||
| 'depends': [ | ||
| 'hr_payroll', | ||
| 'hr_timesheet_sheet', | ||
| ], | ||
| 'data': [ | ||
| 'hr_payslip_view.xml' | ||
| 'views/hr_payslip_view.xml' | ||
| ], | ||
| 'test': [ | ||
| 'test/worked_days_from_timesheet_test.yml' | ||
| ], | ||
| 'demo': [], |
There was a problem hiding this comment.
Please remove empty key: demo
|
Any news on this? May i offer help to finish it? |
|
Hello, I need to pass to test to unittest to finish it. Greetings |
|
@acysos I have added unittest for this module. I created PR to your branch (https://github.com/acysos/hr/tree/8.0-hr_worked_days_from_timesheet) and OCA/hr ( #201 ) just to test. There are some errors but i think it's not related to this module |
2. Change Warning into UserError
|
@acysos i need this module migrated to 8.0 soon and willing to finish your work. May i offer help to finish this? I will create new PR for this module and retain commit history from your work. Any thought @feketemihai @dufresnedavid @dreispt @max3903 ? |
|
@andhit-r The module is working, I have in one of my clients. I have merge you PR. Thank you |
|
Thanks @acysos. Travis and runbot still failing though. It seems cause by test on partner_firstname module. Anyone could give advice to make both test green? |
|
That are solved in #194 but there are not merged yet... |
|
@acysos @dufresnedavid @dreispt I have confirmed @feketemihai latest comment. #194 will solve travis issues, and hopefully runbot. Would someone review #194 ? |
|
@feketemihai The merge is to the OCA principal branch, so I can't merge it. I can add the changes to this branch or you can send a PR. |
|
Any news on this? |
|
Closed since work will continue in #218 . |
[8.0][hr_worked_days_from_timesheet] Update from #189. Rebased + Squash
[BSSFL-293] Add purchase order date confirmed
add mailchimp3 lib as requirement
Hello,
I have migrate and re-factored this module. Less code and improved for inherit.
Greetings,
Ignacio Ibeas