Update split names at module install to get the value not the key of the dict #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@feketemihai I rebased #189 on top of this PR. Travis check passed. So 👍 |
|
@OCA/human-resources-maintainers Can you review this, it's raising error depending on the order the modules are installed. |
sambarros
pushed a commit
to sambarros/hr
that referenced
this pull request
Jul 26, 2018
[BSSFL-106] Bill of Materials
Mraimou
pushed a commit
to camptocamp/hr
that referenced
this pull request
Nov 25, 2019
…update_wizard [BSIBSO-1061] Install account_invoice_update_wizard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At install of the module, the auto_init is launching the split_name script, which splits the name of the employee in firstname and lastname, but the method gets the key of the dict, not the value returned.
This fix is for getting the value and not the key from the dict, just like the test pr for this module.