Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][8.0] hr payroll cancel #248

Merged
merged 35 commits into from
Aug 6, 2016
Merged

Conversation

AaronHForgeFlow
Copy link

@AaronHForgeFlow AaronHForgeFlow commented Jul 22, 2016

Cancel a payslip

This module introduces the following features:

  • The module payroll_cancel allows the user to cancel a payslip whatever the previous state is.

Installation

No special needs.

Configuration

No extra configuration needed.

Usage

  1. Go to the payslip list and select the one you want to cancel.
  2. Click on the button "Cancel payslip". The payslip is now rejected.
  3. To accept this payslip again, click on "set to draft" button.

If there’s a refund for a payslip the user should not cancel the entry because the refund would still be confirm. In that case, the user have either to confirm again the payslip or cancel the refund.

Jose Morales and others added 30 commits February 27, 2014 16:58
…mail model can help us in this but this model won't show us each change in each field, specialty with *2many fields is why that We overwrite the write metho to show with details each change

(../last_a_v_72/ rev 968)
…e mail model can help us in this but this model won't show us each change in each field, specialty with *2many fields is why that We overwrite the write metho to show with details each change
  [MERGE] Set standard in all __openerp__.py files
  Take-this to 
  portal_crm_vauxoo/__openerp__.py
  portal_user_story/__openerp__.py
  project_conf/__openerp__.py
  sprint_kanban/__openerp__.py
  stock_purchase_expiry/__openerp__.py
  web_captcha/__openerp__.py
  web_vauxoo_cust/__openerp__.py
…t the README.md

description an a predefined module descriptor footer (Footer includes an
image with Vauxoo Large Logo.

This was created using an script Vauxoo/gist-vauxoo/description2html.
…xoo Logo.

This was apply using the script Vauxoo/gist-vauxoo/description2html.
…ence.

[IMP] .version.py now works with ReGex
…hat odoo apps refresh the new index.html description
…3-kty

Conflicts:
	account_invoice_number/__openerp__.py
	account_invoice_tax/__openerp__.py
	invoice_date_time/__openerp__.py
	invoice_date_time/static/description/index.html
	product_category_multicompany/__openerp__.py
@AaronHForgeFlow
Copy link
Author

All last changes proposed by @moylop260 and @andhit-r done. Thank you all.

@andhit-r
Copy link
Member

andhit-r commented Jul 23, 2016

Functionality tested on runbot. 👍 You just need to increase coverage to pass coveralls check.

@AaronHForgeFlow
Copy link
Author

Thank you @andhit-r How can I Increase coverage? Should I create a test for the hook?

@moylop260
Copy link

I will merge this PR with a squash in order to avoid a break for the CLA of our employees.
(After a plus one more)

@andhit-r
Copy link
Member

From what i read on other modules:

  1. mass_mailing_unique (https://github.com/OCA/social/tree/8.0/mass_mailing_unique)
  2. letsencrypt (https://github.com/OCA/server-tools/tree/8.0/letsencrypt)

post_init_hook should be run automatically without unittest. I might out of my depth here. @OCA/human-resources-maintainers need some opnion here. Many thanks.

@dreispt
Copy link
Sponsor Member

dreispt commented Jul 26, 2016

@andhit-r Yes - unittests not stricly needed, since it is expected to run on install.
The problem is that it's not running.
I think the init hooks are missing from the __openerp__.py file.

@andhit-r
Copy link
Member

@dreispt thank you for your explanation.

@AaronHForgeFlow
Copy link
Author

Thanks a lot @dreispt @andhit-r

mission is to support the collaborative development of Odoo features and
promote its widespread use.

To contribute to this module, please visit https://odoo-community.org.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline please

@moylop260
Copy link

@dreispt @pedrobaeza Are you agree with this pr?

@oscarolar
Copy link

👍

@moylop260 moylop260 merged commit fd5f360 into OCA:8.0 Aug 6, 2016
LoisRForgeFlow pushed a commit to ForgeFlow/hr that referenced this pull request Mar 29, 2017
Allows the user to cancel a payslip whatever the previous state is.
AaronHForgeFlow added a commit to ForgeFlow/hr that referenced this pull request Aug 1, 2017
Allows the user to cancel a payslip whatever the previous state is.
nikul-serpentcs pushed a commit to nikul-serpentcs/hr that referenced this pull request Aug 4, 2017
Allows the user to cancel a payslip whatever the previous state is.
nikul-serpentcs pushed a commit to nikul-serpentcs/hr that referenced this pull request Jan 22, 2018
Allows the user to cancel a payslip whatever the previous state is.
novawish pushed a commit to novawish/hr that referenced this pull request Apr 3, 2018
Allows the user to cancel a payslip whatever the previous state is.
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
[BSSFL-356] Add stock-logistics-warehouse in Dockerfile
nikul-serpentcs pushed a commit to nikul-serpentcs/hr that referenced this pull request Dec 22, 2018
Allows the user to cancel a payslip whatever the previous state is.
i-vyshnevska pushed a commit to i-vyshnevska/hr that referenced this pull request Mar 5, 2019
Allows the user to cancel a payslip whatever the previous state is.
i-vyshnevska pushed a commit to i-vyshnevska/hr that referenced this pull request Mar 12, 2019
Allows the user to cancel a payslip whatever the previous state is.
@oca-clabot
Copy link

Hey @aheficent,
We acknowledge that the following users have signed our Contributor License Agreement:

Appreciation of efforts,
OCA CLAbot

quentingigon pushed a commit to quentingigon/hr that referenced this pull request Oct 11, 2019
Allows the user to cancel a payslip whatever the previous state is.
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
* Revert "fix migration"

This reverts commit 7867feb.

* Fix migration 10.17.0

Force the drop of specific_crm.assets_backend view after its move to bso_telephony module.

This view was moved from specific_crm module to bso_telephony on fe5de79 (OCA#248)
The module specific_crm is updated so the view should have been dropped at update but somehow it did not happen.
Therefore when installing bso_telephony we got the error that the "XML element cannot be located in parent view"
and we did an hotfix on the xpath expression on 7867feb.
However doing this did remove form_widgets.js from web module instead of the web_enterprise one we wanted to get
rid of in the first place, and we tought it fixes the error, whereas this did break the web client.

closes OCA#252

* fix travis crash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.