[WIP] 9.0 migration of hr_holidays_legal_leave #267
Conversation
gurneyalex
force-pushed
the
9.0-mig_hr_holidays_legal_leave
branch
from
967626c
to
854038f
Compare
|
@damdam-s @gurneyalex Thank for update the module, can i ask to update readme, since the HR config isn't there anymore with the text from version 10. Configuration To configure this module, you need to: Company setup * Go to the company and select the leave type to use as legal leave with Configuration To configure this module, you need to: assign legal leave type via Leaves > Configuration: |
|
@feketemihai no problem. I do it right now |
|
👍 |
| class HolidaysType(models.Model): | ||
| _inherit = "hr.holidays.status" | ||
|
|
||
| is_annual = fields.Boolean( |
There was a problem hiding this comment.
Although I know this is what is now in v10, I'm seeing that this is not comfortable for user with access to several companies. We should have a company_id field that is filled by default with user company, but with the possibility to be switched. This is similar to Accounting settings.
There was a problem hiding this comment.
@pedrobaeza you're right (I think) but is it correct to have a different behaviour between 9 and 10 versions ?
If you want me to do it, I can but I will make a PR on v10 too to have the same behaviour.
There was a problem hiding this comment.
Yes, please. I think it's a good change. We can cherry-pick the commit directly in v10 when done in v9.
There was a problem hiding this comment.
@pedrobaeza done in df9830f. Is it what you wanted ?
|
great! thanks |
|
Ouch, it lacks the company_id field in the view. I'll add it directly |
|
aww sorry for that :( |
|
I have include both commits in v10, cc @yelizariev |
No description provided.