[WIP] 9.0 migration of hr_holidays_legal_leave

hr_holidays_legal_leave/README.rst

@@ -14,7 +14,7 @@ set leaves from the employee form.
 Installation
 ============
 
-* clone the branch 8.0 of the repository https://github.com/OCA/hr
+* clone the branch 9.0 of the repository https://github.com/OCA/hr
 * add the path to this repository in your configuration (addons-path)
 * update the module list
 * search for "HR Holidays Legal Leave" in your addons
@@ -25,8 +25,11 @@ Configuration
 
 To configure this module, you need to:
 
-Company setup
-* Go to the company and select the leave type to use as legal leave
+* assign legal leave type via Leaves > Configuration:
+    - choose Leave type you need
+    - click [Edit]
+    - set Legal/Annual checkbox
+    - click [Save]
 
 HR Module Setup
 * Assign legal leave type via Settings > Human Resources
@@ -36,7 +39,7 @@ Usage
 
 .. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
    :alt: Try me on Runbot
-   :target: https://runbot.odoo-community.org/runbot/116/8.0
+   :target: https://runbot.odoo-community.org/runbot/116/9.0
 
 Known issues / Roadmap
 ======================
@@ -67,6 +70,9 @@ Contributors
 
 * Salton Massally <smassally@idtlabs.sl>
 * Fekete Mihai <feketemihai@gmail.com>
+* Ivan Yelizariev <yelizariev@it-projects.info>
+* Bassirou Ndaw <b.ndaw@ergobit.org>
+* Alexandre Fayolle <alexandre.fayolle@camptocamp.com>
 
 Maintainer
 ----------

hr_holidays_legal_leave/__openerp__.py

@@ -4,7 +4,7 @@
 
 {
     'name': 'HR Holidays Legal Leave',
-    'version': '8.0.1.0.0',
+    'version': '9.0.1.0.0',
     'category': 'Human Resources',
     'license': 'AGPL-3',
     'summary': 'Allows the definition of legal/annual leave',
@@ -13,8 +13,7 @@
     'website': 'http://idtlabs.sl',
     'depends': ['hr_holidays'],
     'data': [
-        'views/res_config.xml',
-        'views/res_company.xml',
+        'views/hr_holidays_status.xml',
     ],
-    'installable': False,
+    'installable': True,
 }

hr_holidays_legal_leave/models/__init__.py

@@ -2,6 +2,6 @@
 # ©  2015 iDT LABS (http://www.@idtlabs.sl)
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
-from . import res_config
-from . import res_company
+from . import hr_holidays_status
 from . import hr_employee
+from . import res_company

hr_holidays_legal_leave/models/hr_employee.py

@@ -3,7 +3,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 
 from openerp import models, api, fields, _
-from openerp.exceptions import Warning as UserError
+from openerp.exceptions import UserError
 
 
 class HrEmployee(models.Model):
@@ -38,13 +38,13 @@ def _inverse_remaining_days(self):
 
     @api.multi
     def _compute_remaining_days(self):
-        self.ensure_one()
-        legal_leave = self.company_id.legal_holidays_status_id
-        if not legal_leave:
-            raise UserError(_('Legal/annual leave type is not defined for '
-                              'your company.'))
-        self.remaining_leaves = legal_leave.get_days(
-            self.id)[legal_leave.id]['remaining_leaves']
+        for rec in self:
+            legal_leave = rec.company_id.legal_holidays_status_id
+            if not legal_leave:
+                raise UserError(_('Legal/annual leave type is not defined for '
+                                  'your company.'))
+            rec.remaining_leaves = legal_leave.get_days(
+                rec.id)[legal_leave.id]['remaining_leaves']
 
     remaining_leaves = fields.Integer(
         'Remaining Legal Leaves',

hr_holidays_legal_leave/models/hr_holidays_status.py

@@ -0,0 +1,30 @@
+# -*- coding: utf-8 -*-
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+from openerp import fields, models, api
+
+
+class HolidaysType(models.Model):
+    _inherit = "hr.holidays.status"
+
+    is_annual = fields.Boolean(
+        'Legal/Annual',
+        compute='_compute_is_annual',
+        inverse='_inverse_is_annual',
+        help='Use this Leave type as Legal/Annual for current company. '
+             'One and only one leave type can have this checkbox. '
+             'You cannot unset it directly. '
+             'Set it on another Leave type instead. '
+    )
+
+    @api.multi
+    def _compute_is_annual(self):
+        company = self.env.user.company_id
+        self.filtered(lambda x: x == company.legal_holidays_status_id)\
+            .update({'is_annual': True})
+
+    @api.multi
+    def _inverse_is_annual(self):
+        self.ensure_one()
+        company = self.env.user.company_id
+        if self.is_annual:
+            company.legal_holidays_status_id = self.id

hr_holidays_legal_leave/views/hr_holidays_status.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <record id="edit_holiday_status_form" model="ir.ui.view">
+        <field name="name">hr.holidays.status.form</field>
+        <field name="model">hr.holidays.status</field>
+        <field name="inherit_id" ref="hr_holidays.edit_holiday_status_form" />
+        <field name="arch" type="xml">
+            <xpath expr="//field[@name='name']"
+                    position="after">
+                <field name="is_annual" />
+            </xpath>
+        </field>
+    </record>
+</odoo>