Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] MIG hr_skill #299

Merged
merged 5 commits into from
Sep 12, 2017
Merged

[9.0] MIG hr_skill #299

merged 5 commits into from
Sep 12, 2017

Conversation

nicomacr
Copy link

No description provided.

@pedrobaeza pedrobaeza mentioned this pull request Nov 25, 2016
65 tasks
@nicomacr
Copy link
Author

Any comments from this PR?

@feketemihai feketemihai added this to the 9.0 milestone Feb 23, 2017
Copy link
Member

@feketemihai feketemihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicomacr Can you add yourself in the Contributors list, and please add @yweng8111 since you made the same update in different PR's...

@nicomacr Can you review other .py file small headers...

@@ -20,7 +20,7 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicomacr Thanks for your contribution, can you please adapt small headers

@feketemihai
Copy link
Member

@nicomacr Also, can you add a widget="many2many_tags" in the employee form, for quick add and also for not showing other employees that have the same skill...

@feketemihai
Copy link
Member

@nicomacr Please update also .py files with small headers...

@@ -35,7 +35,7 @@
<!-- Menu and Actions -->

<menuitem name="Skills Management"
parent="hr.menu_hr_configuration"
parent="hr.menu_human_resources_configuration"
id="menu_hr_skill_mgt"/>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicomacr Can you update the menus, i don't think the Skill Structure is needed, since you have the childs on each skill, the name is computed from all parents, also you can remove the Skill Management parent menu, only to leave the Skills menu in the configuration...

Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feketemihai feketemihai merged commit 6f5dbb8 into OCA:9.0 Sep 12, 2017
@nicomacr nicomacr deleted the 9.0-mig-hr_skill branch September 28, 2017 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants