-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0] MIG hr_skill #299
[9.0] MIG hr_skill #299
Conversation
Any comments from this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicomacr Can you add yourself in the Contributors list, and please add @yweng8111 since you made the same update in different PR's...
@nicomacr Can you review other .py file small headers...
hr_skill/__openerp__.py
Outdated
@@ -20,7 +20,7 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicomacr Thanks for your contribution, can you please adapt small headers
@nicomacr Also, can you add a widget="many2many_tags" in the employee form, for quick add and also for not showing other employees that have the same skill... |
@nicomacr Please update also .py files with small headers... |
hr_skill/views/hr_skill.xml
Outdated
@@ -35,7 +35,7 @@ | |||
<!-- Menu and Actions --> | |||
|
|||
<menuitem name="Skills Management" | |||
parent="hr.menu_hr_configuration" | |||
parent="hr.menu_human_resources_configuration" | |||
id="menu_hr_skill_mgt"/> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicomacr Can you update the menus, i don't think the Skill Structure is needed, since you have the childs on each skill, the name is computed from all parents, also you can remove the Skill Management parent menu, only to leave the Skills menu in the configuration...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.