Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port module hr_skill for odoo v9 #310

Closed
wants to merge 2 commits into from

Conversation

yweng8111
Copy link

No description provided.

Copy link

@jcdrubay jcdrubay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I reviewed some code of the module; already in api-v8
All tests green 👍

@yweng8111
Copy link
Author

yweng8111 commented Jan 17, 2017

Thanks for the quick review. Can you tell me when will these commits be merged to branch "9.0". I want push some more commits for other hr modules, which is depend on this module.

@jcdrubay
Copy link

@jlaloux
Copy link

jlaloux commented Jan 25, 2017

Duplicated PR? #299

Am i wrong?

@yweng8111
Copy link
Author

You are right. Sorry, I have not seen the old PR and just checkout the branch 9.0. That Commit was not merged.

@feketemihai
Copy link
Member

@yweng8111 Thanks for your contribution, but i will have to close this one, since the module was already in a PR.
@jcdrubay @jlaloux Since there was #299 we will continue on that.

sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
[BSSFL-272] Update res.company - Cutoff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants