[Add] [10.0] hr_employee_social_media #317
Conversation
leemannd
force-pushed
the
add-hr_social_media
branch
from
127dfd0
to
ced9631
Compare
leemannd
changed the title
|
@feketemihai Hello, I'll gladly fix the PR. Did you forget to put a comment? |
There was a problem hiding this comment.
I put one direct on the readme file...check it again...
Thanks for the contribution, nice module, but i think we should make it more usefull, adding a model hr.employee.social.media.sites with the name of the site(network, eg. Skype, Facebook,...), a new model that links employee with social media sites and add their account name, by this we are letting people adding the one that they want...beside skype, twitter, whatsapp, there are a lot of other social media network theat people are used to...
| @@ -0,0 +1,44 @@ | |||
| .. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg | |||
There was a problem hiding this comment.
@leemannd Thanks for the contribution, nice module, but i think we should make it more usefull, adding a model hr.employee.social.media.sites with the name of the site(network, eg. Skype, Facebook,...), a new model that links employee with social media sites and add their account name, by this we are letting people adding the one that they want...beside skype, twitter, whatsapp, there are a lot of other social media network theat people are used to...
There was a problem hiding this comment.
@feketemihai Thanks for the comment. I agree, it could be more usefull in your way.
There was a problem hiding this comment.
@feketemihai I've updated it following your comments. You'll find a first draft to review.
leemannd
force-pushed
the
add-hr_social_media
branch
2 times, most recently
from
3da6b13
to
873759d
Compare
|
N.B: Data file is going to be updated to have a sample. |
| name = fields.Char( | ||
| string='Name', | ||
| ) | ||
| website = fields.Char( |
There was a problem hiding this comment.
pls, do not use "website" as field name. It can collide many times. Be more explicit and use something like "social_url".
There was a problem hiding this comment.
@simahawk Updated. & added small sample data
leemannd
force-pushed
the
add-hr_social_media
branch
4 times, most recently
from
f63aea8
to
63d9958
Compare
| <xpath expr="//page[@name='public']/group" position="inside"> | ||
| <group name="social_media" string="Social Media Accounts"> | ||
| <field name="social_media_account_ids" nolabel="1"> | ||
| <tree> |
There was a problem hiding this comment.
@leemannd Can you add an editable="bottom" on the tree, even specified only the tree view, it still open the form view...and on the form view it shows the employee Null, so you can assign from one employee a social media account for other employee...
leemannd
force-pushed
the
add-hr_social_media
branch
from
63d9958
to
45e93fa
Compare
leemannd
force-pushed
the
add-hr_social_media
branch
from
45e93fa
to
30bb94b
Compare
|
@gurneyalex @feketemihai Hello, Thanks for your feedback. It has been updated |
|
@leemannd @gurneyalex The PR is ok, but i am wondering, should we leave the Social Media Accounts on the Public Info tab, or we should move them to Personal Info tab... |
|
@feketemihai Could also be a new separate page. |
[BSSFL-436] Sale order type
The main goal of this module is to have a list of the employee's social media
and social communication tools.
This module add the following to Employee: