Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] hr_expense_invoice: Migration to 10.0 #367

Merged
merged 3 commits into from
Nov 10, 2017
Merged

[MIG] hr_expense_invoice: Migration to 10.0 #367

merged 3 commits into from
Nov 10, 2017

Conversation

cubells
Copy link
Sponsor Member

@cubells cubells commented Sep 27, 2017

  • Update README
  • Update views
  • Update file structure
  • Add tests

cc @Tecnativa

kryskool and others added 2 commits September 25, 2017 17:32
@kryskool @cubells
[FIX] Fix issue with 2 invoices on the same partner and the same tota…
875140c 
…l amount (OCA#237)

On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible.

The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
@oca-transbot @cubells
OCA Transbot updated translations from Transifex
8fa0bf6
pedrobaeza
pedrobaeza reviewed Sep 28, 2017
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a migration script (it will depend on how the hr_expense migration script is made)?

@cubells
Copy link
Sponsor Member Author

cubells commented Sep 28, 2017

Yes, we do.

@pedrobaeza
Copy link
Member

Please do it then.

chienandalu
chienandalu reviewed Oct 2, 2017
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one doubt: when you add a expense line and select or create an invoice, shouldn't the product field be automatically set if possible?

gurneyalex
gurneyalex approved these changes Oct 2, 2017
View reviewed changes
hr_expense_invoice/tests/test_hr_expense_invoice.py Outdated
from odoo.tests import common


class TestCrmClaim(common.SavepointCase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rename the class?

leemannd
leemannd approved these changes Oct 2, 2017
View reviewed changes
Copy link

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@cubells
Copy link
Sponsor Member Author

cubells commented Oct 2, 2017

@chienandalu
Invoice can have a lot of lines.
By selecting invoice you are setting total_amount with residual_amount of invoice.

I prefer my solution: user can set his own product.

@cubells
Copy link
Sponsor Member Author

cubells commented Oct 2, 2017

@gurneyalex done.

@gurneyalex gurneyalex added this to the 10.0 milestone Oct 2, 2017
@pedrobaeza
Copy link
Member

Please squash your last 2 commits.

@pedrobaeza pedrobaeza mentioned this pull request Oct 30, 2017
Closed
feketemihai
feketemihai approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@feketemihai feketemihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested...

@pedrobaeza pedrobaeza merged commit ee96201 into OCA:10.0 Nov 10, 2017
@pedrobaeza pedrobaeza deleted the 10.0-mig-hr_expense_invoice branch November 10, 2017 08:57
@pedrobaeza pedrobaeza mentioned this pull request Nov 10, 2017
Closed
58 tasks
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
Merge pull request OCA#367 from TelmoSenseFly/BSSFL-497
d115b4e 
[BSSFL-497] DN / Invoice Totals
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Jan 30, 2020
merge OCA#367 sh_supplier_dispute
4b2384b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu left review comments

@pedrobaeza pedrobaeza pedrobaeza left review comments

@gurneyalex gurneyalex gurneyalex approved these changes

@leemannd leemannd leemannd approved these changes

@feketemihai feketemihai feketemihai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cubells @pedrobaeza @gurneyalex @leemannd @chienandalu @feketemihai @kryskool @oca-transbot