[FIX] Fix issue with 2 invoices on the same partner and the same total amount #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kryskool thanks for the contribution. Could you add a unit test to cover this bug? |
gurneyalex
approved these changes
Oct 17, 2016
cubells
pushed a commit
to Tecnativa/hr
that referenced
this pull request
Sep 27, 2017
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
feketemihai
pushed a commit
to feketemihai/hr
that referenced
this pull request
Nov 14, 2017
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
nikul-serpentcs
pushed a commit
to nikul-serpentcs/hr
that referenced
this pull request
Jan 20, 2018
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
nikul-serpentcs
pushed a commit
to nikul-serpentcs/hr
that referenced
this pull request
Jan 20, 2018
Fix _onchange_employee() arguments OCA Transbot updated translations from Transifex OCA Transbot updated translations from Transifex [fix] `hr_employee_id` use deprecated `sequence.get_id()` (OCA#358) [add] hr_employee_address_improved (OCA#357) [ADD] hr_employee_category_parent (OCA#366) * [ADD] hr_employee_category_parent * [IMP] human readable name [UPD] addons table in README.md [ADD] setup.py [ADD] hr_holiday_notify_employee_manager: Notify by mail the manager of the employee requesting the leave. (OCA#331) OCA Transbot updated translations from Transifex [MIG] hr_holidays_notify_employee_manager: Migration to 10.0 [10.0][ADD] hr_holidays_settings [FIX] add company_id in view hr_worked_days_from_timesheet OCA Transbot updated translations from Transifex [ADD] hr_worked_days_from_timesheet v10 [IMP] Improved code [IMP] Improved code [MIG] hr_employee_legacy_id [FIX] update header [UPD] addons table in README.md [ADD] setup.py [MIG] 10.0 porting hr_skill [UPD] Move Skills menu into HR configuration and add widget m2m_tags in employee form view and add to contributors list [UPD] Update copyright [IMP] Add unit test to test nam_get function on hr_skill Refactor code for pep-8 Add group to Skill menu Fix imports & lost things in pull/300 [UPD] addons table in README.md [ADD] setup.py [MIG][9.0] hr_expense_analytic_plans module OCA Transbot updated translations from Transifex [MIG] hr_expense_analytic_distribution: Migration to 10.0 [REM] hr_expense_analytic_plans: Replaced by hr_expense_analytic_distribution [UPD] addons table in README.md [ADD] setup.py [FIX] Fix issue with 2 invoices on the same partner and the same total amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first. OCA Transbot updated translations from Transifex [MIG] hr_expense_invoice: Migration to 10.0 [UPD] addons table in README.md [ADD] setup.py Update view in holidays status, to remove duplicated field on company_id. (OCA#405) [FIX][hr_holidays_settings] Make 'Leave Types' view accessible (OCA#408) [MIG] hr_holidays_meeting_name (OCA#334) * Add hr_holidays_meeting_name module * Typo * [MIG] hr_holidays_meeting_name * [CHG] According upstream changes. * [CHG] Rewrite hr_holidays_meeting_name witout Odoo patch. Add tests. * [CHG] Ignore .eggs directory. [UPD] addons table in README.md OCA Transbot updated translations from Transifex [FIX] hr_employee_seniority permission problem normally hr.contract are only readable by Employee / Officer and Employee / Managers, not basic employees => we need compute_sudo to compute the employee's seniority otherwise the employee cannot display his own record. [FIX] employee seniority tests [UPD] addons table in README.md [FIX] holiday meeting name tests Change the date to avoid conflicts with the demo data of hr_holidays. [IMP] hr_public_holidays: Improve README [FIX] employee seniority search crash [imp] hr_employee_id: ease override w/ custom ID [UPD] addons table in README.md
cubells
pushed a commit
to Tecnativa/hr
that referenced
this pull request
Dec 11, 2018
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
pedrobaeza
pushed a commit
to Tecnativa/hr
that referenced
this pull request
Dec 13, 2018
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
hhgabelgaard
pushed a commit
to steingabelgaard/hr
that referenced
this pull request
Dec 30, 2018
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
i-vyshnevska
pushed a commit
to i-vyshnevska/hr
that referenced
this pull request
Mar 5, 2019
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
i-vyshnevska
pushed a commit
to i-vyshnevska/hr
that referenced
this pull request
Mar 12, 2019
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
quentingigon
pushed a commit
to quentingigon/hr
that referenced
this pull request
Oct 11, 2019
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
kongrattapong
pushed a commit
to kongrattapong/hr
that referenced
this pull request
Oct 17, 2019
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
kongrattapong
pushed a commit
to kongrattapong/hr
that referenced
this pull request
Oct 17, 2019
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
kongrattapong
pushed a commit
to ecosoft-odoo/hr
that referenced
this pull request
Oct 31, 2019
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
Saran440
pushed a commit
to ecosoft-odoo/hr
that referenced
this pull request
Nov 17, 2019
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
Mraimou
pushed a commit
to camptocamp/hr
that referenced
this pull request
Nov 25, 2019
[FIX] Invoice update wizard not updating analytic account BSIBSO-1072
Saran440
pushed a commit
to ecosoft-odoo/hr
that referenced
this pull request
Dec 5, 2019
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
Saran440
pushed a commit
to ecosoft-odoo/hr
that referenced
this pull request
Dec 5, 2019
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
Saran440
pushed a commit
to ecosoft-odoo/hr
that referenced
this pull request
Dec 5, 2019
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
pedrobaeza
pushed a commit
to Tecnativa/hr
that referenced
this pull request
Mar 22, 2021
…l amount (OCA#237) On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible. The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the same expense, when we have 2 or more lines with differents invoices, and each invoices have the same total amount, reconcile is not possible.
The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.