-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] Migrating hr_skill to Odoo 11.0 #375
Conversation
You need to follow migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0 |
The module has been merged on 10.0, so you can apply the migration guide now |
@feketemihai @pedrobaeza Thanks for reminding me |
…nstead on the form
[IMP] use "Name" instead "Display Name" in skill tree view
[UPD] Move Skills menu into HR configuration and add widget m2m_tags in employee form view and add to contributors list [UPD] Update copyright [IMP] Add unit test to test nam_get function on hr_skill Refactor code for pep-8 Add group to Skill menu
b87e760
to
5f68bac
Compare
Hey @novawish, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
name = fields.Char(string='Name', required=True, translate=True) | ||
active = fields.Boolean(string='Active', default=True) | ||
parent_id = fields.Many2one(comodel_name='hr.skill', | ||
string='Parent', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should format style code!
https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#models
"website": "http://www.savoirfairelinux.com", | ||
"depends": ["hr"], | ||
'data': [ | ||
"views/hr_skill.xml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better if we sort by Alphabet
biz-1417 Update sumbodule
Migrate module hr_skill to Odoo 11.0