Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][10.0]Fix jlaloux migration hr skill #378

Merged
merged 2 commits into from
Oct 12, 2017

Conversation

leemannd
Copy link

@leemannd leemannd commented Oct 9, 2017

As #300 wasn't going further even with calls to the author (and there is probably a wrong rebase).
I cherry-picked his commits done in hr_skill.
N.B: I added a change that dissapeard from his PR

Todo

  • Test it at least the 12.10.17

@leemannd leemannd changed the title Fix jlaloux migration hr skill [ADD][10.0]Fix jlaloux migration hr skill Oct 9, 2017
Copy link
Member

@feketemihai feketemihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but seems ok..

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits from other author for merging this

jlaloux and others added 2 commits October 12, 2017 12:11
[UPD] Move Skills menu into HR configuration and add widget m2m_tags in employee form view and add to contributors list

[UPD] Update copyright

[IMP] Add unit test to test nam_get function on hr_skill

Refactor code for pep-8

Add group to Skill menu
@leemannd leemannd force-pushed the fix-jlaloux-migration_hr_skill branch from 5e16b5d to ae5699d Compare October 12, 2017 10:11
@leemannd
Copy link
Author

@pedrobaeza Squashed. :)

@pedrobaeza pedrobaeza merged commit 2b1fe8c into OCA:10.0 Oct 12, 2017
@leemannd leemannd deleted the fix-jlaloux-migration_hr_skill branch October 12, 2017 14:08
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
[BSSFL-506] Fix report Sale order / Invoice contact layout
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants