[MIG] hr_salary_rule_reference: Migration to 11.0 #384

novawish · 2017-10-11T13:08:58Z

No description provided.

pedrobaeza · 2017-10-12T10:30:20Z

Please follow migration guide for keeping commit history: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

novawish · 2017-10-15T17:02:10Z

@pedrobaeza Done, thanks for guiding me :)

pedrobaeza · 2017-10-15T22:13:09Z

hr_salary_rule_reference/README.rst


+* Komit https://komit-consulting.com


Funders is for external companies (your customers, for example)

feketemihai

Not tested...

feketemihai · 2018-03-30T07:06:27Z

@novawish Can you please squash last two commits in the migration one...

novawish · 2018-03-30T12:15:35Z

@feketemihai Done, i squashed those 2 commits

feketemihai · 2018-03-30T12:20:33Z

@novawish Thanks

hieulucky111 · 2018-05-04T03:33:47Z

hr_salary_rule_reference/__manifest__.py

+    'depends': [
+        'hr_payroll',
+    ],
+    'test': [],


Remove empty key: https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#modules

hieulucky111 · 2018-05-04T03:33:59Z

hr_salary_rule_reference/__manifest__.py

+        'hr_payroll',
+    ],
+    'test': [],
+    'demo': [],


hieulucky111

Some minor adjustments, LGTM over all.

denislour · 2018-05-04T03:39:10Z

hr_salary_rule_reference/__init__.py

@@ -0,0 +1,4 @@
+# Copyright 2013 Savoir-faire Linux


I did not do any customizations on this file, so i think it's good to keep it like that

denislour · 2018-05-04T03:39:19Z

hr_salary_rule_reference/__manifest__.py

@@ -0,0 +1,17 @@
+# Copyright 2013 Savoir-faire Linux


I did not do any customizations on this file, so i think it's good to keep it like that

denislour · 2018-05-04T03:41:50Z

hr_salary_rule_reference/__manifest__.py

+    'version': '11.0.1.0.0',
+    'license': 'AGPL-3',
+    'category': 'Generic Modules/Human Resources',
+    'author': "Savoir-faire Linux,Odoo Community Association (OCA)",


I think you should change the author below for new version:

'author': "<your name>" "Odoo Community Association (OCA)",

As OCA guildelines (link below), I think we just need to put the original author and OCA, no need for the migrators

denislour · 2018-05-04T03:42:13Z

hr_salary_rule_reference/__manifest__.py

+    'license': 'AGPL-3',
+    'category': 'Generic Modules/Human Resources',
+    'author': "Savoir-faire Linux,Odoo Community Association (OCA)",
+    'website': 'https://www.savoirfairelinux.com',


here your brand.

As per the OCA guidelines, the website element should look like: https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/__manifest__.py

denislour

For migrate new version, you should write your name with the year migrate.

denislour · 2018-05-04T03:45:17Z

hr_salary_rule_reference/models/__init__.py

@@ -0,0 +1,4 @@
+# Copyright 2013 Savoir-faire Linux


I did not do any customizations on this file, so i think it's good to keep it like that

denislour · 2018-05-04T03:45:26Z

hr_salary_rule_reference/models/hr_salary_rule.py

@@ -0,0 +1,28 @@
+# Copyright 2013 Savoir-faire Linux


I did not do any customizations on this file, so i think it's good to keep it like that

Trivedi-Vacha-SerpentCS · 2018-06-20T12:03:30Z

hr_salary_rule_reference/README.rst

+============
+
+There is no specific installation instruction for this module.
+


Kindly add usage section so it will help end user to check on runbot.
https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst

Thanks, I added Usage as the new template of OCA guidelines.

Trivedi-Vacha-SerpentCS · 2018-06-20T12:06:52Z

hr_salary_rule_reference/__manifest__.py

+    'license': 'AGPL-3',
+    'category': 'Generic Modules/Human Resources',
+    'author': "Savoir-faire Linux,Odoo Community Association (OCA)",
+    'website': 'https://www.savoirfairelinux.com',


As per the OCA guidelines, the website element should look like: https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/__manifest__.py

[BSSFL-511] Fix DN / Invoice price line calculation

github-actions · 2021-10-31T12:06:33Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

This was referenced Oct 11, 2017

[MIG] hr_salary_rule_reference: Migration to 11.0 #382

Closed

[MIG] Migrating hr_employee_benefit to Odoo 11.0 #381

Closed

[MIG] hr_employee_benefit: Migration to 11.0 #385

Closed

dufresnedavid and others added 6 commits October 15, 2017 23:54

Port hr_employee_benefit to 8.0

4fd3f63

Fix README files

d080b9c

Fix the salary rule reference function

fb3fe5d

[UPD] prefix versions with 8.0

d02ccf2

[MIG] Make modules uninstallable

ad50d53

[MIG] Rename manifest files

6a0026c

novawish force-pushed the 11.0-mig-hr_salary_rule_reference branch from a339e44 to 150e5d8 Compare October 15, 2017 17:00

pedrobaeza reviewed Oct 15, 2017

View reviewed changes

pedrobaeza added this to the 11.0 milestone Oct 31, 2017

feketemihai approved these changes Nov 9, 2017

View reviewed changes

feketemihai added the needs review label Nov 14, 2017

feketemihai closed this Mar 30, 2018

feketemihai reopened this Mar 30, 2018

novawish force-pushed the 11.0-mig-hr_salary_rule_reference branch from d95c4a7 to bc8bae2 Compare March 30, 2018 10:29

hieulucky111 reviewed May 4, 2018

View reviewed changes

hr_salary_rule_reference/__manifest__.py

'hr_payroll',

],

'test': [],

'demo': [],

Copy link

hieulucky111 May 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same above

hieulucky111 approved these changes May 4, 2018

View reviewed changes

denislour suggested changes May 4, 2018

View reviewed changes

Trivedi-Vacha-SerpentCS suggested changes Jun 20, 2018

View reviewed changes

[MIG] hr_salary_rule_reference: Migration to 11.0

b86b344

novawish force-pushed the 11.0-mig-hr_salary_rule_reference branch from bc8bae2 to b86b344 Compare June 24, 2018 03:55

sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018

Merge pull request OCA#384 from TelmoSenseFly/BSSFL-511

f6505a6

[BSSFL-511] Fix DN / Invoice price line calculation

emagdalenaC2i mentioned this pull request Jan 6, 2019

Migration to version 11.0 #374

Closed

71 tasks

Mraimou pushed a commit to camptocamp/hr that referenced this pull request Mar 27, 2020

merge OCA#384 fix data refresh problem after signature

af485a8

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 31, 2021

github-actions bot closed this Dec 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG] hr_salary_rule_reference: Migration to 11.0 #384

[MIG] hr_salary_rule_reference: Migration to 11.0 #384

novawish commented Oct 11, 2017

pedrobaeza commented Oct 12, 2017

novawish commented Oct 15, 2017

pedrobaeza Oct 15, 2017

feketemihai left a comment

feketemihai commented Mar 30, 2018 •

edited

Loading

novawish commented Mar 30, 2018

feketemihai commented Mar 30, 2018

hieulucky111 May 4, 2018

hieulucky111 May 4, 2018

hieulucky111 left a comment

denislour May 4, 2018

novawish Jun 24, 2018

denislour May 4, 2018

novawish Jun 24, 2018

denislour May 4, 2018

novawish Jun 24, 2018

denislour May 4, 2018

Trivedi-Vacha-SerpentCS Jun 20, 2018

denislour left a comment

denislour May 4, 2018

novawish Jun 24, 2018

denislour May 4, 2018

novawish Jun 24, 2018

Trivedi-Vacha-SerpentCS Jun 20, 2018

novawish Jun 24, 2018

Trivedi-Vacha-SerpentCS Jun 20, 2018

github-actions bot commented Oct 31, 2021

		============

		There is no specific installation instruction for this module.

[MIG] hr_salary_rule_reference: Migration to 11.0 #384

[MIG] hr_salary_rule_reference: Migration to 11.0 #384

Conversation

novawish commented Oct 11, 2017

pedrobaeza commented Oct 12, 2017

novawish commented Oct 15, 2017

Choose a reason for hiding this comment

feketemihai left a comment

Choose a reason for hiding this comment

feketemihai commented Mar 30, 2018 • edited Loading

novawish commented Mar 30, 2018

feketemihai commented Mar 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hieulucky111 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

denislour left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 31, 2021

feketemihai commented Mar 30, 2018 •

edited

Loading