[MIG] hr_employee_benefit: Migration to 11.0 #385
Conversation
…tic_Tag_Partner_2 [BIZ-1442][FIX] regenerate submodule branch
| is the same | ||
| """ | ||
| for record in self: | ||
| if not record.category_id == record.rate_id.category_id: |
There was a problem hiding this comment.
Its better to compare record id insted of record set
| string='Employee Benefits', | ||
| readonly=True, states={'draft': [('readonly', False)]}, | ||
| ) | ||
| pays_per_year = fields.Integer( |
There was a problem hiding this comment.
why you use readonly in compute field
| return self.contract_id.benefit_line_ids | ||
|
|
||
| @api.multi | ||
| def button_compute_benefits(self): |
There was a problem hiding this comment.
you can direct call the compute_benefits method in buttton I think no need to create new method.
hr_employee_benefit/__manifest__.py
Outdated
| 'license': 'AGPL-3', | ||
| 'category': 'Generic Modules/Human Resources', | ||
| 'author': "Savoir-faire Linux, Odoo Community Association (OCA)", | ||
| 'website': 'https://www.savoirfairelinux.com', |
There was a problem hiding this comment.
Replace website URL as per this
hr_employee_benefit/__manifest__.py
Outdated
| 'views/hr_payslip_view.xml', | ||
| 'views/hr_salary_rule_view.xml', | ||
| ], | ||
| 'test': [], |
There was a problem hiding this comment.
@novawish If not need then remove it
hr_employee_benefit/__manifest__.py
Outdated
| 'views/hr_salary_rule_view.xml', | ||
| ], | ||
| 'test': [], | ||
| 'demo': [], |
| <field name="name">hr.employee.benefit.category.form</field> | ||
| <field name="model">hr.employee.benefit.category</field> | ||
| <field name="arch" type="xml"> | ||
| <form string="Employee Benefits" version="7.0"> |
| <field name="name">hr.employee.benefit.rate.form</field> | ||
| <field name="model">hr.employee.benefit.rate</field> | ||
| <field name="arch" type="xml"> | ||
| <form string="Employee Benefits Rates" version="7.0"> |
novawish
force-pushed
the
11.0-mig-hr_employee_benefit
branch
from
a96bbae
to
57c29d8
Compare
|
Hey @novawish, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
|
@novawish Use new README by fragment system, copying https://github.com/OCA/maintainer-tools/tree/master/template/module/readme and editing or removing the needed sections. You can then run locally oca-gen-addon-readme if you have OCA/maintainer-tools installed and you want to pre-generate the README.rst file (preferred), or keep the previous README.rst file. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
This module depends on: