[MIG] [11.0] Migrate hr_payroll_cancel to 11.0 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the user to cancel a payslip whatever the previous state is.
jcdrubay
suggested changes
Apr 4, 2018
| for payslip in self: | ||
| if payslip.refunded_id and payslip.refunded_id.state != 'cancel': | ||
| raise ValidationError(_("""To cancel the Original Payslip the | ||
| Refunded Payslip needed to be canceled first!""")) |
hr_payroll_cancel/i18n/fr.po
Outdated
| #, python-format | ||
| msgid "" | ||
| "To cancel the Original Payslip the\n" | ||
| " Refunded Payslip needed to be canceled first!" |
hr_payroll_cancel/i18n/cs_CZ.po
Outdated
| #, python-format | ||
| msgid "" | ||
| "To cancel the Original Payslip the\n" | ||
| " Refunded Payslip needed to be canceled first!" |
novawish
force-pushed
the
11.0-mig-hr_payroll_cancel
branch
from
7455ab4
to
3ae14eb
Compare
|
Why is it writing the state on a single record ( |
novawish
force-pushed
the
11.0-mig-hr_payroll_cancel
branch
from
3ae14eb
to
ff9936d
Compare
novawish
force-pushed
the
11.0-mig-hr_payroll_cancel
branch
from
ff9936d
to
5c78709
Compare
|
@gabrielo77 Good question, IMO probably the original author's intention is that action always works for only one single record (since the button only appears on form view, and he returned right after the first loop). You are right actually, we should treat it like the whole recordsets no matter what because we were using I did a fix based on your PR, may I add you as a contributor for this module also? |
|
Sure, add me. I'm currently working on the test cases for this module. Hope I can push it ASAP so we can have this merged. |
|
This seems ready to merge, or is it codecov a needed check? |
hieulucky111
approved these changes
Jun 22, 2018
sambarros
pushed a commit
to sambarros/hr
that referenced
this pull request
Jul 26, 2018
[BSSFL-533] Repair line on Sale order line
Mraimou
pushed a commit
to camptocamp/hr
that referenced
this pull request
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.