Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] Migrate hr_experience #437

Merged
merged 23 commits into from
Jun 6, 2018
Merged

Conversation

ddufresne
Copy link
Contributor

No description provided.

@ddufresne ddufresne mentioned this pull request Apr 9, 2018
71 tasks
@ddufresne
Copy link
Contributor Author

The travis issue is unrelated with the module.

I proposed a fix anyway in a seperate PR:
#438

@pedrobaeza pedrobaeza added this to the 11.0 milestone Apr 9, 2018
@@ -0,0 +1,112 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ddufresne Thanks for the migration, can you please change to png files.


{
"name": "Experience Management",
"version": "1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update version number

<field name="certification" string="# Certificate"/>
<field name="partner_id" string="Issued By"/>
<field name="start_date"/>
<field name="end_date"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add expire field as well in tree view and adapt end_date domain.

<field name="certification" string="# Certificate"/>
<field name="partner_id" string="Issued By"/>
<field name="start_date"/>
<field name="end_date"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same, expire field and adapt end_date domain.

feketemihai and others added 21 commits April 10, 2018 07:13
Modify academic experiences form layout

Modify certificate form layout

Use simple header

Adjusting manifest file according OCA guidelines

Add readme file

view layout final touch
…notebook page.

In the employee form, put all fields related to the resume into the same page.
3 pages is overkill and inconsistent.
@ddufresne
Copy link
Contributor Author

@feketemihai all fixed!

@feketemihai
Copy link
Member

@ddufresne Thanks, i will test on runbot when finished.

@ddufresne
Copy link
Contributor Author

@feketemihai before you test, I am about to add some fixes on the xml views.

@ddufresne
Copy link
Contributor Author

@feketemihai ok, you may check runbot. Thanks!

@foutoucour
Copy link

Hello here,
Would you have an ETA on the merge of this PR?

Best,
Jordi

@pedrobaeza
Copy link
Member

@foutoucour each PR requires at least 2 approvals. Please make your review for getting this merged.

@ddufresne ddufresne merged commit 249c3bc into OCA:11.0 Jun 6, 2018
@foutoucour foutoucour deleted the 11.0-mig-hr_experience branch June 6, 2018 19:10
@ddufresne ddufresne restored the 11.0-mig-hr_experience branch June 11, 2018 22:06
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
[BSSFL-540] Sale / Quotation contact
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants