Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] hr_expense_invoice: Migration to 11.0 #525

Merged
merged 9 commits into from
Dec 13, 2018

Conversation

cubells
Copy link
Sponsor Member

@cubells cubells commented Dec 11, 2018

  • Standard migration
  • convert README.rst to oca fragments

cc @Tecnativa

@rafaelbn rafaelbn added this to the 11.0 milestone Dec 11, 2018
@rafaelbn
Copy link
Member

@cubells are you including this FIX #526 in this PR?

@cubells
Copy link
Sponsor Member Author

cubells commented Dec 11, 2018

Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Code

hr_expense_invoice/__manifest__.py Outdated Show resolved Hide resolved
hr_expense_invoice/models/hr_expense_sheet.py Outdated Show resolved Hide resolved
hr_expense_invoice/views/hr_expense_views.xml Outdated Show resolved Hide resolved
@cubells
Copy link
Sponsor Member Author

cubells commented Dec 13, 2018

@nikul-serpentcs thanks!

done.

pedrobaeza and others added 9 commits December 13, 2018 11:19
Set supplier invoices on HR expenses
====================================

This module should be used when a supplier invoice is paid by an employee. It
allows to set  a supplier invoice for each expense line, adding the
corresponding journal items to transfer the debt to the employee.

Installation
============

Install the module the regular way.

Configuration
=============

You don't need to configure anything more to use this module.

Usage
=====

Instead of coding a full expense line, select an existing supplier invoice,
and then the rest of the fields will be auto-filled and grayed.

When you generate the expenses account entries, lines with invoices filled
will be generated as opposite of the payable move line of the invoice, and
both will be reconciled, letting the employee payable account as the only
open balance.

Known issues / Roadmap
======================

* Multiple payment terms for a supplier invoice are not handled correctly.
* Partial reconcile supplier invoices are also not correctly handled.
…l amount (OCA#237)

On the same expense, when we have 2 or more lines with different invoices, and each invoices have the same total amount, reconcile is not possible.

The fix is to exclude reconcile account.move.line, and the first time if we have more than one line to reconcile on the same amount, we keep the first.
@pedrobaeza
Copy link
Member

Merging as @nikul-serpentcs's comments have been honored.

@pedrobaeza pedrobaeza merged commit 6e75283 into OCA:11.0 Dec 13, 2018
@pedrobaeza pedrobaeza deleted the 11.0-mig-hr_expense_invoice branch December 13, 2018 11:15
@pedrobaeza pedrobaeza mentioned this pull request Dec 13, 2018
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants