[12.0] [MIG] hr_payroll_cancel #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the user to cancel a payslip whatever the previous state is.
32 tasks
anandkansagra
approved these changes
Dec 22, 2018
|
Need to manage codecov |
nikul-serpentcs
force-pushed
the
12-hr_payroll_cancel
branch
from
382200a
to
835c064
Compare
|
@anandkansagra Done! |
|
@aheficent @pedrobaeza Can you please review & move forward |
|
Still needs to cover more |
nikul-serpentcs
force-pushed
the
12-hr_payroll_cancel
branch
from
f3e19a7
to
d10f7ea
Compare
LGTM @nikul-serpentcs |
nikul-serpentcs
force-pushed
the
12-hr_payroll_cancel
branch
from
d10f7ea
to
b9f2a9e
Compare
|
@aheficent @pedrobaeza Can you please review & move forward |
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hr Payroll Cancel
This module allows the user to cancel a payslip whatever the previous state is
without doing a refund. When the user cancel the journal entry is deleted
and the payslip state is set to rejected. Then the user is able to set the
state to draft again and later on he/she is able to confirm again the payslip.
If there’s a refund for a payslip the user should not cancel the entry because
the refund would still be confirm. In that case, the user have either to
confirm again the payslip or cancel the refund.