New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
13.0 mig hr holidays leave auto approve #704
13.0 mig hr holidays leave auto approve #704
Conversation
…to define a leave type in order to make the system automatically approving all the leave requests (and leave allocation requests) belonging to that leave type.
Alphabetical imports.
Currently translated at 100.0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_holidays_leave_auto_approve Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_leave_auto_approve/fa/
If tracking is disabled through the context, the module should not reenable it. closes #498
Currently translated at 100.0% (4 of 4 strings) Translation: hr-11.0/hr-11.0-hr_holidays_leave_auto_approve Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_leave_auto_approve/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/nl/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/nl_NL/
Currently translated at 75.0% (3 of 4 strings) Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/fr/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/de/
Currently translated at 100.0% (4 of 4 strings) Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/es/
Hey @Murtaza-Mithaiwala, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change
hr_holidays_leave_auto_approve/tests/test_hr_holidays_leave_auto_approve.py
Show resolved
Hide resolved
@Murtaza-Mithaiwala To fix travis see the new pre-commit https://odoo-community.org/blog/the-oca-blog-1/post/black-isort-pre-commit-97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM but travis is red because of the new pre-commit
Run it with -a flag |
Travis is green now |
@Murtaza-Mithaiwala Squash last commit |
Is it needed ? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review OK. I didn't test it.
Can you include this #663 in the migration? |
</field> | ||
</record> | ||
|
||
</odoo> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rename this file, from hr_holidays_status.xml
to hr_leave_type.xml
?
Just as a reminder, there's a standing PR #663 for V12 ready to be merged. Should be taken in consideration in case it's merged before this one. |
@pedrobaeza or @jbeficent please, could you review this PR? |
This one is missing #663 right now. |
Can you please move this to OCA/hr-holidays following #732? |
Superseded by OCA/hr-holidays#5 |
@OCA/community-maintainers @Murtaza-Mithaiwala This PR should be closed |
move on OCA/hr-holidays#5 |
No description provided.