Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13.0 mig hr holidays leave auto approve #704

Closed
wants to merge 25 commits into from
Closed

13.0 mig hr holidays leave auto approve #704

wants to merge 25 commits into from

Conversation

Murtaza-Mithaiwala
Copy link

No description provided.

aesposito-onestein and others added 24 commits October 16, 2019 21:39
…to define a leave type in order to make the system automatically approving all the leave requests (and leave allocation requests) belonging to that leave type.
Currently translated at 100.0% (4 of 4 strings)

Translation: hr-11.0/hr-11.0-hr_holidays_leave_auto_approve
Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_leave_auto_approve/fa/
If tracking is disabled through the context, the module should not
reenable it.

closes #498
Currently translated at 100.0% (4 of 4 strings)

Translation: hr-11.0/hr-11.0-hr_holidays_leave_auto_approve
Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_leave_auto_approve/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/
Currently translated at 100.0% (4 of 4 strings)

Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/nl/
Currently translated at 100.0% (4 of 4 strings)

Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/nl_NL/
Currently translated at 75.0% (3 of 4 strings)

Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/fr/
Currently translated at 100.0% (4 of 4 strings)

Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/de/
Currently translated at 100.0% (4 of 4 strings)

Translation: hr-12.0/hr-12.0-hr_holidays_leave_auto_approve
Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_leave_auto_approve/es/
@oca-clabot
Copy link

Hey @Murtaza-Mithaiwala, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@Murtaza-Mithaiwala Murtaza-Mithaiwala mentioned this pull request Oct 19, 2019
41 tasks
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking

hr_holidays_leave_auto_approve/README.rst Show resolved Hide resolved
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change

@emagdalenaC2i
Copy link

@Murtaza-Mithaiwala To fix travis see the new pre-commit https://odoo-community.org/blog/the-oca-blog-1/post/black-isort-pre-commit-97

Copy link

@emagdalenaC2i emagdalenaC2i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM but travis is red because of the new pre-commit

@Murtaza-Mithaiwala
Copy link
Author

In my local per-commit not display any error
Please see screen shot
live_name

@pedrobaeza
Copy link
Member

Run it with -a flag

@emagdalenaC2i
Copy link

Travis is green now

@nikul-serpentcs
Copy link
Member

@Murtaza-Mithaiwala Squash last commit

@Murtaza-Mithaiwala
Copy link
Author

Murtaza-Mithaiwala commented Oct 20, 2019

@nikul-serpentcs

Is it needed ?

@nikul-serpentcs
Copy link
Member

@nikul-serpentcs

Is it needed ?

Yes @Murtaza-Mithaiwala

Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK. I didn't test it.

@jarroyomorales
Copy link

Can you include this #663 in the migration?

@gurneyalex gurneyalex added this to the 13.0 milestone Oct 22, 2019
</field>
</record>

</odoo>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename this file, from hr_holidays_status.xml to hr_leave_type.xml?

@astirpe
Copy link
Member

astirpe commented Nov 12, 2019

Just as a reminder, there's a standing PR #663 for V12 ready to be merged. Should be taken in consideration in case it's merged before this one.

@emagdalenaC2i
Copy link

@pedrobaeza or @jbeficent please, could you review this PR?

@pedrobaeza
Copy link
Member

This one is missing #663 right now.

@pedrobaeza
Copy link
Member

Can you please move this to OCA/hr-holidays following #732?

@astirpe
Copy link
Member

astirpe commented Jan 22, 2020

Superseded by OCA/hr-holidays#5

@emagdalenaC2i
Copy link

@OCA/community-maintainers @Murtaza-Mithaiwala This PR should be closed

@Saran440
Copy link
Member

move on OCA/hr-holidays#5

@Saran440 Saran440 closed this Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet