[12.0][IMP] hr_attendance_rfid: Add record rule

[brian10048]

@HviorForgeFlow

[brian10048]

@HviorForgeFlow @JordiBForgeFlow
This should fix the issue when scanning RFID tags and receiving a security error when the RAS user attempts to make an attendance record from the scan

[marcelsavegnago]

Looks great for me

[HviorForgeFlow]

@jarroyomorales ready to move forward

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[Saran440]

Code Reviewed.

[Saran440]

Suggested change

	<odoo>
	<odoo noupdate="1">

[etobella]

If we are adding the noupdate, we should need to add a migration script that will create the rule

[HviorForgeFlow]

Really? even if that ir.model.data record is not already set on the system? OUCH

[etobella]

Or the forcecreate, but I would opt for the migration

[etobella]

Something as hard as this:
https://github.com/OCA/community-data-files/blob/12.0/account_payment_unece/migrations/12.0.1.0.0/post-migration.py#L8 😉

[Saran440]

I don't know about migration script.
if you add noupdate in code, Will it cause problems?

[jarroyomorales]

Something as hard as this:
https://github.com/OCA/community-data-files/blob/12.0/account_payment_unece/migrations/12.0.1.0.0/post-migration.py#L8 wink

I think this is the best option, better than the force_create

[jarroyomorales]

Nice! Thank you!

You also need to upgrade manually the manifest version to 12.0.1.0.2 and change the name of the migration folder to the same version (12.0.1.0.2). Then this will be merged with the nobump option

[brian10048]

Nice! Thank you!

You also need to upgrade manually the manifest version to 12.0.2.0.1 and change the name of the migration folder to the same version (12.0.2.0.1). Then this will be merged with the nobump option

I was just getting ready to comment and ask if I should manually update the manifest or if the merge bot was going to be told what to do! Now I have updated and manually bumped the manifest to 12.0.2.0.0 from 12.0.1.0.0

[jarroyomorales]

@brian10048 Yes, now we have to agree on the version number. It is not a very huge change so maybe instead of 12.0.2.0.0 we could do 12.0.1.1.0. @Saran440 What do you think?

[Saran440]

I agree with @jarroyomorales
it should be 12.0.1.1.0
and I will merge with nobump

[brian10048]

@Saran440 @jarroyomorales - Version changes made as requested

[etobella]

@OCA/human-resources-maintainers I think this is ready to merge 😉

[Saran440]

/ocabot merge nobump

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 12.0-ocabot-merge-pr-833-by-Saran440-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at bab439d. Thanks a lot for contributing to OCA. ❤️