Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][IMP] hr_attendance_modification_tracking: ADD 'time changed' -contains all commits- #844

Merged
merged 1 commit into from
Jul 6, 2020
Merged

[12.0][IMP] hr_attendance_modification_tracking: ADD 'time changed' -contains all commits- #844

merged 1 commit into from
Jul 6, 2020

Conversation

ns-landoo
Copy link

@ns-landoo ns-landoo commented Jun 1, 2020 •
edited
Loading

This PR contains all commits included in the all one #837

@ns-landoo ns-landoo mentioned this pull request Jun 1, 2020
Closed
jarroyomorales
jarroyomorales approved these changes Jun 2, 2020
View reviewed changes
Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It could be squashed in the other PR but its ok anyways. Thank you!

@Saran440 Can you check?

Saran440
Saran440 approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test. LGTM 👍

alexey-pelykh
alexey-pelykh approved these changes Jun 7, 2020
View reviewed changes
hr_attendance_modification_tracking/__manifest__.py
'summary': """
Attendance changes will now be registered in the chatter.""",
'version': '12.0.1.0.0',
'version': '12.0.1.1.0',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional, as it's being taken care of during merge

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Can we change it without starting again with all revision process?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexey-pelykh this case, Can I merge this pr with nobump?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@js-landoo
Copy link

@etobella @jarroyomorales and others. Could you merge this PR?
This way we could start with spanish translation. There is an issue with po file. It says is version (11).
Thanks.

etobella
etobella approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 @OCA/human-resources-maintainers I think this can be merged.

@feketemihai
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-844-by-feketemihai-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aeecea3 into OCA:12.0 Jul 6, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 34a7c0e. Thanks a lot for contributing to OCA. ❤️

@jarroyomorales jarroyomorales mentioned this pull request Jul 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js-landoo js-landoo js-landoo left review comments

@Saran440 Saran440 Saran440 approved these changes

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@etobella etobella etobella approved these changes

@jarroyomorales jarroyomorales jarroyomorales approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ns-landoo @OCA-git-bot @js-landoo @feketemihai @alexey-pelykh @marcelsavegnago @Saran440 @etobella @jarroyomorales