Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] Migrate hr_contract_multi_jobs #91

Merged
merged 14 commits into from
May 12, 2015
Merged

[MIG] Migrate hr_contract_multi_jobs #91

merged 14 commits into from
May 12, 2015

Conversation

feketemihai
Copy link
Member

No description provided.

This was referenced Apr 20, 2015
Merged
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+6.41%) to 50.0% when pulling 319f7ae on feketemihai:mig_hr_contract_multi_jobs into a96858e on OCA:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+6.41%) to 50.0% when pulling 319f7ae on feketemihai:mig_hr_contract_multi_jobs into a96858e on OCA:8.0.

@ghost
Copy link

ghost commented Apr 20, 2015

@feketemihai Thanks very much for porting the 2 modules. I agree on removing yaml tests, but only to replace them with python unittests.

@feketemihai
Copy link
Member Author

This is what i am doing now...

@coveralls
Copy link

Coverage Status

Coverage increased (+17.12%) to 60.71% when pulling f129f44 on feketemihai:mig_hr_contract_multi_jobs into a96858e on OCA:8.0.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+17.12%) to 60.71% when pulling f129f44 on feketemihai:mig_hr_contract_multi_jobs into a96858e on OCA:8.0.

hbrunn
hbrunn reviewed Apr 21, 2015
View reviewed changes
hr_contract_multi_jobs/models/hr_contract.py
Get the main job position from the field contract_job_ids which
contains one and only one record with field is_main_job == True
"""
for contract in self:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider using api.one instead of looping yourself

@gurneyalex gurneyalex added this to the 8.0 milestone Apr 21, 2015
@ghost
Copy link

ghost commented May 12, 2015

👍

1 similar comment
@max3903
Copy link
Sponsor Member

max3903 commented May 12, 2015

👍

max3903 pushed a commit that referenced this pull request May 12, 2015
Merge pull request #91 from feketemihai/mig_hr_contract_multi_jobs
a273d75 
[MIG] Migrate hr_contract_multi_jobs
@max3903 max3903 merged commit a273d75 into OCA:8.0 May 12, 2015
@feketemihai feketemihai deleted the mig_hr_contract_multi_jobs branch November 11, 2015 05:04
sambarros pushed a commit to sambarros/hr that referenced this pull request Jul 26, 2018
@TelmoSenseFly @yvaucher
Update ldap_filter parameter (OCA#91)
7682fad
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
@damdam-s
merge OCA#91 and resolve conflict
5e51a48
Mraimou pushed a commit to camptocamp/hr that referenced this pull request Nov 25, 2019
@damdam-s
Merge pull request OCA#93 from damdam-s/master
436da78 
Merge OCA#89 and OCA#91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@feketemihai @coveralls @max3903 @gurneyalex @hbrunn @yvaucher